[INFO] updating cached repository lholden/entity_system [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/lholden/entity_system [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/lholden/entity_system" "work/ex/clippy-test-run/sources/stable/gh/lholden/entity_system"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/lholden/entity_system'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/lholden/entity_system" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lholden/entity_system"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lholden/entity_system'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 561144bafed1d00374f16f0ec0734b04bd9cc9dd [INFO] sha for GitHub repo lholden/entity_system: 561144bafed1d00374f16f0ec0734b04bd9cc9dd [INFO] validating manifest of lholden/entity_system on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lholden/entity_system on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lholden/entity_system [INFO] finished frobbing lholden/entity_system [INFO] frobbed toml for lholden/entity_system written to work/ex/clippy-test-run/sources/stable/gh/lholden/entity_system/Cargo.toml [INFO] started frobbing lholden/entity_system [INFO] finished frobbing lholden/entity_system [INFO] frobbed toml for lholden/entity_system written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lholden/entity_system/Cargo.toml [INFO] crate lholden/entity_system has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lholden/entity_system against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/lholden/entity_system:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a09c386e0bafd0f6ac35d501a9aa7b3b323de2c000029ae9f3838ad588a8f091 [INFO] running `"docker" "start" "-a" "a09c386e0bafd0f6ac35d501a9aa7b3b323de2c000029ae9f3838ad588a8f091"` [INFO] [stderr] Checking entity_system v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:138:40 [INFO] [stderr] | [INFO] [stderr] 138 | let em = EntityMeta{entity:id, component:component}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `component` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:138:40 [INFO] [stderr] | [INFO] [stderr] 138 | let em = EntityMeta{entity:id, component:component}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `component` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `EntityManager` [INFO] [stderr] --> src/lib.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | / pub fn new() -> EntityManager [INFO] [stderr] 78 | | { [INFO] [stderr] 79 | | EntityManager { [INFO] [stderr] 80 | | id_counter: 0, [INFO] [stderr] 81 | | named_entities: HashMap::new(), [INFO] [stderr] 82 | | } [INFO] [stderr] 83 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 71 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `ComponentManager` [INFO] [stderr] --> src/lib.rs:122:5 [INFO] [stderr] | [INFO] [stderr] 122 | / pub fn new() -> ComponentManager [INFO] [stderr] 123 | | { [INFO] [stderr] 124 | | ComponentManager { [INFO] [stderr] 125 | | components: HashMap::new(), [INFO] [stderr] 126 | | entities: HashMap::new(), [INFO] [stderr] 127 | | } [INFO] [stderr] 128 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 116 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/lib.rs:134:14 [INFO] [stderr] | [INFO] [stderr] 134 | .or_insert(Box::new(Vec::new() as Vec>)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| Box::new(Vec::new() as Vec>))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/lib.rs:142:14 [INFO] [stderr] | [INFO] [stderr] 142 | .or_insert(HashMap::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashMap::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/lib.rs:145:14 [INFO] [stderr] | [INFO] [stderr] 145 | .or_insert(Box::new(Vec::new() as Vec<*mut T>)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| Box::new(Vec::new() as Vec<*mut T>))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:157:9 [INFO] [stderr] | [INFO] [stderr] 157 | / self.components.get(&TypeId::of::()) [INFO] [stderr] 158 | | .expect("components for T to exist") [INFO] [stderr] 159 | | .downcast_ref::>>() [INFO] [stderr] 160 | | .expect("downcast to Vec<(EntityId, T)>") [INFO] [stderr] 161 | | .iter() [INFO] [stderr] 162 | | .map(|meta| meta.clone()) [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 157 | self.components.get(&TypeId::of::()) [INFO] [stderr] 158 | .expect("components for T to exist") [INFO] [stderr] 159 | .downcast_ref::>>() [INFO] [stderr] 160 | .expect("downcast to Vec<(EntityId, T)>") [INFO] [stderr] 161 | .iter().cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `EntityManager` [INFO] [stderr] --> src/lib.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | / pub fn new() -> EntityManager [INFO] [stderr] 78 | | { [INFO] [stderr] 79 | | EntityManager { [INFO] [stderr] 80 | | id_counter: 0, [INFO] [stderr] 81 | | named_entities: HashMap::new(), [INFO] [stderr] 82 | | } [INFO] [stderr] 83 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 71 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `ComponentManager` [INFO] [stderr] --> src/lib.rs:122:5 [INFO] [stderr] | [INFO] [stderr] 122 | / pub fn new() -> ComponentManager [INFO] [stderr] 123 | | { [INFO] [stderr] 124 | | ComponentManager { [INFO] [stderr] 125 | | components: HashMap::new(), [INFO] [stderr] 126 | | entities: HashMap::new(), [INFO] [stderr] 127 | | } [INFO] [stderr] 128 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 116 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/lib.rs:134:14 [INFO] [stderr] | [INFO] [stderr] 134 | .or_insert(Box::new(Vec::new() as Vec>)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| Box::new(Vec::new() as Vec>))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/lib.rs:142:14 [INFO] [stderr] | [INFO] [stderr] 142 | .or_insert(HashMap::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashMap::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/lib.rs:145:14 [INFO] [stderr] | [INFO] [stderr] 145 | .or_insert(Box::new(Vec::new() as Vec<*mut T>)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| Box::new(Vec::new() as Vec<*mut T>))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:157:9 [INFO] [stderr] | [INFO] [stderr] 157 | / self.components.get(&TypeId::of::()) [INFO] [stderr] 158 | | .expect("components for T to exist") [INFO] [stderr] 159 | | .downcast_ref::>>() [INFO] [stderr] 160 | | .expect("downcast to Vec<(EntityId, T)>") [INFO] [stderr] 161 | | .iter() [INFO] [stderr] 162 | | .map(|meta| meta.clone()) [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 157 | self.components.get(&TypeId::of::()) [INFO] [stderr] 158 | .expect("components for T to exist") [INFO] [stderr] 159 | .downcast_ref::>>() [INFO] [stderr] 160 | .expect("downcast to Vec<(EntityId, T)>") [INFO] [stderr] 161 | .iter().cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error[E0658]: The attribute `deriving` is currently unknown to the compiler and may have meaning added to it in the future (see issue #29642) [INFO] [stderr] --> benches/lib.rs:4:3 [INFO] [stderr] | [INFO] [stderr] 4 | #[deriving(Clone)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error[E0658]: The attribute `deriving` is currently unknown to the compiler and may have meaning added to it in the future (see issue #29642) [INFO] [stderr] --> benches/lib.rs:9:3 [INFO] [stderr] | [INFO] [stderr] 9 | #[deriving(Clone)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] error: Could not compile `entity_system`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "a09c386e0bafd0f6ac35d501a9aa7b3b323de2c000029ae9f3838ad588a8f091"` [INFO] running `"docker" "rm" "-f" "a09c386e0bafd0f6ac35d501a9aa7b3b323de2c000029ae9f3838ad588a8f091"` [INFO] [stdout] a09c386e0bafd0f6ac35d501a9aa7b3b323de2c000029ae9f3838ad588a8f091