[INFO] updating cached repository lheckemann/clonequest
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/lheckemann/clonequest
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/lheckemann/clonequest" "work/ex/clippy-test-run/sources/stable/gh/lheckemann/clonequest"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/lheckemann/clonequest'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/lheckemann/clonequest" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lheckemann/clonequest"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lheckemann/clonequest'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] b18ced7c8bf306ff75750bde1d1fee0f76a51172
[INFO] sha for GitHub repo lheckemann/clonequest: b18ced7c8bf306ff75750bde1d1fee0f76a51172
[INFO] validating manifest of lheckemann/clonequest on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of lheckemann/clonequest on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing lheckemann/clonequest
[INFO] finished frobbing lheckemann/clonequest
[INFO] frobbed toml for lheckemann/clonequest written to work/ex/clippy-test-run/sources/stable/gh/lheckemann/clonequest/Cargo.toml
[INFO] started frobbing lheckemann/clonequest
[INFO] finished frobbing lheckemann/clonequest
[INFO] frobbed toml for lheckemann/clonequest written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lheckemann/clonequest/Cargo.toml
[INFO] crate lheckemann/clonequest has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting lheckemann/clonequest against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/lheckemann/clonequest:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 95c36ae46b9ac7c79f6975ea74bda16f654227e90a21e45d120c6ebe6813365e
[INFO] running `"docker" "start" "-a" "95c36ae46b9ac7c79f6975ea74bda16f654227e90a21e45d120c6ebe6813365e"`
[INFO] [stderr]     Checking rand v0.5.0
[INFO] [stderr]     Checking clonequest v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:178:13
[INFO] [stderr]     |
[INFO] [stderr] 178 |             pos: pos,
[INFO] [stderr]     |             ^^^^^^^^ help: replace it with: `pos`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:182:13
[INFO] [stderr]     |
[INFO] [stderr] 182 |             planets: planets,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `planets`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:183:13
[INFO] [stderr]     |
[INFO] [stderr] 183 |             players: players,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `players`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:186:13
[INFO] [stderr]     |
[INFO] [stderr] 186 |             w: w,
[INFO] [stderr]     |             ^^^^ help: replace it with: `w`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:187:13
[INFO] [stderr]     |
[INFO] [stderr] 187 |             h: h,
[INFO] [stderr]     |             ^^^^ help: replace it with: `h`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]    --> src/main.rs:214:13
[INFO] [stderr]     |
[INFO] [stderr] 214 |             println!("")
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:178:13
[INFO] [stderr]     |
[INFO] [stderr] 178 |             pos: pos,
[INFO] [stderr]     |             ^^^^^^^^ help: replace it with: `pos`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:182:13
[INFO] [stderr]     |
[INFO] [stderr] 182 |             planets: planets,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `planets`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:183:13
[INFO] [stderr]     |
[INFO] [stderr] 183 |             players: players,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `players`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:186:13
[INFO] [stderr]     |
[INFO] [stderr] 186 |             w: w,
[INFO] [stderr]     |             ^^^^ help: replace it with: `w`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:187:13
[INFO] [stderr]     |
[INFO] [stderr] 187 |             h: h,
[INFO] [stderr]     |             ^^^^ help: replace it with: `h`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]    --> src/main.rs:214:13
[INFO] [stderr]     |
[INFO] [stderr] 214 |             println!("")
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:41:23
[INFO] [stderr]    |
[INFO] [stderr] 41 | const PLANET_NAMES : &'static str = "ABCDEFGHIJKLMNOPQRSTUVWXYZ";
[INFO] [stderr]    |                      -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:267:17
[INFO] [stderr]     |
[INFO] [stderr] 267 |                 return Ok(());
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:289:17
[INFO] [stderr]     |
[INFO] [stderr] 289 |                 return Ok(());
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:299:17
[INFO] [stderr]     |
[INFO] [stderr] 299 |                 return self.send_fleet(src, dest, count).map_err(|e| e.to_string());
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.send_fleet(src, dest, count).map_err(|e| e.to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:309:17
[INFO] [stderr]     |
[INFO] [stderr] 309 |                 return Ok(());
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:311:18
[INFO] [stderr]     |
[INFO] [stderr] 311 |             _ => return Err("No command".to_string())
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("No command".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:41:23
[INFO] [stderr]    |
[INFO] [stderr] 41 | const PLANET_NAMES : &'static str = "ABCDEFGHIJKLMNOPQRSTUVWXYZ";
[INFO] [stderr]    |                      -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:267:17
[INFO] [stderr]     |
[INFO] [stderr] 267 |                 return Ok(());
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:289:17
[INFO] [stderr]     |
[INFO] [stderr] 289 |                 return Ok(());
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:299:17
[INFO] [stderr]     |
[INFO] [stderr] 299 |                 return self.send_fleet(src, dest, count).map_err(|e| e.to_string());
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.send_fleet(src, dest, count).map_err(|e| e.to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:309:17
[INFO] [stderr]     |
[INFO] [stderr] 309 |                 return Ok(());
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:311:18
[INFO] [stderr]     |
[INFO] [stderr] 311 |             _ => return Err("No command".to_string())
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("No command".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `e`
[INFO] [stderr]    --> src/main.rs:256:17
[INFO] [stderr]     |
[INFO] [stderr] 256 |             Err(e) => ()  // TODO: handle error, e is IoError
[INFO] [stderr]     |                 ^ help: consider using `_e` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `current_player`
[INFO] [stderr]   --> src/main.rs:70:5
[INFO] [stderr]    |
[INFO] [stderr] 70 |     pub fn current_player(&self) -> &Player {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false
[INFO] [stderr]    --> src/main.rs:120:36
[INFO] [stderr]     |
[INFO] [stderr] 120 |                                 if fleet.ships <= 0 {
[INFO] [stderr]     |                                    ^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::absurd_extreme_comparisons)] on by default
[INFO] [stderr]     = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using fleet.ships == 0 instead
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons
[INFO] [stderr] 
[INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false
[INFO] [stderr]    --> src/main.rs:127:36
[INFO] [stderr]     |
[INFO] [stderr] 127 |                                 if dest_planet.ships <= 0 {
[INFO] [stderr]     |                                    ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using dest_planet.ships == 0 instead
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/main.rs:211:30
[INFO] [stderr]     |
[INFO] [stderr] 211 |                             .unwrap_or(" ".to_string())
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| " ".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/main.rs:222:39
[INFO] [stderr]     |
[INFO] [stderr] 222 |     fn get_planet_index(&self, name : &String) -> Result<usize, String> {
[INFO] [stderr]     |                                       ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/main.rs:229:26
[INFO] [stderr]     |
[INFO] [stderr] 229 |                         .ok_or("no such planet".to_string())
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "no such planet".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]    --> src/main.rs:249:9
[INFO] [stderr]     |
[INFO] [stderr] 249 |         io::stdout().flush();
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_must_use)] on by default
[INFO] [stderr]     = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]    --> src/main.rs:261:12
[INFO] [stderr]     |
[INFO] [stderr] 261 |         if tokens.len() < 1 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `tokens.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/main.rs:277:65
[INFO] [stderr]     |
[INFO] [stderr] 277 |                             planet.owner.map(|i| i.to_string()).unwrap_or("N".to_string())
[INFO] [stderr]     |                                                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "N".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 2 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `clonequest`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: unused variable: `e`
[INFO] [stderr]    --> src/main.rs:256:17
[INFO] [stderr]     |
[INFO] [stderr] 256 |             Err(e) => ()  // TODO: handle error, e is IoError
[INFO] [stderr]     |                 ^ help: consider using `_e` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `current_player`
[INFO] [stderr]   --> src/main.rs:70:5
[INFO] [stderr]    |
[INFO] [stderr] 70 |     pub fn current_player(&self) -> &Player {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false
[INFO] [stderr]    --> src/main.rs:120:36
[INFO] [stderr]     |
[INFO] [stderr] 120 |                                 if fleet.ships <= 0 {
[INFO] [stderr]     |                                    ^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::absurd_extreme_comparisons)] on by default
[INFO] [stderr]     = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using fleet.ships == 0 instead
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons
[INFO] [stderr] 
[INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false
[INFO] [stderr]    --> src/main.rs:127:36
[INFO] [stderr]     |
[INFO] [stderr] 127 |                                 if dest_planet.ships <= 0 {
[INFO] [stderr]     |                                    ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using dest_planet.ships == 0 instead
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/main.rs:211:30
[INFO] [stderr]     |
[INFO] [stderr] 211 |                             .unwrap_or(" ".to_string())
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| " ".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/main.rs:222:39
[INFO] [stderr]     |
[INFO] [stderr] 222 |     fn get_planet_index(&self, name : &String) -> Result<usize, String> {
[INFO] [stderr]     |                                       ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/main.rs:229:26
[INFO] [stderr]     |
[INFO] [stderr] 229 |                         .ok_or("no such planet".to_string())
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "no such planet".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]    --> src/main.rs:249:9
[INFO] [stderr]     |
[INFO] [stderr] 249 |         io::stdout().flush();
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_must_use)] on by default
[INFO] [stderr]     = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]    --> src/main.rs:261:12
[INFO] [stderr]     |
[INFO] [stderr] 261 |         if tokens.len() < 1 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `tokens.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/main.rs:277:65
[INFO] [stderr]     |
[INFO] [stderr] 277 |                             planet.owner.map(|i| i.to_string()).unwrap_or("N".to_string())
[INFO] [stderr]     |                                                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "N".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 2 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `clonequest`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "95c36ae46b9ac7c79f6975ea74bda16f654227e90a21e45d120c6ebe6813365e"`
[INFO] running `"docker" "rm" "-f" "95c36ae46b9ac7c79f6975ea74bda16f654227e90a21e45d120c6ebe6813365e"`
[INFO] [stdout] 95c36ae46b9ac7c79f6975ea74bda16f654227e90a21e45d120c6ebe6813365e