[INFO] updating cached repository levkk/rust-chess [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/levkk/rust-chess [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/levkk/rust-chess" "work/ex/clippy-test-run/sources/stable/gh/levkk/rust-chess"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/levkk/rust-chess'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/levkk/rust-chess" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/levkk/rust-chess"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/levkk/rust-chess'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d7e98a6431b6055577180cea95812dc309d90ade [INFO] sha for GitHub repo levkk/rust-chess: d7e98a6431b6055577180cea95812dc309d90ade [INFO] validating manifest of levkk/rust-chess on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of levkk/rust-chess on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing levkk/rust-chess [INFO] finished frobbing levkk/rust-chess [INFO] frobbed toml for levkk/rust-chess written to work/ex/clippy-test-run/sources/stable/gh/levkk/rust-chess/Cargo.toml [INFO] started frobbing levkk/rust-chess [INFO] finished frobbing levkk/rust-chess [INFO] frobbed toml for levkk/rust-chess written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/levkk/rust-chess/Cargo.toml [INFO] crate levkk/rust-chess has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting levkk/rust-chess against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/levkk/rust-chess:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 79d2156a2f9f6a58b8f3d3ef0f2143706845c48424c612d46638ed01a6262e3c [INFO] running `"docker" "start" "-a" "79d2156a2f9f6a58b8f3d3ef0f2143706845c48424c612d46638ed01a6262e3c"` [INFO] [stderr] Checking tobj v0.1.6 [INFO] [stderr] Compiling glfw-sys v3.2.2 [INFO] [stderr] Checking num-complex v0.2.0 [INFO] [stderr] Checking num-bigint v0.2.0 [INFO] [stderr] Checking num-iter v0.1.37 [INFO] [stderr] Checking cgmath v0.16.1 [INFO] [stderr] Checking regex v0.2.11 [INFO] [stderr] Checking hyper v0.12.11 [INFO] [stderr] Checking num-rational v0.2.1 [INFO] [stderr] Checking num v0.2.0 [INFO] [stderr] Checking hyper-tls v0.3.1 [INFO] [stderr] Checking glfw v0.25.0 [INFO] [stderr] Checking reqwest v0.9.2 [INFO] [stderr] Checking rust_chess v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/connection.rs:78:47 [INFO] [stderr] | [INFO] [stderr] 78 | TcpConnectionDelimiter::EndOfMessage => write!(f, "\r\n"), // Just like HTTP [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/connection.rs:78:47 [INFO] [stderr] | [INFO] [stderr] 78 | TcpConnectionDelimiter::EndOfMessage => write!(f, "\r\n"), // Just like HTTP [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/board.rs:409:11 [INFO] [stderr] | [INFO] [stderr] 409 | return (dx == 0 && dy == 1 && !self.has_piece(to)) || (dx == 1 && dy == 1 && self.has_piece(to)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(dx == 0 && dy == 1 && !self.has_piece(to)) || (dx == 1 && dy == 1 && self.has_piece(to))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/board.rs:413:11 [INFO] [stderr] | [INFO] [stderr] 413 | return (dx == 0 && (dy == 1 || dy == 2) && !self.has_piece(to)) || (dx == 1 && dy == 1 && self.has_piece(to)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(dx == 0 && (dy == 1 || dy == 2) && !self.has_piece(to)) || (dx == 1 && dy == 1 && self.has_piece(to))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/board.rs:419:9 [INFO] [stderr] | [INFO] [stderr] 419 | return (dx == 0 && dy != 0) || (dx != 0 && dy == 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(dx == 0 && dy != 0) || (dx != 0 && dy == 0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/board.rs:424:9 [INFO] [stderr] | [INFO] [stderr] 424 | return (dx == 2 && dy == 1) || (dx == 1 && dy == 2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(dx == 2 && dy == 1) || (dx == 1 && dy == 2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/board.rs:428:9 [INFO] [stderr] | [INFO] [stderr] 428 | return dx == dy && dx != 0; // Only on a diagonal, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `dx == dy && dx != 0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/board.rs:433:9 [INFO] [stderr] | [INFO] [stderr] 433 | return (dx == dy && dx != 0) || (dx == 0 && dy != 0) || (dx == 0 && dy != 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(dx == dy && dx != 0) || (dx == 0 && dy != 0) || (dx == 0 && dy != 0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/board.rs:438:11 [INFO] [stderr] | [INFO] [stderr] 438 | return dx == 1 || dy == 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `dx == 1 || dy == 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/board.rs:442:12 [INFO] [stderr] | [INFO] [stderr] 442 | return (dx == 1 || dy == 1) && (dx == 2 && dy == 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(dx == 1 || dy == 1) && (dx == 2 && dy == 0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/board.rs:447:9 [INFO] [stderr] | [INFO] [stderr] 447 | return false; // Irrelevant. [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/board.rs:459:5 [INFO] [stderr] | [INFO] [stderr] 459 | return self.board[coord.0][coord.1].piece.piece_type != Piece::Nil; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.board[coord.0][coord.1].piece.piece_type != Piece::Nil` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/board.rs:464:5 [INFO] [stderr] | [INFO] [stderr] 464 | return self.board[coord.0][coord.1].color.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.board[coord.0][coord.1].color.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `super::*` [INFO] [stderr] --> src/board.rs:507:7 [INFO] [stderr] | [INFO] [stderr] 507 | use super::*; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game.rs:72:7 [INFO] [stderr] | [INFO] [stderr] 72 | return Err("Illegal move notation (regex)."); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("Illegal move notation (regex).")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `collections` [INFO] [stderr] --> src/connection.rs:7:30 [INFO] [stderr] | [INFO] [stderr] 7 | use std::{net, thread, time, collections}; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/connection.rs:250:9 [INFO] [stderr] | [INFO] [stderr] 250 | location_header [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/connection.rs:249:31 [INFO] [stderr] | [INFO] [stderr] 249 | let location_header = String::from(headers[header::LOCATION].to_str().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/model_loader.rs:55:3 [INFO] [stderr] | [INFO] [stderr] 55 | return models; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `models` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `channel` [INFO] [stderr] --> src/gui.rs:29:23 [INFO] [stderr] | [INFO] [stderr] 29 | use std::sync::mpsc::{channel, Receiver, Sender}; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gui.rs:144:5 [INFO] [stderr] | [INFO] [stderr] 144 | return self.window.should_close() || self.should_close; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.window.should_close() || self.should_close` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/gui.rs:384:16 [INFO] [stderr] | [INFO] [stderr] 384 | else { [INFO] [stderr] | ________________^ [INFO] [stderr] 385 | | if model.is_dragging() { [INFO] [stderr] 386 | | model.dragging(x_gl, y_gl); [INFO] [stderr] 387 | | } [INFO] [stderr] 388 | | } [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 384 | else if model.is_dragging() { [INFO] [stderr] 385 | model.dragging(x_gl, y_gl); [INFO] [stderr] 386 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/models/piece.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | return (-1.0 + slope * (input as f32 - 0.0)) as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(-1.0 + slope * (input as f32 - 0.0)) as f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/models/piece.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | return (0.0 + slope * (input - (-1.0))) as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(0.0 + slope * (input - (-1.0))) as usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `super::*` [INFO] [stderr] --> src/models/piece.rs:171:7 [INFO] [stderr] | [INFO] [stderr] 171 | use super::*; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/board.rs:409:11 [INFO] [stderr] | [INFO] [stderr] 409 | return (dx == 0 && dy == 1 && !self.has_piece(to)) || (dx == 1 && dy == 1 && self.has_piece(to)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(dx == 0 && dy == 1 && !self.has_piece(to)) || (dx == 1 && dy == 1 && self.has_piece(to))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/board.rs:413:11 [INFO] [stderr] | [INFO] [stderr] 413 | return (dx == 0 && (dy == 1 || dy == 2) && !self.has_piece(to)) || (dx == 1 && dy == 1 && self.has_piece(to)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(dx == 0 && (dy == 1 || dy == 2) && !self.has_piece(to)) || (dx == 1 && dy == 1 && self.has_piece(to))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/board.rs:419:9 [INFO] [stderr] | [INFO] [stderr] 419 | return (dx == 0 && dy != 0) || (dx != 0 && dy == 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(dx == 0 && dy != 0) || (dx != 0 && dy == 0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/board.rs:424:9 [INFO] [stderr] | [INFO] [stderr] 424 | return (dx == 2 && dy == 1) || (dx == 1 && dy == 2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(dx == 2 && dy == 1) || (dx == 1 && dy == 2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/board.rs:428:9 [INFO] [stderr] | [INFO] [stderr] 428 | return dx == dy && dx != 0; // Only on a diagonal, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `dx == dy && dx != 0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/board.rs:433:9 [INFO] [stderr] | [INFO] [stderr] 433 | return (dx == dy && dx != 0) || (dx == 0 && dy != 0) || (dx == 0 && dy != 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(dx == dy && dx != 0) || (dx == 0 && dy != 0) || (dx == 0 && dy != 0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/board.rs:438:11 [INFO] [stderr] | [INFO] [stderr] 438 | return dx == 1 || dy == 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `dx == 1 || dy == 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/board.rs:442:12 [INFO] [stderr] | [INFO] [stderr] 442 | return (dx == 1 || dy == 1) && (dx == 2 && dy == 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(dx == 1 || dy == 1) && (dx == 2 && dy == 0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/board.rs:447:9 [INFO] [stderr] | [INFO] [stderr] 447 | return false; // Irrelevant. [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/board.rs:459:5 [INFO] [stderr] | [INFO] [stderr] 459 | return self.board[coord.0][coord.1].piece.piece_type != Piece::Nil; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.board[coord.0][coord.1].piece.piece_type != Piece::Nil` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/board.rs:464:5 [INFO] [stderr] | [INFO] [stderr] 464 | return self.board[coord.0][coord.1].color.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.board[coord.0][coord.1].color.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game.rs:72:7 [INFO] [stderr] | [INFO] [stderr] 72 | return Err("Illegal move notation (regex)."); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("Illegal move notation (regex).")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `collections` [INFO] [stderr] --> src/connection.rs:7:30 [INFO] [stderr] | [INFO] [stderr] 7 | use std::{net, thread, time, collections}; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/connection.rs:250:9 [INFO] [stderr] | [INFO] [stderr] 250 | location_header [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/connection.rs:249:31 [INFO] [stderr] | [INFO] [stderr] 249 | let location_header = String::from(headers[header::LOCATION].to_str().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/model_loader.rs:55:3 [INFO] [stderr] | [INFO] [stderr] 55 | return models; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `models` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gui.rs:144:5 [INFO] [stderr] | [INFO] [stderr] 144 | return self.window.should_close() || self.should_close; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.window.should_close() || self.should_close` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/gui.rs:384:16 [INFO] [stderr] | [INFO] [stderr] 384 | else { [INFO] [stderr] | ________________^ [INFO] [stderr] 385 | | if model.is_dragging() { [INFO] [stderr] 386 | | model.dragging(x_gl, y_gl); [INFO] [stderr] 387 | | } [INFO] [stderr] 388 | | } [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 384 | else if model.is_dragging() { [INFO] [stderr] 385 | model.dragging(x_gl, y_gl); [INFO] [stderr] 386 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/models/piece.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | return (-1.0 + slope * (input as f32 - 0.0)) as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(-1.0 + slope * (input as f32 - 0.0)) as f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/models/piece.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | return (0.0 + slope * (input - (-1.0))) as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(0.0 + slope * (input - (-1.0))) as usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `mesh` [INFO] [stderr] --> src/model_loader.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | let mesh = &m.mesh; [INFO] [stderr] | ^^^^ help: consider using `_mesh` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `RETRY_ATTEMPTS_HTTP` [INFO] [stderr] --> src/connection.rs:23:1 [INFO] [stderr] | [INFO] [stderr] 23 | const RETRY_ATTEMPTS_HTTP: i32 = 5; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `zoom` [INFO] [stderr] --> src/camera.rs:22:3 [INFO] [stderr] | [INFO] [stderr] 22 | zoom: f32, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/board.rs:101:5 [INFO] [stderr] | [INFO] [stderr] 101 | write!(f, "{}", color); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/board.rs:419:16 [INFO] [stderr] | [INFO] [stderr] 419 | return (dx == 0 && dy != 0) || (dx != 0 && dy == 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `dx == 0 && dy != 0 || dx != 0 && dy == 0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/board.rs:433:16 [INFO] [stderr] | [INFO] [stderr] 433 | return (dx == dy && dx != 0) || (dx == 0 && dy != 0) || (dx == 0 && dy != 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 433 | return dx == 0 && dy != 0 || dx == dy && dx != 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] 433 | return !(dx == 0 && dy == 0 || dx != dy && dx != 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] 433 | return (dx != 0 || dy != 0) && (dx == dy || dx == 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/board.rs:400:3 [INFO] [stderr] | [INFO] [stderr] 400 | / fn validate_move(&self, from: (usize, usize), to: (usize, usize), piece: &GamePiece) -> bool { [INFO] [stderr] 401 | | [INFO] [stderr] 402 | | let (dx, dy) = Self::d(from, to); [INFO] [stderr] 403 | | [INFO] [stderr] ... | [INFO] [stderr] 449 | | } [INFO] [stderr] 450 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: unused variable: `mesh` [INFO] [stderr] --> src/model_loader.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | let mesh = &m.mesh; [INFO] [stderr] | ^^^^ help: consider using `_mesh` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/game.rs:157:9 [INFO] [stderr] | [INFO] [stderr] 157 | / match board_receiver.recv_timeout(Duration::from_millis(100)) { [INFO] [stderr] 158 | | Ok(new_board) => { [INFO] [stderr] 159 | | // Update board with new or old board [INFO] [stderr] 160 | | window.update_board(new_board.clone()); [INFO] [stderr] 161 | | } [INFO] [stderr] 162 | | Err(_) => (), [INFO] [stderr] 163 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 157 | if let Ok(new_board) = board_receiver.recv_timeout(Duration::from_millis(100)) { [INFO] [stderr] 158 | // Update board with new or old board [INFO] [stderr] 159 | window.update_board(new_board.clone()); [INFO] [stderr] 160 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/game.rs:166:9 [INFO] [stderr] | [INFO] [stderr] 166 | / match close_receiver.recv_timeout(Duration::from_millis(10)) { [INFO] [stderr] 167 | | Ok(close) => { [INFO] [stderr] 168 | | if close { [INFO] [stderr] 169 | | window.close(); [INFO] [stderr] ... | [INFO] [stderr] 172 | | Err(_) => (), [INFO] [stderr] 173 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 166 | if let Ok(close) = close_receiver.recv_timeout(Duration::from_millis(10)) { [INFO] [stderr] 167 | if close { [INFO] [stderr] 168 | window.close(); [INFO] [stderr] 169 | } [INFO] [stderr] 170 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/game.rs:228:9 [INFO] [stderr] | [INFO] [stderr] 228 | / match gui_receiver.recv_timeout(Duration::from_millis(100)) { [INFO] [stderr] 229 | | Ok(gui_input) => { [INFO] [stderr] 230 | | received_input = true; [INFO] [stderr] 231 | | input = gui_input; [INFO] [stderr] 232 | | }, [INFO] [stderr] 233 | | Err(_) => (), // Received nothing yet [INFO] [stderr] 234 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 228 | if let Ok(gui_input) = gui_receiver.recv_timeout(Duration::from_millis(100)) { [INFO] [stderr] 229 | received_input = true; [INFO] [stderr] 230 | input = gui_input; [INFO] [stderr] 231 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/game.rs:263:9 [INFO] [stderr] | [INFO] [stderr] 263 | board_sender.send(self.board.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/client.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | / let connection: Box; [INFO] [stderr] 78 | | [INFO] [stderr] 79 | | // TCP [INFO] [stderr] 80 | | if addr.starts_with("tcp://") { [INFO] [stderr] ... | [INFO] [stderr] 91 | | connection = Box::new(EchoConnection::new()); [INFO] [stderr] 92 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let connection = if addr.starts_with("tcp://") { ..; Box::new(listener) } else { Box::new(EchoConnection::new()) };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `connection::EchoConnection` [INFO] [stderr] --> src/connection.rs:43:3 [INFO] [stderr] | [INFO] [stderr] 43 | / pub fn new() -> Self { [INFO] [stderr] 44 | | EchoConnection{} [INFO] [stderr] 45 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 37 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: The function/method `write` doesn't need a mutable reference [INFO] [stderr] --> src/connection.rs:136:29 [INFO] [stderr] | [INFO] [stderr] 136 | match self.stream.write(&mut raw_data) { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `connection::SelfConnection` [INFO] [stderr] --> src/connection.rs:190:3 [INFO] [stderr] | [INFO] [stderr] 190 | / pub fn new() -> SelfConnection { [INFO] [stderr] 191 | | SelfConnection{} [INFO] [stderr] 192 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 185 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/connection.rs:331:5 [INFO] [stderr] | [INFO] [stderr] 331 | self.client.delete(&format!("{}/clients/{}", self.endpoint, self.name)).send(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/graphic_object.rs:117:36 [INFO] [stderr] | [INFO] [stderr] 117 | pub fn update(&mut self, points: &Vec, indices: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 117 | pub fn update(&mut self, points: &[Vertice], indices: &Vec) { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] help: change `points.clone()` to [INFO] [stderr] | [INFO] [stderr] 118 | self.points = points.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/graphic_object.rs:117:60 [INFO] [stderr] | [INFO] [stderr] 117 | pub fn update(&mut self, points: &Vec, indices: &Vec) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 117 | pub fn update(&mut self, points: &Vec, indices: &[i32]) { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] help: change `indices.clone()` to [INFO] [stderr] | [INFO] [stderr] 119 | self.indices = indices.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/gui.rs:161:44 [INFO] [stderr] | [INFO] [stderr] 161 | fn init_glfw(width: u32, height: u32) -> ( [INFO] [stderr] | ____________________________________________^ [INFO] [stderr] 162 | | Box, [INFO] [stderr] 163 | | Box, [INFO] [stderr] 164 | | Box>, [INFO] [stderr] 165 | | ) { [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/gui.rs:227:27 [INFO] [stderr] | [INFO] [stderr] 227 | let mut success = gl::FALSE as GLint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::FALSE)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/gui.rs:233:23 [INFO] [stderr] | [INFO] [stderr] 233 | if success != gl::TRUE as GLint { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/gui.rs:265:25 [INFO] [stderr] | [INFO] [stderr] 265 | let mut success = gl::FALSE as GLint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::FALSE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/gui.rs:270:21 [INFO] [stderr] | [INFO] [stderr] 270 | if success != gl::TRUE as GLint { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `self.width` [INFO] [stderr] --> src/gui.rs:433:36 [INFO] [stderr] | [INFO] [stderr] 433 | let slope_x = (1.0 - (-1.0)) / (self.width - 0) as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `self.height` [INFO] [stderr] --> src/gui.rs:434:36 [INFO] [stderr] | [INFO] [stderr] 434 | let slope_y = (1.0 - (-1.0)) / (self.height - 0) as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `8` [INFO] [stderr] --> src/models/piece.rs:54:37 [INFO] [stderr] | [INFO] [stderr] 54 | let slope = (1 - (-1)) as f32 / (8 - 0) as f32; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `RETRY_ATTEMPTS_HTTP` [INFO] [stderr] --> src/connection.rs:23:1 [INFO] [stderr] | [INFO] [stderr] 23 | const RETRY_ATTEMPTS_HTTP: i32 = 5; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `zoom` [INFO] [stderr] --> src/camera.rs:22:3 [INFO] [stderr] | [INFO] [stderr] 22 | zoom: f32, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/board.rs:101:5 [INFO] [stderr] | [INFO] [stderr] 101 | write!(f, "{}", color); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/board.rs:419:16 [INFO] [stderr] | [INFO] [stderr] 419 | return (dx == 0 && dy != 0) || (dx != 0 && dy == 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `dx == 0 && dy != 0 || dx != 0 && dy == 0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/board.rs:433:16 [INFO] [stderr] | [INFO] [stderr] 433 | return (dx == dy && dx != 0) || (dx == 0 && dy != 0) || (dx == 0 && dy != 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 433 | return dx == 0 && dy != 0 || dx == dy && dx != 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] 433 | return !(dx == 0 && dy == 0 || dx != dy && dx != 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] 433 | return (dx != 0 || dy != 0) && (dx == dy || dx == 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/board.rs:400:3 [INFO] [stderr] | [INFO] [stderr] 400 | / fn validate_move(&self, from: (usize, usize), to: (usize, usize), piece: &GamePiece) -> bool { [INFO] [stderr] 401 | | [INFO] [stderr] 402 | | let (dx, dy) = Self::d(from, to); [INFO] [stderr] 403 | | [INFO] [stderr] ... | [INFO] [stderr] 449 | | } [INFO] [stderr] 450 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/game.rs:157:9 [INFO] [stderr] | [INFO] [stderr] 157 | / match board_receiver.recv_timeout(Duration::from_millis(100)) { [INFO] [stderr] 158 | | Ok(new_board) => { [INFO] [stderr] 159 | | // Update board with new or old board [INFO] [stderr] 160 | | window.update_board(new_board.clone()); [INFO] [stderr] 161 | | } [INFO] [stderr] 162 | | Err(_) => (), [INFO] [stderr] 163 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 157 | if let Ok(new_board) = board_receiver.recv_timeout(Duration::from_millis(100)) { [INFO] [stderr] 158 | // Update board with new or old board [INFO] [stderr] 159 | window.update_board(new_board.clone()); [INFO] [stderr] 160 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/game.rs:166:9 [INFO] [stderr] | [INFO] [stderr] 166 | / match close_receiver.recv_timeout(Duration::from_millis(10)) { [INFO] [stderr] 167 | | Ok(close) => { [INFO] [stderr] 168 | | if close { [INFO] [stderr] 169 | | window.close(); [INFO] [stderr] ... | [INFO] [stderr] 172 | | Err(_) => (), [INFO] [stderr] 173 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 166 | if let Ok(close) = close_receiver.recv_timeout(Duration::from_millis(10)) { [INFO] [stderr] 167 | if close { [INFO] [stderr] 168 | window.close(); [INFO] [stderr] 169 | } [INFO] [stderr] 170 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/game.rs:228:9 [INFO] [stderr] | [INFO] [stderr] 228 | / match gui_receiver.recv_timeout(Duration::from_millis(100)) { [INFO] [stderr] 229 | | Ok(gui_input) => { [INFO] [stderr] 230 | | received_input = true; [INFO] [stderr] 231 | | input = gui_input; [INFO] [stderr] 232 | | }, [INFO] [stderr] 233 | | Err(_) => (), // Received nothing yet [INFO] [stderr] 234 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 228 | if let Ok(gui_input) = gui_receiver.recv_timeout(Duration::from_millis(100)) { [INFO] [stderr] 229 | received_input = true; [INFO] [stderr] 230 | input = gui_input; [INFO] [stderr] 231 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/game.rs:263:9 [INFO] [stderr] | [INFO] [stderr] 263 | board_sender.send(self.board.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/game.rs:364:5 [INFO] [stderr] | [INFO] [stderr] 364 | let _ = game.save("test.json"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/game.rs:368:5 [INFO] [stderr] | [INFO] [stderr] 368 | let _ = game2.load("test.json"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/client.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | / let connection: Box; [INFO] [stderr] 78 | | [INFO] [stderr] 79 | | // TCP [INFO] [stderr] 80 | | if addr.starts_with("tcp://") { [INFO] [stderr] ... | [INFO] [stderr] 91 | | connection = Box::new(EchoConnection::new()); [INFO] [stderr] 92 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let connection = if addr.starts_with("tcp://") { ..; Box::new(listener) } else { Box::new(EchoConnection::new()) };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/client.rs:211:5 [INFO] [stderr] | [INFO] [stderr] 211 | / match client.handle_reply(&Message::MakeMove.to_string()) { [INFO] [stderr] 212 | | Ok(_) => panic!("Not supposed to accept this message"), [INFO] [stderr] 213 | | Err(_) => (), [INFO] [stderr] 214 | | }; [INFO] [stderr] | |_____^ help: try this: `if let Ok(_) = client.handle_reply(&Message::MakeMove.to_string()) { panic!("Not supposed to accept this message") }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/client.rs:229:5 [INFO] [stderr] | [INFO] [stderr] 229 | / match client.handle_reply(&format!("{} random_text", Message::Bye)) { [INFO] [stderr] 230 | | Ok(msg) => panic!("Not supposed to accept this message: {}", msg.0), [INFO] [stderr] 231 | | Err(_) => (), [INFO] [stderr] 232 | | }; [INFO] [stderr] | |_____^ help: try this: `if let Ok(msg) = client.handle_reply(&format!("{} random_text", Message::Bye)) { panic!("Not supposed to accept this message: {}", msg.0) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `connection::EchoConnection` [INFO] [stderr] --> src/connection.rs:43:3 [INFO] [stderr] | [INFO] [stderr] 43 | / pub fn new() -> Self { [INFO] [stderr] 44 | | EchoConnection{} [INFO] [stderr] 45 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 37 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: The function/method `write` doesn't need a mutable reference [INFO] [stderr] --> src/connection.rs:136:29 [INFO] [stderr] | [INFO] [stderr] 136 | match self.stream.write(&mut raw_data) { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `connection::SelfConnection` [INFO] [stderr] --> src/connection.rs:190:3 [INFO] [stderr] | [INFO] [stderr] 190 | / pub fn new() -> SelfConnection { [INFO] [stderr] 191 | | SelfConnection{} [INFO] [stderr] 192 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 185 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/connection.rs:331:5 [INFO] [stderr] | [INFO] [stderr] 331 | self.client.delete(&format!("{}/clients/{}", self.endpoint, self.name)).send(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/graphic_object.rs:117:36 [INFO] [stderr] | [INFO] [stderr] 117 | pub fn update(&mut self, points: &Vec, indices: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 117 | pub fn update(&mut self, points: &[Vertice], indices: &Vec) { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] help: change `points.clone()` to [INFO] [stderr] | [INFO] [stderr] 118 | self.points = points.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/graphic_object.rs:117:60 [INFO] [stderr] | [INFO] [stderr] 117 | pub fn update(&mut self, points: &Vec, indices: &Vec) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 117 | pub fn update(&mut self, points: &Vec, indices: &[i32]) { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] help: change `indices.clone()` to [INFO] [stderr] | [INFO] [stderr] 119 | self.indices = indices.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/gui.rs:161:44 [INFO] [stderr] | [INFO] [stderr] 161 | fn init_glfw(width: u32, height: u32) -> ( [INFO] [stderr] | ____________________________________________^ [INFO] [stderr] 162 | | Box, [INFO] [stderr] 163 | | Box, [INFO] [stderr] 164 | | Box>, [INFO] [stderr] 165 | | ) { [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/gui.rs:227:27 [INFO] [stderr] | [INFO] [stderr] 227 | let mut success = gl::FALSE as GLint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::FALSE)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/gui.rs:233:23 [INFO] [stderr] | [INFO] [stderr] 233 | if success != gl::TRUE as GLint { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/gui.rs:265:25 [INFO] [stderr] | [INFO] [stderr] 265 | let mut success = gl::FALSE as GLint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::FALSE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/gui.rs:270:21 [INFO] [stderr] | [INFO] [stderr] 270 | if success != gl::TRUE as GLint { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `self.width` [INFO] [stderr] --> src/gui.rs:433:36 [INFO] [stderr] | [INFO] [stderr] 433 | let slope_x = (1.0 - (-1.0)) / (self.width - 0) as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `self.height` [INFO] [stderr] --> src/gui.rs:434:36 [INFO] [stderr] | [INFO] [stderr] 434 | let slope_y = (1.0 - (-1.0)) / (self.height - 0) as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/gui.rs:484:5 [INFO] [stderr] | [INFO] [stderr] 484 | assert_eq!(x, 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/gui.rs:484:5 [INFO] [stderr] | [INFO] [stderr] 484 | assert_eq!(x, 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/gui.rs:485:5 [INFO] [stderr] | [INFO] [stderr] 485 | assert_eq!(y, 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/gui.rs:485:5 [INFO] [stderr] | [INFO] [stderr] 485 | assert_eq!(y, 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `8` [INFO] [stderr] --> src/models/piece.rs:54:37 [INFO] [stderr] | [INFO] [stderr] 54 | let slope = (1 - (-1)) as f32 / (8 - 0) as f32; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust_chess`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "79d2156a2f9f6a58b8f3d3ef0f2143706845c48424c612d46638ed01a6262e3c"` [INFO] running `"docker" "rm" "-f" "79d2156a2f9f6a58b8f3d3ef0f2143706845c48424c612d46638ed01a6262e3c"` [INFO] [stdout] 79d2156a2f9f6a58b8f3d3ef0f2143706845c48424c612d46638ed01a6262e3c