[INFO] updating cached repository letmutx/dex-parser
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/letmutx/dex-parser
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/letmutx/dex-parser" "work/ex/clippy-test-run/sources/stable/gh/letmutx/dex-parser"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/letmutx/dex-parser'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/letmutx/dex-parser" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/letmutx/dex-parser"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/letmutx/dex-parser'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] c5a28b908966216c6e48249c8f353532ffa0e0dd
[INFO] sha for GitHub repo letmutx/dex-parser: c5a28b908966216c6e48249c8f353532ffa0e0dd
[INFO] validating manifest of letmutx/dex-parser on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of letmutx/dex-parser on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing letmutx/dex-parser
[INFO] finished frobbing letmutx/dex-parser
[INFO] frobbed toml for letmutx/dex-parser written to work/ex/clippy-test-run/sources/stable/gh/letmutx/dex-parser/Cargo.toml
[INFO] started frobbing letmutx/dex-parser
[INFO] finished frobbing letmutx/dex-parser
[INFO] frobbed toml for letmutx/dex-parser written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/letmutx/dex-parser/Cargo.toml
[INFO] crate letmutx/dex-parser has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting letmutx/dex-parser against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/letmutx/dex-parser:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 3358dcb25352e353299b8fdff9a3f1cc705e29704382b78fec8936ee1edf3fe1
[INFO] running `"docker" "start" "-a" "3358dcb25352e353299b8fdff9a3f1cc705e29704382b78fec8936ee1edf3fe1"`
[INFO] [stderr]     Checking scroll v0.9.0
[INFO] [stderr]    Compiling scroll_derive v0.9.2
[INFO] [stderr]     Checking dex-parser v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/types.rs:358:17
[INFO] [stderr]     |
[INFO] [stderr] 358 |                 method_handle_type: method_handle_type,
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `method_handle_type`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/dex.rs:76:21
[INFO] [stderr]    |
[INFO] [stderr] 76 |                     endian: endian,
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^ help: replace it with: `endian`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/dex.rs:351:13
[INFO] [stderr]     |
[INFO] [stderr] 351 |             header: header,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `header`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/dex.rs:352:13
[INFO] [stderr]     |
[INFO] [stderr] 352 |             strings: strings,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `strings`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/dex.rs:353:13
[INFO] [stderr]     |
[INFO] [stderr] 353 |             types: types,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `types`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/dex.rs:354:13
[INFO] [stderr]     |
[INFO] [stderr] 354 |             protos: protos,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `protos`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/dex.rs:355:13
[INFO] [stderr]     |
[INFO] [stderr] 355 |             fields: fields,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `fields`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/dex.rs:356:13
[INFO] [stderr]     |
[INFO] [stderr] 356 |             methods: methods,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `methods`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/dex.rs:357:13
[INFO] [stderr]     |
[INFO] [stderr] 357 |             classes: classes,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `classes`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/items.rs:267:17
[INFO] [stderr]     |
[INFO] [stderr] 267 |                 annotation_offs: annotation_offs,
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `annotation_offs`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/types.rs:358:17
[INFO] [stderr]     |
[INFO] [stderr] 358 |                 method_handle_type: method_handle_type,
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `method_handle_type`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/dex.rs:76:21
[INFO] [stderr]    |
[INFO] [stderr] 76 |                     endian: endian,
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^ help: replace it with: `endian`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/dex.rs:351:13
[INFO] [stderr]     |
[INFO] [stderr] 351 |             header: header,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `header`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/dex.rs:352:13
[INFO] [stderr]     |
[INFO] [stderr] 352 |             strings: strings,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `strings`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/dex.rs:353:13
[INFO] [stderr]     |
[INFO] [stderr] 353 |             types: types,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `types`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/dex.rs:354:13
[INFO] [stderr]     |
[INFO] [stderr] 354 |             protos: protos,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `protos`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/dex.rs:355:13
[INFO] [stderr]     |
[INFO] [stderr] 355 |             fields: fields,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `fields`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/dex.rs:356:13
[INFO] [stderr]     |
[INFO] [stderr] 356 |             methods: methods,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `methods`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/dex.rs:357:13
[INFO] [stderr]     |
[INFO] [stderr] 357 |             classes: classes,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `classes`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/items.rs:267:17
[INFO] [stderr]     |
[INFO] [stderr] 267 |                 annotation_offs: annotation_offs,
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `annotation_offs`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/encoded.rs:154:26
[INFO] [stderr]     |
[INFO] [stderr] 154 |         let value_type = 0b00011111 & header;
[INFO] [stderr]     |                          ^^^^^^^^^^ help: consider: `0b0001_1111`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/lib.rs:31:28
[INFO] [stderr]    |
[INFO] [stderr] 31 | pub const NO_INDEX: uint = 0xffffffff;
[INFO] [stderr]    |                            ^^^^^^^^^^ help: consider: `0xffff_ffff`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/encoded.rs:154:26
[INFO] [stderr]     |
[INFO] [stderr] 154 |         let value_type = 0b00011111 & header;
[INFO] [stderr]     |                          ^^^^^^^^^^ help: consider: `0b0001_1111`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/lib.rs:31:28
[INFO] [stderr]    |
[INFO] [stderr] 31 | pub const NO_INDEX: uint = 0xffffffff;
[INFO] [stderr]    |                            ^^^^^^^^^^ help: consider: `0xffff_ffff`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/types.rs:97:45
[INFO] [stderr]    |
[INFO] [stderr] 97 |     pub fn from(typ: &Rc<JString>, strings: &Vec<Rc<JString>>) -> error::Result<Self> {
[INFO] [stderr]    |                                             ^^^^^^^^^^^^^^^^^ help: change this to: `&[Rc<JString>]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/dex.rs:26:5
[INFO] [stderr]     |
[INFO] [stderr] 26  | /     pub fn parse<'a>(source: &'a [u8]) -> Result<Self> {
[INFO] [stderr] 27  | |         let endian_tag: &[u8] = &source[40..44];
[INFO] [stderr] 28  | |         let endian = match (endian_tag[0], endian_tag[1], endian_tag[2], endian_tag[3]) {
[INFO] [stderr] 29  | |             (0x12, 0x34, 0x56, 0x78) => scroll::BE,
[INFO] [stderr] ...   |
[INFO] [stderr] 360 | |         Ok(dex)
[INFO] [stderr] 361 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 30
[INFO] [stderr]    --> src/dex.rs:26:5
[INFO] [stderr]     |
[INFO] [stderr] 26  | /     pub fn parse<'a>(source: &'a [u8]) -> Result<Self> {
[INFO] [stderr] 27  | |         let endian_tag: &[u8] = &source[40..44];
[INFO] [stderr] 28  | |         let endian = match (endian_tag[0], endian_tag[1], endian_tag[2], endian_tag[3]) {
[INFO] [stderr] 29  | |             (0x12, 0x34, 0x56, 0x78) => scroll::BE,
[INFO] [stderr] ...   |
[INFO] [stderr] 360 | |         Ok(dex)
[INFO] [stderr] 361 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/types.rs:97:45
[INFO] [stderr]    |
[INFO] [stderr] 97 |     pub fn from(typ: &Rc<JString>, strings: &Vec<Rc<JString>>) -> error::Result<Self> {
[INFO] [stderr]    |                                             ^^^^^^^^^^^^^^^^^ help: change this to: `&[Rc<JString>]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 32
[INFO] [stderr]    --> src/encoded.rs:147:5
[INFO] [stderr]     |
[INFO] [stderr] 147 | /     fn try_from_ctx(
[INFO] [stderr] 148 | |         source: &'a [u8],
[INFO] [stderr] 149 | |         ctx: EncodedValueCtx<'b>,
[INFO] [stderr] 150 | |     ) -> Result<(Self, Self::Size), Self::Error> {
[INFO] [stderr] ...   |
[INFO] [stderr] 322 | |         Ok((value, size_read))
[INFO] [stderr] 323 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/encoded.rs:165:42
[INFO] [stderr]     |
[INFO] [stderr] 165 |                 for (i, value) in source[1..1 + value_arg].iter().enumerate() {
[INFO] [stderr]     |                                          ^^^^^^^^^^^^^^^^ help: use: `1..=value_arg`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/encoded.rs:174:42
[INFO] [stderr]     |
[INFO] [stderr] 174 |                 for (i, value) in source[1..1 + value_arg].iter().enumerate() {
[INFO] [stderr]     |                                          ^^^^^^^^^^^^^^^^ help: use: `1..=value_arg`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/encoded.rs:183:42
[INFO] [stderr]     |
[INFO] [stderr] 183 |                 for (i, value) in source[1..1 + value_arg].iter().enumerate() {
[INFO] [stderr]     |                                          ^^^^^^^^^^^^^^^^ help: use: `1..=value_arg`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/encoded.rs:192:42
[INFO] [stderr]     |
[INFO] [stderr] 192 |                 for (i, value) in source[1..1 + value_arg].iter().enumerate() {
[INFO] [stderr]     |                                          ^^^^^^^^^^^^^^^^ help: use: `1..=value_arg`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/encoded.rs:201:42
[INFO] [stderr]     |
[INFO] [stderr] 201 |                 for (i, value) in source[1..1 + value_arg].iter().enumerate() {
[INFO] [stderr]     |                                          ^^^^^^^^^^^^^^^^ help: use: `1..=value_arg`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/encoded.rs:210:42
[INFO] [stderr]     |
[INFO] [stderr] 210 |                 for (i, value) in source[1..1 + value_arg].iter().enumerate() {
[INFO] [stderr]     |                                          ^^^^^^^^^^^^^^^^ help: use: `1..=value_arg`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/encoded.rs:219:42
[INFO] [stderr]     |
[INFO] [stderr] 219 |                 for (i, value) in source[1..1 + value_arg].iter().enumerate() {
[INFO] [stderr]     |                                          ^^^^^^^^^^^^^^^^ help: use: `1..=value_arg`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/encoded.rs:230:46
[INFO] [stderr]     |
[INFO] [stderr] 230 |                     for (i, value) in source[1..1 + value_arg].iter().enumerate() {
[INFO] [stderr]     |                                              ^^^^^^^^^^^^^^^^ help: use: `1..=value_arg`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/encoded.rs:246:42
[INFO] [stderr]     |
[INFO] [stderr] 246 |                 for (i, value) in source[1..1 + value_arg].iter().enumerate() {
[INFO] [stderr]     |                                          ^^^^^^^^^^^^^^^^ help: use: `1..=value_arg`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/encoded.rs:256:42
[INFO] [stderr]     |
[INFO] [stderr] 256 |                 for (i, value) in source[1..1 + value_arg].iter().enumerate() {
[INFO] [stderr]     |                                          ^^^^^^^^^^^^^^^^ help: use: `1..=value_arg`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/encoded.rs:266:42
[INFO] [stderr]     |
[INFO] [stderr] 266 |                 for (i, value) in source[1..1 + value_arg].iter().enumerate() {
[INFO] [stderr]     |                                          ^^^^^^^^^^^^^^^^ help: use: `1..=value_arg`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/encoded.rs:276:42
[INFO] [stderr]     |
[INFO] [stderr] 276 |                 for (i, value) in source[1..1 + value_arg].iter().enumerate() {
[INFO] [stderr]     |                                          ^^^^^^^^^^^^^^^^ help: use: `1..=value_arg`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/encoded.rs:286:42
[INFO] [stderr]     |
[INFO] [stderr] 286 |                 for (i, value) in source[1..1 + value_arg].iter().enumerate() {
[INFO] [stderr]     |                                          ^^^^^^^^^^^^^^^^ help: use: `1..=value_arg`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/dex.rs:26:5
[INFO] [stderr]     |
[INFO] [stderr] 26  | /     pub fn parse<'a>(source: &'a [u8]) -> Result<Self> {
[INFO] [stderr] 27  | |         let endian_tag: &[u8] = &source[40..44];
[INFO] [stderr] 28  | |         let endian = match (endian_tag[0], endian_tag[1], endian_tag[2], endian_tag[3]) {
[INFO] [stderr] 29  | |             (0x12, 0x34, 0x56, 0x78) => scroll::BE,
[INFO] [stderr] ...   |
[INFO] [stderr] 360 | |         Ok(dex)
[INFO] [stderr] 361 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 30
[INFO] [stderr]    --> src/dex.rs:26:5
[INFO] [stderr]     |
[INFO] [stderr] 26  | /     pub fn parse<'a>(source: &'a [u8]) -> Result<Self> {
[INFO] [stderr] 27  | |         let endian_tag: &[u8] = &source[40..44];
[INFO] [stderr] 28  | |         let endian = match (endian_tag[0], endian_tag[1], endian_tag[2], endian_tag[3]) {
[INFO] [stderr] 29  | |             (0x12, 0x34, 0x56, 0x78) => scroll::BE,
[INFO] [stderr] ...   |
[INFO] [stderr] 360 | |         Ok(dex)
[INFO] [stderr] 361 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 32
[INFO] [stderr]    --> src/encoded.rs:147:5
[INFO] [stderr]     |
[INFO] [stderr] 147 | /     fn try_from_ctx(
[INFO] [stderr] 148 | |         source: &'a [u8],
[INFO] [stderr] 149 | |         ctx: EncodedValueCtx<'b>,
[INFO] [stderr] 150 | |     ) -> Result<(Self, Self::Size), Self::Error> {
[INFO] [stderr] ...   |
[INFO] [stderr] 322 | |         Ok((value, size_read))
[INFO] [stderr] 323 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/encoded.rs:165:42
[INFO] [stderr]     |
[INFO] [stderr] 165 |                 for (i, value) in source[1..1 + value_arg].iter().enumerate() {
[INFO] [stderr]     |                                          ^^^^^^^^^^^^^^^^ help: use: `1..=value_arg`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/encoded.rs:174:42
[INFO] [stderr]     |
[INFO] [stderr] 174 |                 for (i, value) in source[1..1 + value_arg].iter().enumerate() {
[INFO] [stderr]     |                                          ^^^^^^^^^^^^^^^^ help: use: `1..=value_arg`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/encoded.rs:183:42
[INFO] [stderr]     |
[INFO] [stderr] 183 |                 for (i, value) in source[1..1 + value_arg].iter().enumerate() {
[INFO] [stderr]     |                                          ^^^^^^^^^^^^^^^^ help: use: `1..=value_arg`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/encoded.rs:192:42
[INFO] [stderr]     |
[INFO] [stderr] 192 |                 for (i, value) in source[1..1 + value_arg].iter().enumerate() {
[INFO] [stderr]     |                                          ^^^^^^^^^^^^^^^^ help: use: `1..=value_arg`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/encoded.rs:201:42
[INFO] [stderr]     |
[INFO] [stderr] 201 |                 for (i, value) in source[1..1 + value_arg].iter().enumerate() {
[INFO] [stderr]     |                                          ^^^^^^^^^^^^^^^^ help: use: `1..=value_arg`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/encoded.rs:210:42
[INFO] [stderr]     |
[INFO] [stderr] 210 |                 for (i, value) in source[1..1 + value_arg].iter().enumerate() {
[INFO] [stderr]     |                                          ^^^^^^^^^^^^^^^^ help: use: `1..=value_arg`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/encoded.rs:219:42
[INFO] [stderr]     |
[INFO] [stderr] 219 |                 for (i, value) in source[1..1 + value_arg].iter().enumerate() {
[INFO] [stderr]     |                                          ^^^^^^^^^^^^^^^^ help: use: `1..=value_arg`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/encoded.rs:230:46
[INFO] [stderr]     |
[INFO] [stderr] 230 |                     for (i, value) in source[1..1 + value_arg].iter().enumerate() {
[INFO] [stderr]     |                                              ^^^^^^^^^^^^^^^^ help: use: `1..=value_arg`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/encoded.rs:246:42
[INFO] [stderr]     |
[INFO] [stderr] 246 |                 for (i, value) in source[1..1 + value_arg].iter().enumerate() {
[INFO] [stderr]     |                                          ^^^^^^^^^^^^^^^^ help: use: `1..=value_arg`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/encoded.rs:256:42
[INFO] [stderr]     |
[INFO] [stderr] 256 |                 for (i, value) in source[1..1 + value_arg].iter().enumerate() {
[INFO] [stderr]     |                                          ^^^^^^^^^^^^^^^^ help: use: `1..=value_arg`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/encoded.rs:266:42
[INFO] [stderr]     |
[INFO] [stderr] 266 |                 for (i, value) in source[1..1 + value_arg].iter().enumerate() {
[INFO] [stderr]     |                                          ^^^^^^^^^^^^^^^^ help: use: `1..=value_arg`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/encoded.rs:276:42
[INFO] [stderr]     |
[INFO] [stderr] 276 |                 for (i, value) in source[1..1 + value_arg].iter().enumerate() {
[INFO] [stderr]     |                                          ^^^^^^^^^^^^^^^^ help: use: `1..=value_arg`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/encoded.rs:286:42
[INFO] [stderr]     |
[INFO] [stderr] 286 |                 for (i, value) in source[1..1 + value_arg].iter().enumerate() {
[INFO] [stderr]     |                                          ^^^^^^^^^^^^^^^^ help: use: `1..=value_arg`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 5.23s
[INFO] running `"docker" "inspect" "3358dcb25352e353299b8fdff9a3f1cc705e29704382b78fec8936ee1edf3fe1"`
[INFO] running `"docker" "rm" "-f" "3358dcb25352e353299b8fdff9a3f1cc705e29704382b78fec8936ee1edf3fe1"`
[INFO] [stdout] 3358dcb25352e353299b8fdff9a3f1cc705e29704382b78fec8936ee1edf3fe1