[INFO] updating cached repository letmutx/code-executor [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/letmutx/code-executor [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/letmutx/code-executor" "work/ex/clippy-test-run/sources/stable/gh/letmutx/code-executor"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/letmutx/code-executor'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/letmutx/code-executor" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/letmutx/code-executor"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/letmutx/code-executor'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7f543faf3f46ad92f67c559e31f00e3920cba3f7 [INFO] sha for GitHub repo letmutx/code-executor: 7f543faf3f46ad92f67c559e31f00e3920cba3f7 [INFO] validating manifest of letmutx/code-executor on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of letmutx/code-executor on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing letmutx/code-executor [INFO] finished frobbing letmutx/code-executor [INFO] frobbed toml for letmutx/code-executor written to work/ex/clippy-test-run/sources/stable/gh/letmutx/code-executor/Cargo.toml [INFO] started frobbing letmutx/code-executor [INFO] finished frobbing letmutx/code-executor [INFO] frobbed toml for letmutx/code-executor written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/letmutx/code-executor/Cargo.toml [INFO] crate letmutx/code-executor has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting letmutx/code-executor against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/letmutx/code-executor:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a02bc9e05319d30ecaf1673156d2f2894a848da0bd722a580b9d794283399d1b [INFO] running `"docker" "start" "-a" "a02bc9e05319d30ecaf1673156d2f2894a848da0bd722a580b9d794283399d1b"` [INFO] [stderr] Checking xattr v0.1.11 [INFO] [stderr] Checking relay v0.1.0 [INFO] [stderr] Checking tokio-io v0.1.4 [INFO] [stderr] Checking mio-uds v0.6.4 [INFO] [stderr] Checking serde_url_params v0.1.0 [INFO] [stderr] Checking tar v0.4.14 [INFO] [stderr] Checking tokio-core v0.1.12 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking tokio-uds v0.1.7 [INFO] [stderr] Checking hyper v0.11.15 [INFO] [stderr] Checking hyperlocal v0.4.1 [INFO] [stderr] Checking code-executor v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/executor/client.rs:29:18 [INFO] [stderr] | [INFO] [stderr] 29 | Docker { client: client } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/executor/image.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | body: body, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/executor/log.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | log_type: log_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `log_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/executor/log.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/executor/mod.rs:266:41 [INFO] [stderr] | [INFO] [stderr] 266 | stdout: stdout, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stdout` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/executor/mod.rs:267:41 [INFO] [stderr] | [INFO] [stderr] 267 | stderr: stderr, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stderr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/executor/client.rs:29:18 [INFO] [stderr] | [INFO] [stderr] 29 | Docker { client: client } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/executor/image.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | body: body, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/executor/log.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | log_type: log_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `log_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/executor/log.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/executor/mod.rs:266:41 [INFO] [stderr] | [INFO] [stderr] 266 | stdout: stdout, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stdout` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/executor/mod.rs:267:41 [INFO] [stderr] | [INFO] [stderr] 267 | stderr: stderr, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stderr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/executor/mod.rs:212:40 [INFO] [stderr] | [INFO] [stderr] 212 | "Memory": 1073741824usize, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `1_073_741_824usize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/executor/mod.rs:213:44 [INFO] [stderr] | [INFO] [stderr] 213 | "MemorySwap": 1073741824usize, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `1_073_741_824usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/executor/mod.rs:214:43 [INFO] [stderr] | [INFO] [stderr] 214 | "DiskQuota": 10737418240usize [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `10_737_418_240usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/executor/mod.rs:212:40 [INFO] [stderr] | [INFO] [stderr] 212 | "Memory": 1073741824usize, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `1_073_741_824usize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/executor/mod.rs:213:44 [INFO] [stderr] | [INFO] [stderr] 213 | "MemorySwap": 1073741824usize, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `1_073_741_824usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/executor/mod.rs:214:43 [INFO] [stderr] | [INFO] [stderr] 214 | "DiskQuota": 10737418240usize [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `10_737_418_240usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/executor/client.rs:37:22 [INFO] [stderr] | [INFO] [stderr] 37 | .map_err(|e| DockerError::HyperError(e)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `DockerError::HyperError` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/executor/client.rs:48:22 [INFO] [stderr] | [INFO] [stderr] 48 | .map_err(|e| DockerError::HyperError(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `DockerError::HyperError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/executor/container.rs:73:12 [INFO] [stderr] | [INFO] [stderr] 73 | if self.body.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.body.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/executor/container.rs:90:26 [INFO] [stderr] | [INFO] [stderr] 90 | .map_err(|e| DockerError::HyperError(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `DockerError::HyperError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/executor/image.rs:90:31 [INFO] [stderr] | [INFO] [stderr] 90 | } else if let Err(_) = next_message { [INFO] [stderr] | ________________________- ^^^^^^ [INFO] [stderr] 91 | | Err(hyper::Error::Incomplete) [INFO] [stderr] 92 | | } else { [INFO] [stderr] 93 | | Ok(Async::Ready(None)) [INFO] [stderr] 94 | | } [INFO] [stderr] | |_________________- help: try this: `if next_message.is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/executor/mod.rs:161:38 [INFO] [stderr] | [INFO] [stderr] 161 | let id = stream [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 162 | | .split(":") [INFO] [stderr] 163 | | .skip(1) [INFO] [stderr] 164 | | .next() [INFO] [stderr] | |_______________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/executor/mod.rs:162:40 [INFO] [stderr] | [INFO] [stderr] 162 | .split(":") [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/executor/client.rs:37:22 [INFO] [stderr] | [INFO] [stderr] 37 | .map_err(|e| DockerError::HyperError(e)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `DockerError::HyperError` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/executor/client.rs:48:22 [INFO] [stderr] | [INFO] [stderr] 48 | .map_err(|e| DockerError::HyperError(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `DockerError::HyperError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/executor/container.rs:73:12 [INFO] [stderr] | [INFO] [stderr] 73 | if self.body.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.body.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/executor/container.rs:90:26 [INFO] [stderr] | [INFO] [stderr] 90 | .map_err(|e| DockerError::HyperError(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `DockerError::HyperError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/executor/image.rs:90:31 [INFO] [stderr] | [INFO] [stderr] 90 | } else if let Err(_) = next_message { [INFO] [stderr] | ________________________- ^^^^^^ [INFO] [stderr] 91 | | Err(hyper::Error::Incomplete) [INFO] [stderr] 92 | | } else { [INFO] [stderr] 93 | | Ok(Async::Ready(None)) [INFO] [stderr] 94 | | } [INFO] [stderr] | |_________________- help: try this: `if next_message.is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/executor/mod.rs:161:38 [INFO] [stderr] | [INFO] [stderr] 161 | let id = stream [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 162 | | .split(":") [INFO] [stderr] 163 | | .skip(1) [INFO] [stderr] 164 | | .next() [INFO] [stderr] | |_______________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/executor/mod.rs:162:40 [INFO] [stderr] | [INFO] [stderr] 162 | .split(":") [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 21.25s [INFO] running `"docker" "inspect" "a02bc9e05319d30ecaf1673156d2f2894a848da0bd722a580b9d794283399d1b"` [INFO] running `"docker" "rm" "-f" "a02bc9e05319d30ecaf1673156d2f2894a848da0bd722a580b9d794283399d1b"` [INFO] [stdout] a02bc9e05319d30ecaf1673156d2f2894a848da0bd722a580b9d794283399d1b