[INFO] updating cached repository letharion/yasg [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/letharion/yasg [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/letharion/yasg" "work/ex/clippy-test-run/sources/stable/gh/letharion/yasg"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/letharion/yasg'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/letharion/yasg" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/letharion/yasg"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/letharion/yasg'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7bb4afa11423ce4ad67fa5db5c425732f908cffe [INFO] sha for GitHub repo letharion/yasg: 7bb4afa11423ce4ad67fa5db5c425732f908cffe [INFO] validating manifest of letharion/yasg on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of letharion/yasg on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing letharion/yasg [INFO] finished frobbing letharion/yasg [INFO] frobbed toml for letharion/yasg written to work/ex/clippy-test-run/sources/stable/gh/letharion/yasg/Cargo.toml [INFO] started frobbing letharion/yasg [INFO] finished frobbing letharion/yasg [INFO] frobbed toml for letharion/yasg written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/letharion/yasg/Cargo.toml [INFO] crate letharion/yasg has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting letharion/yasg against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/letharion/yasg:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 39a273acf9a0aec40eb7c22614c59ef03d8b0a5f678e70e794c1a9ce249e4e54 [INFO] running `"docker" "start" "-a" "39a273acf9a0aec40eb7c22614c59ef03d8b0a5f678e70e794c1a9ce249e4e54"` [INFO] [stderr] Compiling either v1.1.0 [INFO] [stderr] Checking tokio v0.0.0 [INFO] [stderr] Compiling libz-sys v1.0.13 [INFO] [stderr] Compiling freetype-sys v0.4.0 [INFO] [stderr] Compiling glutin v0.8.0 [INFO] [stderr] Checking piston2d-opengl_graphics v0.43.1 [INFO] [stderr] Compiling itertools v0.5.10 [INFO] [stderr] Compiling derivative v1.0.0 [INFO] [stderr] Checking freetype-rs v0.13.0 [INFO] [stderr] Checking gfx_core v0.7.1 [INFO] [stderr] Checking pistoncore-glutin_window v0.37.0 [INFO] [stderr] Checking gfx v0.16.0 [INFO] [stderr] Checking gfx_text v0.17.0 [INFO] [stderr] Checking yasg v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:219:44 [INFO] [stderr] | [INFO] [stderr] 219 | let elapsed = (new_now.as_secs() * 1000000000) + new_now.subsec_nanos() as u64; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_000_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:219:44 [INFO] [stderr] | [INFO] [stderr] 219 | let elapsed = (new_now.as_secs() * 1000000000) + new_now.subsec_nanos() as u64; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_000_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused variable: `elapsed` [INFO] [stderr] --> src/main.rs:219:13 [INFO] [stderr] | [INFO] [stderr] 219 | let elapsed = (new_now.as_secs() * 1000000000) + new_now.subsec_nanos() as u64; [INFO] [stderr] | ^^^^^^^ help: consider using `_elapsed` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | let ref mut planets = self.planets; [INFO] [stderr] | ----^^^^^^^^^^^^^^^---------------- help: try: `let planets = &mut self.planets;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | let ref mut projectiles = self.projectiles; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^^-------------------- help: try: `let projectiles = &mut self.projectiles;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:70:32 [INFO] [stderr] | [INFO] [stderr] 70 | fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:124:37 [INFO] [stderr] | [INFO] [stderr] 124 | self.projectiles.retain(|p| p.collision == false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!p.collision` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: unused variable: `elapsed` [INFO] [stderr] --> src/main.rs:219:13 [INFO] [stderr] | [INFO] [stderr] 219 | let elapsed = (new_now.as_secs() * 1000000000) + new_now.subsec_nanos() as u64; [INFO] [stderr] | ^^^^^^^ help: consider using `_elapsed` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:212:22 [INFO] [stderr] | [INFO] [stderr] 212 | f += 360.0 / (n - 1) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(n - 1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:219:58 [INFO] [stderr] | [INFO] [stderr] 219 | let elapsed = (new_now.as_secs() * 1000000000) + new_now.subsec_nanos() as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(new_now.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | let ref mut planets = self.planets; [INFO] [stderr] | ----^^^^^^^^^^^^^^^---------------- help: try: `let planets = &mut self.planets;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | let ref mut projectiles = self.projectiles; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^^-------------------- help: try: `let projectiles = &mut self.projectiles;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:70:32 [INFO] [stderr] | [INFO] [stderr] 70 | fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:124:37 [INFO] [stderr] | [INFO] [stderr] 124 | self.projectiles.retain(|p| p.collision == false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!p.collision` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:212:22 [INFO] [stderr] | [INFO] [stderr] 212 | f += 360.0 / (n - 1) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(n - 1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:219:58 [INFO] [stderr] | [INFO] [stderr] 219 | let elapsed = (new_now.as_secs() * 1000000000) + new_now.subsec_nanos() as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(new_now.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 42.09s [INFO] running `"docker" "inspect" "39a273acf9a0aec40eb7c22614c59ef03d8b0a5f678e70e794c1a9ce249e4e54"` [INFO] running `"docker" "rm" "-f" "39a273acf9a0aec40eb7c22614c59ef03d8b0a5f678e70e794c1a9ce249e4e54"` [INFO] [stdout] 39a273acf9a0aec40eb7c22614c59ef03d8b0a5f678e70e794c1a9ce249e4e54