[INFO] updating cached repository leshow/sort-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/leshow/sort-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/leshow/sort-rs" "work/ex/clippy-test-run/sources/stable/gh/leshow/sort-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/leshow/sort-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/leshow/sort-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/leshow/sort-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/leshow/sort-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f59c0f36eca9350ec886da80cadfa012347c86be [INFO] sha for GitHub repo leshow/sort-rs: f59c0f36eca9350ec886da80cadfa012347c86be [INFO] validating manifest of leshow/sort-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of leshow/sort-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing leshow/sort-rs [INFO] finished frobbing leshow/sort-rs [INFO] frobbed toml for leshow/sort-rs written to work/ex/clippy-test-run/sources/stable/gh/leshow/sort-rs/Cargo.toml [INFO] started frobbing leshow/sort-rs [INFO] finished frobbing leshow/sort-rs [INFO] frobbed toml for leshow/sort-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/leshow/sort-rs/Cargo.toml [INFO] crate leshow/sort-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting leshow/sort-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/leshow/sort-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a1ef91c6e0659c098a16ae0290617c68ca6d23207a86bf5907f34be6d6a618f4 [INFO] running `"docker" "start" "-a" "a1ef91c6e0659c098a16ae0290617c68ca6d23207a86bf5907f34be6d6a618f4"` [INFO] [stderr] Checking sorting v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:231:21 [INFO] [stderr] | [INFO] [stderr] 231 | let (mut n, mut m, blen) = (0, 0, b.len()); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:231:21 [INFO] [stderr] | [INFO] [stderr] 231 | let (mut n, mut m, blen) = (0, 0, b.len()); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Debug`, `Display` [INFO] [stderr] --> src/main.rs:4:16 [INFO] [stderr] | [INFO] [stderr] 4 | use std::fmt::{Debug, Display}; [INFO] [stderr] | ^^^^^ ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Debug`, `Display` [INFO] [stderr] --> src/main.rs:4:16 [INFO] [stderr] | [INFO] [stderr] 4 | use std::fmt::{Debug, Display}; [INFO] [stderr] | ^^^^^ ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:249:14 [INFO] [stderr] | [INFO] [stderr] 249 | for i in (0..(n / 2) + 1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `(0..=(n / 2))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:249:14 [INFO] [stderr] | [INFO] [stderr] 249 | for i in (0..(n / 2) + 1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `(0..=(n / 2))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.20s [INFO] running `"docker" "inspect" "a1ef91c6e0659c098a16ae0290617c68ca6d23207a86bf5907f34be6d6a618f4"` [INFO] running `"docker" "rm" "-f" "a1ef91c6e0659c098a16ae0290617c68ca6d23207a86bf5907f34be6d6a618f4"` [INFO] [stdout] a1ef91c6e0659c098a16ae0290617c68ca6d23207a86bf5907f34be6d6a618f4