[INFO] updating cached repository lennyferguson/RustRay [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/lennyferguson/RustRay [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/lennyferguson/RustRay" "work/ex/clippy-test-run/sources/stable/gh/lennyferguson/RustRay"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/lennyferguson/RustRay'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/lennyferguson/RustRay" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lennyferguson/RustRay"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lennyferguson/RustRay'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8c5f77cb27158cd779bc5316efe6c974356e77c6 [INFO] sha for GitHub repo lennyferguson/RustRay: 8c5f77cb27158cd779bc5316efe6c974356e77c6 [INFO] validating manifest of lennyferguson/RustRay on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lennyferguson/RustRay on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lennyferguson/RustRay [INFO] finished frobbing lennyferguson/RustRay [INFO] frobbed toml for lennyferguson/RustRay written to work/ex/clippy-test-run/sources/stable/gh/lennyferguson/RustRay/Cargo.toml [INFO] started frobbing lennyferguson/RustRay [INFO] finished frobbing lennyferguson/RustRay [INFO] frobbed toml for lennyferguson/RustRay written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lennyferguson/RustRay/Cargo.toml [INFO] crate lennyferguson/RustRay has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lennyferguson/RustRay against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/lennyferguson/RustRay:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b0fbb2242646da4ce7130de39a7d4f72f29d3f7bee41f164aaeea01e855d7cde [INFO] running `"docker" "start" "-a" "b0fbb2242646da4ce7130de39a7d4f72f29d3f7bee41f164aaeea01e855d7cde"` [INFO] [stderr] Compiling either v1.3.0 [INFO] [stderr] Checking bitflags v1.0.0 [INFO] [stderr] Checking serde v1.0.17 [INFO] [stderr] Compiling serde_json v0.9.10 [INFO] [stderr] Checking rand v0.4.2 [INFO] [stderr] Checking inflate v0.3.3 [INFO] [stderr] Checking stb_truetype v0.2.2 [INFO] [stderr] Compiling gl_generator v0.6.1 [INFO] [stderr] Compiling gl_generator v0.7.0 [INFO] [stderr] Checking num-bigint v0.1.37 [INFO] [stderr] Compiling itertools v0.5.10 [INFO] [stderr] Checking rusttype v0.2.3 [INFO] [stderr] Compiling serde_derive v1.0.17 [INFO] [stderr] Checking num-rational v0.1.36 [INFO] [stderr] Compiling gl v0.6.5 [INFO] [stderr] Compiling glutin v0.10.1 [INFO] [stderr] Compiling derivative v1.0.0 [INFO] [stderr] Compiling target_build_utils v0.3.1 [INFO] [stderr] Compiling gfx_gl v0.4.0 [INFO] [stderr] Checking num v0.1.37 [INFO] [stderr] Checking png v0.11.0 [INFO] [stderr] Checking nalgebra v0.5.1 [INFO] [stderr] Checking piston2d-graphics v0.23.0 [INFO] [stderr] Compiling libloading v0.3.4 [INFO] [stderr] Checking image v0.17.0 [INFO] [stderr] Checking gfx_core v0.7.2 [INFO] [stderr] Checking pistoncore-input v0.20.0 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.9.10 [INFO] [stderr] Checking wayland-client v0.9.10 [INFO] [stderr] Checking wayland-protocols v0.9.10 [INFO] [stderr] Checking wayland-kbd v0.9.1 [INFO] [stderr] Checking pistoncore-window v0.30.0 [INFO] [stderr] Checking pistoncore-event_loop v0.35.0 [INFO] [stderr] Checking piston v0.35.0 [INFO] [stderr] Checking wayland-window v0.8.0 [INFO] [stderr] Checking winit v0.8.3 [INFO] [stderr] Checking pistoncore-glutin_window v0.42.1 [INFO] [stderr] Checking gfx v0.16.3 [INFO] [stderr] Checking gfx_device_gl v0.14.6 [INFO] [stderr] Checking piston-gfx_texture v0.29.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.46.0 [INFO] [stderr] Checking piston_window v0.73.0 [INFO] [stderr] Checking rust_ray v0.5.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:542:13 [INFO] [stderr] | [INFO] [stderr] 542 | let e = self.a.y - self.c.y; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/main.rs:543:13 [INFO] [stderr] | [INFO] [stderr] 543 | let f = ray.dir.y; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/main.rs:544:13 [INFO] [stderr] | [INFO] [stderr] 544 | let g = self.a.z - self.b.z; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/main.rs:545:13 [INFO] [stderr] | [INFO] [stderr] 545 | let h = self.a.z - self.c.z; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 9th binding whose name is just one char [INFO] [stderr] --> src/main.rs:546:13 [INFO] [stderr] | [INFO] [stderr] 546 | let i = ray.dir.z; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 10th binding whose name is just one char [INFO] [stderr] --> src/main.rs:548:13 [INFO] [stderr] | [INFO] [stderr] 548 | let j = self.a.x - ray.src.x; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 11th binding whose name is just one char [INFO] [stderr] --> src/main.rs:549:13 [INFO] [stderr] | [INFO] [stderr] 549 | let k = self.a.y - ray.src.y; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 12th binding whose name is just one char [INFO] [stderr] --> src/main.rs:550:13 [INFO] [stderr] | [INFO] [stderr] 550 | let l = self.a.z - ray.src.z; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 13th binding whose name is just one char [INFO] [stderr] --> src/main.rs:565:17 [INFO] [stderr] | [INFO] [stderr] 565 | let mut t = a * elhk - b * dlgk + j * dheg; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:542:13 [INFO] [stderr] | [INFO] [stderr] 542 | let e = self.a.y - self.c.y; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/main.rs:543:13 [INFO] [stderr] | [INFO] [stderr] 543 | let f = ray.dir.y; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/main.rs:544:13 [INFO] [stderr] | [INFO] [stderr] 544 | let g = self.a.z - self.b.z; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/main.rs:545:13 [INFO] [stderr] | [INFO] [stderr] 545 | let h = self.a.z - self.c.z; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 9th binding whose name is just one char [INFO] [stderr] --> src/main.rs:546:13 [INFO] [stderr] | [INFO] [stderr] 546 | let i = ray.dir.z; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 10th binding whose name is just one char [INFO] [stderr] --> src/main.rs:548:13 [INFO] [stderr] | [INFO] [stderr] 548 | let j = self.a.x - ray.src.x; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 11th binding whose name is just one char [INFO] [stderr] --> src/main.rs:549:13 [INFO] [stderr] | [INFO] [stderr] 549 | let k = self.a.y - ray.src.y; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 12th binding whose name is just one char [INFO] [stderr] --> src/main.rs:550:13 [INFO] [stderr] | [INFO] [stderr] 550 | let l = self.a.z - ray.src.z; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 13th binding whose name is just one char [INFO] [stderr] --> src/main.rs:565:17 [INFO] [stderr] | [INFO] [stderr] 565 | let mut t = a * elhk - b * dlgk + j * dheg; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `rand::Rng` [INFO] [stderr] --> src/main.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | use rand::Rng; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:29:16 [INFO] [stderr] | [INFO] [stderr] 29 | const T1:f32 = 100000.0; [INFO] [stderr] | ^^^^^^^^ help: consider: `100_000.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:87:40 [INFO] [stderr] | [INFO] [stderr] 87 | let brass = Material{amb:Vec3::new(0.329412, 0.223529, 0.027451), reflect:0.0}; [INFO] [stderr] | ^^^^^^^^ help: consider: `0.329_412` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:87:50 [INFO] [stderr] | [INFO] [stderr] 87 | let brass = Material{amb:Vec3::new(0.329412, 0.223529, 0.027451), reflect:0.0}; [INFO] [stderr] | ^^^^^^^^ help: consider: `0.223_529` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:87:60 [INFO] [stderr] | [INFO] [stderr] 87 | let brass = Material{amb:Vec3::new(0.329412, 0.223529, 0.027451), reflect:0.0}; [INFO] [stderr] | ^^^^^^^^ help: consider: `0.027_451` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:638:5 [INFO] [stderr] | [INFO] [stderr] 638 | return if num < 0.0 { 0.0 as f32 } else { num as f32 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `if num < 0.0 { 0.0 as f32 } else { num as f32 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:231:36 [INFO] [stderr] | [INFO] [stderr] 231 | [x as f64, (HALFDIM - y) as f64, 1.0, 1.0], [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:231:46 [INFO] [stderr] | [INFO] [stderr] 231 | [x as f64, (HALFDIM - y) as f64, 1.0, 1.0], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(HALFDIM - y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:269:17 [INFO] [stderr] | [INFO] [stderr] 269 | / match test { [INFO] [stderr] 270 | | Some(t) => { [INFO] [stderr] 271 | | if t < near_t { [INFO] [stderr] 272 | | near_t = t; [INFO] [stderr] ... | [INFO] [stderr] 276 | | None => { } [INFO] [stderr] 277 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 269 | if let Some(t) = test { [INFO] [stderr] 270 | if t < near_t { [INFO] [stderr] 271 | near_t = t; [INFO] [stderr] 272 | near_surf = Some(s); [INFO] [stderr] 273 | } [INFO] [stderr] 274 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:309:13 [INFO] [stderr] | [INFO] [stderr] 309 | / match test { [INFO] [stderr] 310 | | Some(_) => { count += 1; } [INFO] [stderr] 311 | | None => { /* Ignore */ } [INFO] [stderr] 312 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Some(_) = test { count += 1; }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:337:9 [INFO] [stderr] | [INFO] [stderr] 337 | / match test { [INFO] [stderr] 338 | | Some(t) => { [INFO] [stderr] 339 | | if t < current { [INFO] [stderr] 340 | | current = t; [INFO] [stderr] ... | [INFO] [stderr] 344 | | None => { } [INFO] [stderr] 345 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 337 | if let Some(t) = test { [INFO] [stderr] 338 | if t < current { [INFO] [stderr] 339 | current = t; [INFO] [stderr] 340 | near_surf = Some(surf); [INFO] [stderr] 341 | } [INFO] [stderr] 342 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused import: `rand::Rng` [INFO] [stderr] --> src/main.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | use rand::Rng; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:29:16 [INFO] [stderr] | [INFO] [stderr] 29 | const T1:f32 = 100000.0; [INFO] [stderr] | ^^^^^^^^ help: consider: `100_000.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:87:40 [INFO] [stderr] | [INFO] [stderr] 87 | let brass = Material{amb:Vec3::new(0.329412, 0.223529, 0.027451), reflect:0.0}; [INFO] [stderr] | ^^^^^^^^ help: consider: `0.329_412` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:87:50 [INFO] [stderr] | [INFO] [stderr] 87 | let brass = Material{amb:Vec3::new(0.329412, 0.223529, 0.027451), reflect:0.0}; [INFO] [stderr] | ^^^^^^^^ help: consider: `0.223_529` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:87:60 [INFO] [stderr] | [INFO] [stderr] 87 | let brass = Material{amb:Vec3::new(0.329412, 0.223529, 0.027451), reflect:0.0}; [INFO] [stderr] | ^^^^^^^^ help: consider: `0.027_451` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:638:5 [INFO] [stderr] | [INFO] [stderr] 638 | return if num < 0.0 { 0.0 as f32 } else { num as f32 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `if num < 0.0 { 0.0 as f32 } else { num as f32 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:231:36 [INFO] [stderr] | [INFO] [stderr] 231 | [x as f64, (HALFDIM - y) as f64, 1.0, 1.0], [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:231:46 [INFO] [stderr] | [INFO] [stderr] 231 | [x as f64, (HALFDIM - y) as f64, 1.0, 1.0], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(HALFDIM - y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:269:17 [INFO] [stderr] | [INFO] [stderr] 269 | / match test { [INFO] [stderr] 270 | | Some(t) => { [INFO] [stderr] 271 | | if t < near_t { [INFO] [stderr] 272 | | near_t = t; [INFO] [stderr] ... | [INFO] [stderr] 276 | | None => { } [INFO] [stderr] 277 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 269 | if let Some(t) = test { [INFO] [stderr] 270 | if t < near_t { [INFO] [stderr] 271 | near_t = t; [INFO] [stderr] 272 | near_surf = Some(s); [INFO] [stderr] 273 | } [INFO] [stderr] 274 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:309:13 [INFO] [stderr] | [INFO] [stderr] 309 | / match test { [INFO] [stderr] 310 | | Some(_) => { count += 1; } [INFO] [stderr] 311 | | None => { /* Ignore */ } [INFO] [stderr] 312 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Some(_) = test { count += 1; }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:337:9 [INFO] [stderr] | [INFO] [stderr] 337 | / match test { [INFO] [stderr] 338 | | Some(t) => { [INFO] [stderr] 339 | | if t < current { [INFO] [stderr] 340 | | current = t; [INFO] [stderr] ... | [INFO] [stderr] 344 | | None => { } [INFO] [stderr] 345 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 337 | if let Some(t) = test { [INFO] [stderr] 338 | if t < current { [INFO] [stderr] 339 | current = t; [INFO] [stderr] 340 | near_surf = Some(surf); [INFO] [stderr] 341 | } [INFO] [stderr] 342 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 45s [INFO] running `"docker" "inspect" "b0fbb2242646da4ce7130de39a7d4f72f29d3f7bee41f164aaeea01e855d7cde"` [INFO] running `"docker" "rm" "-f" "b0fbb2242646da4ce7130de39a7d4f72f29d3f7bee41f164aaeea01e855d7cde"` [INFO] [stdout] b0fbb2242646da4ce7130de39a7d4f72f29d3f7bee41f164aaeea01e855d7cde