[INFO] updating cached repository lelandbatey/rust_mandelbrot [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/lelandbatey/rust_mandelbrot [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/lelandbatey/rust_mandelbrot" "work/ex/clippy-test-run/sources/stable/gh/lelandbatey/rust_mandelbrot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/lelandbatey/rust_mandelbrot'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/lelandbatey/rust_mandelbrot" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lelandbatey/rust_mandelbrot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lelandbatey/rust_mandelbrot'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b8ab5693b62ee84ead5f4435ffaa056b97081c2d [INFO] sha for GitHub repo lelandbatey/rust_mandelbrot: b8ab5693b62ee84ead5f4435ffaa056b97081c2d [INFO] validating manifest of lelandbatey/rust_mandelbrot on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lelandbatey/rust_mandelbrot on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lelandbatey/rust_mandelbrot [INFO] finished frobbing lelandbatey/rust_mandelbrot [INFO] frobbed toml for lelandbatey/rust_mandelbrot written to work/ex/clippy-test-run/sources/stable/gh/lelandbatey/rust_mandelbrot/Cargo.toml [INFO] started frobbing lelandbatey/rust_mandelbrot [INFO] finished frobbing lelandbatey/rust_mandelbrot [INFO] frobbed toml for lelandbatey/rust_mandelbrot written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lelandbatey/rust_mandelbrot/Cargo.toml [INFO] crate lelandbatey/rust_mandelbrot has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lelandbatey/rust_mandelbrot against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/lelandbatey/rust_mandelbrot:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d25f76bd8ff2892348f7b0559fb8ed3dd199f20d449c39df865cea36ebd3a7ea [INFO] running `"docker" "start" "-a" "d25f76bd8ff2892348f7b0559fb8ed3dd199f20d449c39df865cea36ebd3a7ea"` [INFO] [stderr] Checking mandelbrot v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/main.rs:103:9 [INFO] [stderr] | [INFO] [stderr] 103 | write!(f, "{}\n", pixvals.join("\n")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/main.rs:103:9 [INFO] [stderr] | [INFO] [stderr] 103 | write!(f, "{}\n", pixvals.join("\n")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::cmp` [INFO] [stderr] --> src/main.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | use std::cmp; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | / if x < self.width && x >= 0 { [INFO] [stderr] 72 | | if y < self.height && y >= 0 { [INFO] [stderr] 73 | | if val > self.maximum { [INFO] [stderr] 74 | | self.maximum = val [INFO] [stderr] ... | [INFO] [stderr] 80 | | } [INFO] [stderr] 81 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 71 | if x < self.width && x >= 0 && y < self.height && y >= 0 { [INFO] [stderr] 72 | if val > self.maximum { [INFO] [stderr] 73 | self.maximum = val [INFO] [stderr] 74 | } [INFO] [stderr] 75 | if val < self.minimum { [INFO] [stderr] 76 | self.minimum = val [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::cmp` [INFO] [stderr] --> src/main.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | use std::cmp; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | / if x < self.width && x >= 0 { [INFO] [stderr] 72 | | if y < self.height && y >= 0 { [INFO] [stderr] 73 | | if val > self.maximum { [INFO] [stderr] 74 | | self.maximum = val [INFO] [stderr] ... | [INFO] [stderr] 80 | | } [INFO] [stderr] 81 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 71 | if x < self.width && x >= 0 && y < self.height && y >= 0 { [INFO] [stderr] 72 | if val > self.maximum { [INFO] [stderr] 73 | self.maximum = val [INFO] [stderr] 74 | } [INFO] [stderr] 75 | if val < self.minimum { [INFO] [stderr] 76 | self.minimum = val [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/main.rs:97:27 [INFO] [stderr] | [INFO] [stderr] 97 | .map(|pix| if pix >= &self.minimum { [INFO] [stderr] | ^^^^^^^------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `self.minimum` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:128:17 [INFO] [stderr] | [INFO] [stderr] 128 | let mut x = z.clone(); [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `z` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:209:21 [INFO] [stderr] | [INFO] [stderr] 209 | let ref mut work = thread_work[(ix % thread_count) as usize]; [INFO] [stderr] | ----^^^^^^^^^^^^--------------------------------------------- help: try: `let work = &mut thread_work[(ix % thread_count) as usize];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:233:17 [INFO] [stderr] | [INFO] [stderr] 233 | let ref work = child_tw[idx as usize]; [INFO] [stderr] | ----^^^^^^^^-------------------------- help: try: `let work = &child_tw[idx as usize];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/main.rs:97:27 [INFO] [stderr] | [INFO] [stderr] 97 | .map(|pix| if pix >= &self.minimum { [INFO] [stderr] | ^^^^^^^------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `self.minimum` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:128:17 [INFO] [stderr] | [INFO] [stderr] 128 | let mut x = z.clone(); [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `z` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:209:21 [INFO] [stderr] | [INFO] [stderr] 209 | let ref mut work = thread_work[(ix % thread_count) as usize]; [INFO] [stderr] | ----^^^^^^^^^^^^--------------------------------------------- help: try: `let work = &mut thread_work[(ix % thread_count) as usize];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:233:17 [INFO] [stderr] | [INFO] [stderr] 233 | let ref work = child_tw[idx as usize]; [INFO] [stderr] | ----^^^^^^^^-------------------------- help: try: `let work = &child_tw[idx as usize];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.00s [INFO] running `"docker" "inspect" "d25f76bd8ff2892348f7b0559fb8ed3dd199f20d449c39df865cea36ebd3a7ea"` [INFO] running `"docker" "rm" "-f" "d25f76bd8ff2892348f7b0559fb8ed3dd199f20d449c39df865cea36ebd3a7ea"` [INFO] [stdout] d25f76bd8ff2892348f7b0559fb8ed3dd199f20d449c39df865cea36ebd3a7ea