[INFO] updating cached repository leighwaller/hydrogen [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/leighwaller/hydrogen [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/leighwaller/hydrogen" "work/ex/clippy-test-run/sources/stable/gh/leighwaller/hydrogen"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/leighwaller/hydrogen'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/leighwaller/hydrogen" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/leighwaller/hydrogen"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/leighwaller/hydrogen'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ed63413745211f8ce5f3725f3f26bc13891bacfd [INFO] sha for GitHub repo leighwaller/hydrogen: ed63413745211f8ce5f3725f3f26bc13891bacfd [INFO] validating manifest of leighwaller/hydrogen on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of leighwaller/hydrogen on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing leighwaller/hydrogen [INFO] finished frobbing leighwaller/hydrogen [INFO] frobbed toml for leighwaller/hydrogen written to work/ex/clippy-test-run/sources/stable/gh/leighwaller/hydrogen/Cargo.toml [INFO] started frobbing leighwaller/hydrogen [INFO] finished frobbing leighwaller/hydrogen [INFO] frobbed toml for leighwaller/hydrogen written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/leighwaller/hydrogen/Cargo.toml [INFO] crate leighwaller/hydrogen has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting leighwaller/hydrogen against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/leighwaller/hydrogen:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f1dde12cf53d414421efed29bef88265a4f207d725cda746abd66076157f4071 [INFO] running `"docker" "start" "-a" "f1dde12cf53d414421efed29bef88265a4f207d725cda746abd66076157f4071"` [INFO] [stderr] Checking serde v1.0.38 [INFO] [stderr] Checking regex-syntax v0.5.5 [INFO] [stderr] Checking regex v0.2.10 [INFO] [stderr] Checking env_logger v0.5.7 [INFO] [stderr] Checking uuid v0.6.2 [INFO] [stderr] Checking toml v0.4.6 [INFO] [stderr] Checking hydrogen v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `std` [INFO] [stderr] --> src/model.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::error` [INFO] [stderr] --> src/model.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::error; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fmt` [INFO] [stderr] --> src/model.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std::fmt; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `toml` [INFO] [stderr] --> src/model.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use toml; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/loader.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | return Ok(toml::from_str(&buffer)?); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(toml::from_str(&buffer)?)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std` [INFO] [stderr] --> src/model.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::error` [INFO] [stderr] --> src/model.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::error; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fmt` [INFO] [stderr] --> src/model.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std::fmt; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `toml` [INFO] [stderr] --> src/model.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use toml; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/loader.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | return Ok(toml::from_str(&buffer)?); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(toml::from_str(&buffer)?)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `err` [INFO] [stderr] --> src/loader.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | let err = result.err().unwrap(); [INFO] [stderr] | ^^^ help: consider using `_err` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 20.48s [INFO] running `"docker" "inspect" "f1dde12cf53d414421efed29bef88265a4f207d725cda746abd66076157f4071"` [INFO] running `"docker" "rm" "-f" "f1dde12cf53d414421efed29bef88265a4f207d725cda746abd66076157f4071"` [INFO] [stdout] f1dde12cf53d414421efed29bef88265a4f207d725cda746abd66076157f4071