[INFO] updating cached repository lchsk/scipio [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/lchsk/scipio [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/lchsk/scipio" "work/ex/clippy-test-run/sources/stable/gh/lchsk/scipio"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/lchsk/scipio'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/lchsk/scipio" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lchsk/scipio"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lchsk/scipio'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] dbaa40123b490fa3e2ad13052303e0ab489a2bee [INFO] sha for GitHub repo lchsk/scipio: dbaa40123b490fa3e2ad13052303e0ab489a2bee [INFO] validating manifest of lchsk/scipio on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lchsk/scipio on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lchsk/scipio [INFO] finished frobbing lchsk/scipio [INFO] frobbed toml for lchsk/scipio written to work/ex/clippy-test-run/sources/stable/gh/lchsk/scipio/Cargo.toml [INFO] started frobbing lchsk/scipio [INFO] finished frobbing lchsk/scipio [INFO] frobbed toml for lchsk/scipio written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lchsk/scipio/Cargo.toml [INFO] crate lchsk/scipio has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lchsk/scipio against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/lchsk/scipio:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3ffaf5b0919d5247c54b29dd5fd0c441beb8e1678352a91d7e8e9bc2d6aea043 [INFO] running `"docker" "start" "-a" "3ffaf5b0919d5247c54b29dd5fd0c441beb8e1678352a91d7e8e9bc2d6aea043"` [INFO] [stderr] Compiling pulldown-cmark v0.0.11 [INFO] [stderr] Compiling derive_builder_core v0.2.0 [INFO] [stderr] Checking backtrace-sys v0.1.23 [INFO] [stderr] Checking backtrace v0.3.9 [INFO] [stderr] Checking failure v0.1.1 [INFO] [stderr] Compiling derive_builder v0.5.1 [INFO] [stderr] Checking quick-xml v0.12.1 [INFO] [stderr] Checking rss v1.5.0 [INFO] [stderr] Checking scipio v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/files.rs:228:9 [INFO] [stderr] | [INFO] [stderr] 228 | title: title, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `title` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/files.rs:229:9 [INFO] [stderr] | [INFO] [stderr] 229 | description: description, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `description` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/files.rs:230:9 [INFO] [stderr] | [INFO] [stderr] 230 | keywords: keywords, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `keywords` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/files.rs:231:9 [INFO] [stderr] | [INFO] [stderr] 231 | tags: tags, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/files.rs:233:9 [INFO] [stderr] | [INFO] [stderr] 233 | date: date, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `date` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/files.rs:234:9 [INFO] [stderr] | [INFO] [stderr] 234 | body: body, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/files.rs:235:9 [INFO] [stderr] | [INFO] [stderr] 235 | entry_type: entry_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `entry_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/files.rs:228:9 [INFO] [stderr] | [INFO] [stderr] 228 | title: title, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `title` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/files.rs:229:9 [INFO] [stderr] | [INFO] [stderr] 229 | description: description, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `description` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/files.rs:230:9 [INFO] [stderr] | [INFO] [stderr] 230 | keywords: keywords, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `keywords` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/files.rs:231:9 [INFO] [stderr] | [INFO] [stderr] 231 | tags: tags, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/files.rs:233:9 [INFO] [stderr] | [INFO] [stderr] 233 | date: date, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `date` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/files.rs:234:9 [INFO] [stderr] | [INFO] [stderr] 234 | body: body, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/files.rs:235:9 [INFO] [stderr] | [INFO] [stderr] 235 | entry_type: entry_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `entry_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/files.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | / return InternalFile { [INFO] [stderr] 64 | | stem: "".to_string(), [INFO] [stderr] 65 | | path: "".to_string(), [INFO] [stderr] 66 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 63 | InternalFile { [INFO] [stderr] 64 | stem: "".to_string(), [INFO] [stderr] 65 | path: "".to_string(), [INFO] [stderr] 66 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/files.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | / return InternalFile { [INFO] [stderr] 64 | | stem: "".to_string(), [INFO] [stderr] 65 | | path: "".to_string(), [INFO] [stderr] 66 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 63 | InternalFile { [INFO] [stderr] 64 | stem: "".to_string(), [INFO] [stderr] 65 | path: "".to_string(), [INFO] [stderr] 66 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/files.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | / match path.file_stem() { [INFO] [stderr] 48 | | Some(stem) => match stem.to_str() { [INFO] [stderr] 49 | | Some(stem) => { [INFO] [stderr] 50 | | return InternalFile { [INFO] [stderr] ... | [INFO] [stderr] 60 | | None => {} [INFO] [stderr] 61 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 47 | if let Some(stem) = path.file_stem() { match stem.to_str() { [INFO] [stderr] 48 | Some(stem) => { [INFO] [stderr] 49 | return InternalFile { [INFO] [stderr] 50 | stem: stem.to_string(), [INFO] [stderr] 51 | path: path.to_str().unwrap().to_string(), [INFO] [stderr] 52 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/files.rs:154:50 [INFO] [stderr] | [INFO] [stderr] 154 | let tags_it = caps["tags"].split(","); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/filesystem.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | / match fs::create_dir(dir_name) { [INFO] [stderr] 9 | | Err(e) => { [INFO] [stderr] 10 | | if e.kind() != std::io::ErrorKind::AlreadyExists { [INFO] [stderr] 11 | | println!("Unable to create dir '{}': {:?}", dir_name, e.kind()); [INFO] [stderr] ... | [INFO] [stderr] 14 | | Ok(_) => {} [INFO] [stderr] 15 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 8 | if let Err(e) = fs::create_dir(dir_name) { [INFO] [stderr] 9 | if e.kind() != std::io::ErrorKind::AlreadyExists { [INFO] [stderr] 10 | println!("Unable to create dir '{}': {:?}", dir_name, e.kind()); [INFO] [stderr] 11 | } [INFO] [stderr] 12 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | / let mut of: &str = "index.html"; [INFO] [stderr] 64 | | [INFO] [stderr] 65 | | if output_filename == "" { [INFO] [stderr] 66 | | of = of2; [INFO] [stderr] ... | [INFO] [stderr] 160 | | output = output.replace(&link_tmpl, ""); [INFO] [stderr] 161 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let of = if output_filename == "" { of2 } else { ..; "index.html" };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's keys [INFO] [stderr] --> src/main.rs:52:22 [INFO] [stderr] | [INFO] [stderr] 52 | for (page, _) in files { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 52 | for page in files.keys() { [INFO] [stderr] | ^^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/files.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | / match path.file_stem() { [INFO] [stderr] 48 | | Some(stem) => match stem.to_str() { [INFO] [stderr] 49 | | Some(stem) => { [INFO] [stderr] 50 | | return InternalFile { [INFO] [stderr] ... | [INFO] [stderr] 60 | | None => {} [INFO] [stderr] 61 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 47 | if let Some(stem) = path.file_stem() { match stem.to_str() { [INFO] [stderr] 48 | Some(stem) => { [INFO] [stderr] 49 | return InternalFile { [INFO] [stderr] 50 | stem: stem.to_string(), [INFO] [stderr] 51 | path: path.to_str().unwrap().to_string(), [INFO] [stderr] 52 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/files.rs:154:50 [INFO] [stderr] | [INFO] [stderr] 154 | let tags_it = caps["tags"].split(","); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/filesystem.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | / match fs::create_dir(dir_name) { [INFO] [stderr] 9 | | Err(e) => { [INFO] [stderr] 10 | | if e.kind() != std::io::ErrorKind::AlreadyExists { [INFO] [stderr] 11 | | println!("Unable to create dir '{}': {:?}", dir_name, e.kind()); [INFO] [stderr] ... | [INFO] [stderr] 14 | | Ok(_) => {} [INFO] [stderr] 15 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 8 | if let Err(e) = fs::create_dir(dir_name) { [INFO] [stderr] 9 | if e.kind() != std::io::ErrorKind::AlreadyExists { [INFO] [stderr] 10 | println!("Unable to create dir '{}': {:?}", dir_name, e.kind()); [INFO] [stderr] 11 | } [INFO] [stderr] 12 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | / let mut of: &str = "index.html"; [INFO] [stderr] 64 | | [INFO] [stderr] 65 | | if output_filename == "" { [INFO] [stderr] 66 | | of = of2; [INFO] [stderr] ... | [INFO] [stderr] 160 | | output = output.replace(&link_tmpl, ""); [INFO] [stderr] 161 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let of = if output_filename == "" { of2 } else { ..; "index.html" };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's keys [INFO] [stderr] --> src/main.rs:52:22 [INFO] [stderr] | [INFO] [stderr] 52 | for (page, _) in files { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 52 | for page in files.keys() { [INFO] [stderr] | ^^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.83s [INFO] running `"docker" "inspect" "3ffaf5b0919d5247c54b29dd5fd0c441beb8e1678352a91d7e8e9bc2d6aea043"` [INFO] running `"docker" "rm" "-f" "3ffaf5b0919d5247c54b29dd5fd0c441beb8e1678352a91d7e8e9bc2d6aea043"` [INFO] [stdout] 3ffaf5b0919d5247c54b29dd5fd0c441beb8e1678352a91d7e8e9bc2d6aea043