[INFO] updating cached repository lazear/rust-backend-example [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/lazear/rust-backend-example [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/lazear/rust-backend-example" "work/ex/clippy-test-run/sources/stable/gh/lazear/rust-backend-example"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/lazear/rust-backend-example'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/lazear/rust-backend-example" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lazear/rust-backend-example"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lazear/rust-backend-example'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8cba84b24d497b4a4828eea14a4affd48b9c51bf [INFO] sha for GitHub repo lazear/rust-backend-example: 8cba84b24d497b4a4828eea14a4affd48b9c51bf [INFO] validating manifest of lazear/rust-backend-example on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lazear/rust-backend-example on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lazear/rust-backend-example [INFO] finished frobbing lazear/rust-backend-example [INFO] frobbed toml for lazear/rust-backend-example written to work/ex/clippy-test-run/sources/stable/gh/lazear/rust-backend-example/Cargo.toml [INFO] started frobbing lazear/rust-backend-example [INFO] finished frobbing lazear/rust-backend-example [INFO] frobbed toml for lazear/rust-backend-example written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lazear/rust-backend-example/Cargo.toml [INFO] crate lazear/rust-backend-example has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lazear/rust-backend-example against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/lazear/rust-backend-example:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5e1248245dc178efd01c6f520c3820af91ba11bb903004ef9384ca3e311ede6f [INFO] running `"docker" "start" "-a" "5e1248245dc178efd01c6f520c3820af91ba11bb903004ef9384ca3e311ede6f"` [INFO] [stderr] Checking rust-backend-example v0.1.0 (/opt/crater/workdir) [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/main.rs:9:2 [INFO] [stderr] | [INFO] [stderr] 9 | stream.read(&mut s)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/main.rs:13:25 [INFO] [stderr] | [INFO] [stderr] 13 | while let Some(line) = s.next() { [INFO] [stderr] | ^^^^^^^^ help: try: `for line in s { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:14:31 [INFO] [stderr] | [INFO] [stderr] 14 | let mut header = line.split(":"); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:16:3 [INFO] [stderr] | [INFO] [stderr] 16 | match (key, val) { [INFO] [stderr] | _________^ [INFO] [stderr] 17 | | (Some("X-Forwarded-For"), Some(addr)) => { [INFO] [stderr] 18 | | ip = String::from(addr.trim_left().trim_right()).parse().unwrap_or(ip); [INFO] [stderr] 19 | | }, [INFO] [stderr] 20 | | _ => (), [INFO] [stderr] 21 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 16 | if let (Some("X-Forwarded-For"), Some(addr)) = (key, val) { [INFO] [stderr] 17 | ip = String::from(addr.trim_left().trim_right()).parse().unwrap_or(ip); [INFO] [stderr] 18 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust-backend-example`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/main.rs:9:2 [INFO] [stderr] | [INFO] [stderr] 9 | stream.read(&mut s)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/main.rs:13:25 [INFO] [stderr] | [INFO] [stderr] 13 | while let Some(line) = s.next() { [INFO] [stderr] | ^^^^^^^^ help: try: `for line in s { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:14:31 [INFO] [stderr] | [INFO] [stderr] 14 | let mut header = line.split(":"); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:16:3 [INFO] [stderr] | [INFO] [stderr] 16 | match (key, val) { [INFO] [stderr] | _________^ [INFO] [stderr] 17 | | (Some("X-Forwarded-For"), Some(addr)) => { [INFO] [stderr] 18 | | ip = String::from(addr.trim_left().trim_right()).parse().unwrap_or(ip); [INFO] [stderr] 19 | | }, [INFO] [stderr] 20 | | _ => (), [INFO] [stderr] 21 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 16 | if let (Some("X-Forwarded-For"), Some(addr)) = (key, val) { [INFO] [stderr] 17 | ip = String::from(addr.trim_left().trim_right()).parse().unwrap_or(ip); [INFO] [stderr] 18 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust-backend-example`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "5e1248245dc178efd01c6f520c3820af91ba11bb903004ef9384ca3e311ede6f"` [INFO] running `"docker" "rm" "-f" "5e1248245dc178efd01c6f520c3820af91ba11bb903004ef9384ca3e311ede6f"` [INFO] [stdout] 5e1248245dc178efd01c6f520c3820af91ba11bb903004ef9384ca3e311ede6f