[INFO] updating cached repository lazear/peer-discovery [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/lazear/peer-discovery [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/lazear/peer-discovery" "work/ex/clippy-test-run/sources/stable/gh/lazear/peer-discovery"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/lazear/peer-discovery'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/lazear/peer-discovery" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lazear/peer-discovery"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lazear/peer-discovery'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 19248e3c97ef2d5e39491d86760fc83c8be536ca [INFO] sha for GitHub repo lazear/peer-discovery: 19248e3c97ef2d5e39491d86760fc83c8be536ca [INFO] validating manifest of lazear/peer-discovery on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lazear/peer-discovery on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lazear/peer-discovery [INFO] finished frobbing lazear/peer-discovery [INFO] frobbed toml for lazear/peer-discovery written to work/ex/clippy-test-run/sources/stable/gh/lazear/peer-discovery/Cargo.toml [INFO] started frobbing lazear/peer-discovery [INFO] finished frobbing lazear/peer-discovery [INFO] frobbed toml for lazear/peer-discovery written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lazear/peer-discovery/Cargo.toml [INFO] crate lazear/peer-discovery has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lazear/peer-discovery against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/lazear/peer-discovery:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ed17b80716cf1e404c5cd0375584120537b303bb40aff3c57dd64b9a50377f6b [INFO] running `"docker" "start" "-a" "ed17b80716cf1e404c5cd0375584120537b303bb40aff3c57dd64b9a50377f6b"` [INFO] [stderr] Checking peer-discovery v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/main.rs:29:28 [INFO] [stderr] | [INFO] [stderr] 29 | if let None = peers.insert(remote.into_owned(), ()) { [INFO] [stderr] | _____________________- ^^^^ [INFO] [stderr] 30 | | println!("received ping from new peer {} ({})", String::from_utf8_lossy(&buf), peers.len()); [INFO] [stderr] 31 | | } else { [INFO] [stderr] 32 | | println!("Found {} peers", peers.len()); [INFO] [stderr] 33 | | //thread::sleep(std::time::Duration::from_millis(500)) [INFO] [stderr] 34 | | } [INFO] [stderr] | |_____________________- help: try this: `if peers.insert(remote.into_owned(), ()).is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/main.rs:29:28 [INFO] [stderr] | [INFO] [stderr] 29 | if let None = peers.insert(remote.into_owned(), ()) { [INFO] [stderr] | _____________________- ^^^^ [INFO] [stderr] 30 | | println!("received ping from new peer {} ({})", String::from_utf8_lossy(&buf), peers.len()); [INFO] [stderr] 31 | | } else { [INFO] [stderr] 32 | | println!("Found {} peers", peers.len()); [INFO] [stderr] 33 | | //thread::sleep(std::time::Duration::from_millis(500)) [INFO] [stderr] 34 | | } [INFO] [stderr] | |_____________________- help: try this: `if peers.insert(remote.into_owned(), ()).is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.63s [INFO] running `"docker" "inspect" "ed17b80716cf1e404c5cd0375584120537b303bb40aff3c57dd64b9a50377f6b"` [INFO] running `"docker" "rm" "-f" "ed17b80716cf1e404c5cd0375584120537b303bb40aff3c57dd64b9a50377f6b"` [INFO] [stdout] ed17b80716cf1e404c5cd0375584120537b303bb40aff3c57dd64b9a50377f6b