[INFO] updating cached repository lazear/deface [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/lazear/deface [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/lazear/deface" "work/ex/clippy-test-run/sources/stable/gh/lazear/deface"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/lazear/deface'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/lazear/deface" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lazear/deface"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lazear/deface'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 71a9164f31b6030f50423a4f61962eda484d89cf [INFO] sha for GitHub repo lazear/deface: 71a9164f31b6030f50423a4f61962eda484d89cf [INFO] validating manifest of lazear/deface on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lazear/deface on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lazear/deface [INFO] finished frobbing lazear/deface [INFO] frobbed toml for lazear/deface written to work/ex/clippy-test-run/sources/stable/gh/lazear/deface/Cargo.toml [INFO] started frobbing lazear/deface [INFO] finished frobbing lazear/deface [INFO] frobbed toml for lazear/deface written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lazear/deface/Cargo.toml [INFO] crate lazear/deface has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lazear/deface against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/lazear/deface:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 72cfab69b6efa73ae570b773823be5bcc43d70d8fbaaefa53d24dea1e52b1bb4 [INFO] running `"docker" "start" "-a" "72cfab69b6efa73ae570b773823be5bcc43d70d8fbaaefa53d24dea1e52b1bb4"` [INFO] [stderr] Checking myriad v0.1.1 [INFO] [stderr] Checking deface v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/main.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | self.remaining.peek().map(|s| *s) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.remaining.peek().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 26 [INFO] [stderr] --> src/main.rs:116:5 [INFO] [stderr] | [INFO] [stderr] 116 | / fn transform(&mut self, mut escaped: bool) -> Result { [INFO] [stderr] 117 | | let mut out = String::new(); [INFO] [stderr] 118 | | [INFO] [stderr] 119 | | while let Some(c) = self.next_char() { [INFO] [stderr] ... | [INFO] [stderr] 233 | | Ok(out) [INFO] [stderr] 234 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 29 [INFO] [stderr] --> src/main.rs:236:5 [INFO] [stderr] | [INFO] [stderr] 236 | / fn parse(&mut self) -> Result<(), Error> { [INFO] [stderr] 237 | | let mut in_list = false; [INFO] [stderr] 238 | | let mut in_block = false; [INFO] [stderr] 239 | | let mut paragraph = true; [INFO] [stderr] ... | [INFO] [stderr] 370 | | Ok(()) [INFO] [stderr] 371 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/main.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | self.remaining.peek().map(|s| *s) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.remaining.peek().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 26 [INFO] [stderr] --> src/main.rs:116:5 [INFO] [stderr] | [INFO] [stderr] 116 | / fn transform(&mut self, mut escaped: bool) -> Result { [INFO] [stderr] 117 | | let mut out = String::new(); [INFO] [stderr] 118 | | [INFO] [stderr] 119 | | while let Some(c) = self.next_char() { [INFO] [stderr] ... | [INFO] [stderr] 233 | | Ok(out) [INFO] [stderr] 234 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 29 [INFO] [stderr] --> src/main.rs:236:5 [INFO] [stderr] | [INFO] [stderr] 236 | / fn parse(&mut self) -> Result<(), Error> { [INFO] [stderr] 237 | | let mut in_list = false; [INFO] [stderr] 238 | | let mut in_block = false; [INFO] [stderr] 239 | | let mut paragraph = true; [INFO] [stderr] ... | [INFO] [stderr] 370 | | Ok(()) [INFO] [stderr] 371 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:426:47 [INFO] [stderr] | [INFO] [stderr] 426 | let h = thread::spawn(move || match rx.recv() { [INFO] [stderr] | _______________________________________________^ [INFO] [stderr] 427 | | Ok(file) => { [INFO] [stderr] 428 | | let output: String = file.replace(".md", ".html"); [INFO] [stderr] 429 | | match convert(&file, &output) { [INFO] [stderr] ... | [INFO] [stderr] 434 | | Err(_) => {} [INFO] [stderr] 435 | | }); [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 426 | let h = thread::spawn(move || if let Ok(file) = rx.recv() { [INFO] [stderr] 427 | let output: String = file.replace(".md", ".html"); [INFO] [stderr] 428 | match convert(&file, &output) { [INFO] [stderr] 429 | Ok(_) => println!("Success: {} => {}", file, output), [INFO] [stderr] 430 | Err(e) => eprintln!("Failure: {} => {}: {}", file, output, e.message), [INFO] [stderr] 431 | }; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:441:21 [INFO] [stderr] | [INFO] [stderr] 441 | tx.send(arg); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:426:47 [INFO] [stderr] | [INFO] [stderr] 426 | let h = thread::spawn(move || match rx.recv() { [INFO] [stderr] | _______________________________________________^ [INFO] [stderr] 427 | | Ok(file) => { [INFO] [stderr] 428 | | let output: String = file.replace(".md", ".html"); [INFO] [stderr] 429 | | match convert(&file, &output) { [INFO] [stderr] ... | [INFO] [stderr] 434 | | Err(_) => {} [INFO] [stderr] 435 | | }); [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 426 | let h = thread::spawn(move || if let Ok(file) = rx.recv() { [INFO] [stderr] 427 | let output: String = file.replace(".md", ".html"); [INFO] [stderr] 428 | match convert(&file, &output) { [INFO] [stderr] 429 | Ok(_) => println!("Success: {} => {}", file, output), [INFO] [stderr] 430 | Err(e) => eprintln!("Failure: {} => {}: {}", file, output, e.message), [INFO] [stderr] 431 | }; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:441:21 [INFO] [stderr] | [INFO] [stderr] 441 | tx.send(arg); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.42s [INFO] running `"docker" "inspect" "72cfab69b6efa73ae570b773823be5bcc43d70d8fbaaefa53d24dea1e52b1bb4"` [INFO] running `"docker" "rm" "-f" "72cfab69b6efa73ae570b773823be5bcc43d70d8fbaaefa53d24dea1e52b1bb4"` [INFO] [stdout] 72cfab69b6efa73ae570b773823be5bcc43d70d8fbaaefa53d24dea1e52b1bb4