[INFO] updating cached repository lawliet89/trait-obj
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/lawliet89/trait-obj
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/lawliet89/trait-obj" "work/ex/clippy-test-run/sources/stable/gh/lawliet89/trait-obj"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/lawliet89/trait-obj'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/lawliet89/trait-obj" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lawliet89/trait-obj"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lawliet89/trait-obj'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 63162d70145ef70587c640ee196519218ab9e1aa
[INFO] sha for GitHub repo lawliet89/trait-obj: 63162d70145ef70587c640ee196519218ab9e1aa
[INFO] validating manifest of lawliet89/trait-obj on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of lawliet89/trait-obj on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing lawliet89/trait-obj
[INFO] finished frobbing lawliet89/trait-obj
[INFO] frobbed toml for lawliet89/trait-obj written to work/ex/clippy-test-run/sources/stable/gh/lawliet89/trait-obj/Cargo.toml
[INFO] started frobbing lawliet89/trait-obj
[INFO] finished frobbing lawliet89/trait-obj
[INFO] frobbed toml for lawliet89/trait-obj written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lawliet89/trait-obj/Cargo.toml
[INFO] crate lawliet89/trait-obj has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting lawliet89/trait-obj against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/lawliet89/trait-obj:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] d3044316dec048924205edf3017d5ecf0114d69a83786a23016c026d3b170d35
[INFO] running `"docker" "start" "-a" "d3044316dec048924205edf3017d5ecf0114d69a83786a23016c026d3b170d35"`
[INFO] [stderr]     Checking libc v0.2.21
[INFO] [stderr]     Checking memchr v1.0.1
[INFO] [stderr]     Checking csv v0.15.0
[INFO] [stderr]     Checking trait-obj v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/main.rs:56:13
[INFO] [stderr]    |
[INFO] [stderr] 56 |             reader: reader,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `reader`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/main.rs:57:13
[INFO] [stderr]    |
[INFO] [stderr] 57 |             validator: validator,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `validator`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/main.rs:87:13
[INFO] [stderr]    |
[INFO] [stderr] 87 |             records: records,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `records`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/main.rs:88:13
[INFO] [stderr]    |
[INFO] [stderr] 88 |             validator: validator,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `validator`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/main.rs:56:13
[INFO] [stderr]    |
[INFO] [stderr] 56 |             reader: reader,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `reader`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/main.rs:57:13
[INFO] [stderr]    |
[INFO] [stderr] 57 |             validator: validator,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `validator`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/main.rs:87:13
[INFO] [stderr]    |
[INFO] [stderr] 87 |             records: records,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `records`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/main.rs:88:13
[INFO] [stderr]    |
[INFO] [stderr] 88 |             validator: validator,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `validator`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `byte_strings_to_string`
[INFO] [stderr]   --> src/main.rs:61:5
[INFO] [stderr]    |
[INFO] [stderr] 61 |     fn byte_strings_to_string(record: Vec<csv::ByteString>) -> String {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:20:32
[INFO] [stderr]    |
[INFO] [stderr] 20 |     fn validate(&self, record: &Vec<csv::ByteString>) -> Result<(), String>;
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[csv::ByteString]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/main.rs:72:5
[INFO] [stderr]    |
[INFO] [stderr] 72 | /     pub fn records<'a>(&'a mut self) -> RecordsIterator<'a, Rdr> {
[INFO] [stderr] 73 | |         RecordsIterator::new(self.reader.byte_records(), Box::new(self.validator.deref()))
[INFO] [stderr] 74 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `byte_strings_to_string`
[INFO] [stderr]   --> src/main.rs:61:5
[INFO] [stderr]    |
[INFO] [stderr] 61 |     fn byte_strings_to_string(record: Vec<csv::ByteString>) -> String {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:20:32
[INFO] [stderr]    |
[INFO] [stderr] 20 |     fn validate(&self, record: &Vec<csv::ByteString>) -> Result<(), String>;
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[csv::ByteString]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/main.rs:72:5
[INFO] [stderr]    |
[INFO] [stderr] 72 | /     pub fn records<'a>(&'a mut self) -> RecordsIterator<'a, Rdr> {
[INFO] [stderr] 73 | |         RecordsIterator::new(self.reader.byte_records(), Box::new(self.validator.deref()))
[INFO] [stderr] 74 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 3.33s
[INFO] running `"docker" "inspect" "d3044316dec048924205edf3017d5ecf0114d69a83786a23016c026d3b170d35"`
[INFO] running `"docker" "rm" "-f" "d3044316dec048924205edf3017d5ecf0114d69a83786a23016c026d3b170d35"`
[INFO] [stdout] d3044316dec048924205edf3017d5ecf0114d69a83786a23016c026d3b170d35