[INFO] updating cached repository lasagnaphil/rust-lox
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/lasagnaphil/rust-lox
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/lasagnaphil/rust-lox" "work/ex/clippy-test-run/sources/stable/gh/lasagnaphil/rust-lox"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/lasagnaphil/rust-lox'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/lasagnaphil/rust-lox" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lasagnaphil/rust-lox"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lasagnaphil/rust-lox'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] a1445706717af021b86a1a3ab242bfa95b985c54
[INFO] sha for GitHub repo lasagnaphil/rust-lox: a1445706717af021b86a1a3ab242bfa95b985c54
[INFO] validating manifest of lasagnaphil/rust-lox on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of lasagnaphil/rust-lox on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing lasagnaphil/rust-lox
[INFO] finished frobbing lasagnaphil/rust-lox
[INFO] frobbed toml for lasagnaphil/rust-lox written to work/ex/clippy-test-run/sources/stable/gh/lasagnaphil/rust-lox/Cargo.toml
[INFO] started frobbing lasagnaphil/rust-lox
[INFO] finished frobbing lasagnaphil/rust-lox
[INFO] frobbed toml for lasagnaphil/rust-lox written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lasagnaphil/rust-lox/Cargo.toml
[INFO] crate lasagnaphil/rust-lox has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting lasagnaphil/rust-lox against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/lasagnaphil/rust-lox:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 11df596e04c332613ee62e4f34d6ceeccc86c12a839076c9718710c5f6548c48
[INFO] running `"docker" "start" "-a" "11df596e04c332613ee62e4f34d6ceeccc86c12a839076c9718710c5f6548c48"`
[INFO] [stderr]     Checking rlox v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/parser.rs:26:13
[INFO] [stderr]    |
[INFO] [stderr] 26 |             tokens: tokens, current: 0
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `tokens`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:49:16
[INFO] [stderr]    |
[INFO] [stderr] 49 |                line: line,
[INFO] [stderr]    |                ^^^^^^^^^^ help: replace it with: `line`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/parser.rs:26:13
[INFO] [stderr]    |
[INFO] [stderr] 26 |             tokens: tokens, current: 0
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `tokens`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:49:16
[INFO] [stderr]    |
[INFO] [stderr] 49 |                line: line,
[INFO] [stderr]    |                ^^^^^^^^^^ help: replace it with: `line`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]    --> src/scanner.rs:163:9
[INFO] [stderr]     |
[INFO] [stderr] 163 | /         if self.peek() == '.' {
[INFO] [stderr] 164 | |             if self.peek_next().is_digit(10) {
[INFO] [stderr] 165 | |                 self.advance();
[INFO] [stderr] 166 | |                 while self.peek().is_digit(10) { self.advance(); }
[INFO] [stderr] 167 | |             }
[INFO] [stderr] 168 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 163 |         if self.peek() == '.' && self.peek_next().is_digit(10) {
[INFO] [stderr] 164 |     self.advance();
[INFO] [stderr] 165 |     while self.peek().is_digit(10) { self.advance(); }
[INFO] [stderr] 166 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser.rs:142:9
[INFO] [stderr]     |
[INFO] [stderr] 142 |         return false;
[INFO] [stderr]     |         ^^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser.rs:152:9
[INFO] [stderr]     |
[INFO] [stderr] 152 |         return false;
[INFO] [stderr]     |         ^^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `synchronize`
[INFO] [stderr]    --> src/parser.rs:115:5
[INFO] [stderr]     |
[INFO] [stderr] 115 |     fn synchronize(&mut self) {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice
[INFO] [stderr]    --> src/scanner.rs:118:54
[INFO] [stderr]     |
[INFO] [stderr] 118 |         self.tokens.push(Token::new(token_type, text.into_iter().collect(), literal, self.line));
[INFO] [stderr]     |                                                      ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice
[INFO] [stderr]    --> src/scanner.rs:155:71
[INFO] [stderr]     |
[INFO] [stderr] 155 |         let value = self.source[(self.start + 1)..(self.current - 1)].into_iter().collect();
[INFO] [stderr]     |                                                                       ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice
[INFO] [stderr]    --> src/scanner.rs:170:64
[INFO] [stderr]     |
[INFO] [stderr] 170 |         let value: f64 = self.source[self.start..self.current].into_iter().collect::<String>().parse().unwrap();
[INFO] [stderr]     |                                                                ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice
[INFO] [stderr]    --> src/scanner.rs:176:58
[INFO] [stderr]     |
[INFO] [stderr] 176 |         let text = self.source[self.start..self.current].into_iter().collect::<String>();
[INFO] [stderr]     |                                                          ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: statement can be reduced
[INFO] [stderr]   --> src/parser.rs:86:13
[INFO] [stderr]    |
[INFO] [stderr] 86 |             Expr::Unary(operator, Box::new(right));
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `operator;Box::new(right);`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unnecessary_operation)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]    --> src/scanner.rs:163:9
[INFO] [stderr]     |
[INFO] [stderr] 163 | /         if self.peek() == '.' {
[INFO] [stderr] 164 | |             if self.peek_next().is_digit(10) {
[INFO] [stderr] 165 | |                 self.advance();
[INFO] [stderr] 166 | |                 while self.peek().is_digit(10) { self.advance(); }
[INFO] [stderr] 167 | |             }
[INFO] [stderr] 168 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 163 |         if self.peek() == '.' && self.peek_next().is_digit(10) {
[INFO] [stderr] 164 |     self.advance();
[INFO] [stderr] 165 |     while self.peek().is_digit(10) { self.advance(); }
[INFO] [stderr] 166 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser.rs:142:9
[INFO] [stderr]     |
[INFO] [stderr] 142 |         return false;
[INFO] [stderr]     |         ^^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser.rs:152:9
[INFO] [stderr]     |
[INFO] [stderr] 152 |         return false;
[INFO] [stderr]     |         ^^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/lib.rs:58:14
[INFO] [stderr]    |
[INFO] [stderr] 58 |             .expect(&format!("Path not found: {}", path));
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Path not found: {}", path))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `synchronize`
[INFO] [stderr]    --> src/parser.rs:115:5
[INFO] [stderr]     |
[INFO] [stderr] 115 |     fn synchronize(&mut self) {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice
[INFO] [stderr]    --> src/scanner.rs:118:54
[INFO] [stderr]     |
[INFO] [stderr] 118 |         self.tokens.push(Token::new(token_type, text.into_iter().collect(), literal, self.line));
[INFO] [stderr]     |                                                      ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice
[INFO] [stderr]    --> src/scanner.rs:155:71
[INFO] [stderr]     |
[INFO] [stderr] 155 |         let value = self.source[(self.start + 1)..(self.current - 1)].into_iter().collect();
[INFO] [stderr]     |                                                                       ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice
[INFO] [stderr]    --> src/scanner.rs:170:64
[INFO] [stderr]     |
[INFO] [stderr] 170 |         let value: f64 = self.source[self.start..self.current].into_iter().collect::<String>().parse().unwrap();
[INFO] [stderr]     |                                                                ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice
[INFO] [stderr]    --> src/scanner.rs:176:58
[INFO] [stderr]     |
[INFO] [stderr] 176 |         let text = self.source[self.start..self.current].into_iter().collect::<String>();
[INFO] [stderr]     |                                                          ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: statement can be reduced
[INFO] [stderr]   --> src/parser.rs:86:13
[INFO] [stderr]    |
[INFO] [stderr] 86 |             Expr::Unary(operator, Box::new(right));
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `operator;Box::new(right);`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unnecessary_operation)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/lib.rs:58:14
[INFO] [stderr]    |
[INFO] [stderr] 58 |             .expect(&format!("Path not found: {}", path));
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Path not found: {}", path))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]   --> src/main.rs:13:9
[INFO] [stderr]    |
[INFO] [stderr] 13 |         lox::run_file(&args[1]);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_must_use)] on by default
[INFO] [stderr]    = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]   --> src/main.rs:16:9
[INFO] [stderr]    |
[INFO] [stderr] 16 |         lox::run_prompt();
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]   --> src/main.rs:13:9
[INFO] [stderr]    |
[INFO] [stderr] 13 |         lox::run_file(&args[1]);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_must_use)] on by default
[INFO] [stderr]    = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]   --> src/main.rs:16:9
[INFO] [stderr]    |
[INFO] [stderr] 16 |         lox::run_prompt();
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.88s
[INFO] running `"docker" "inspect" "11df596e04c332613ee62e4f34d6ceeccc86c12a839076c9718710c5f6548c48"`
[INFO] running `"docker" "rm" "-f" "11df596e04c332613ee62e4f34d6ceeccc86c12a839076c9718710c5f6548c48"`
[INFO] [stdout] 11df596e04c332613ee62e4f34d6ceeccc86c12a839076c9718710c5f6548c48