[INFO] updating cached repository larsrh/dotfilesctl [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/larsrh/dotfilesctl [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/larsrh/dotfilesctl" "work/ex/clippy-test-run/sources/stable/gh/larsrh/dotfilesctl"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/larsrh/dotfilesctl'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/larsrh/dotfilesctl" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/larsrh/dotfilesctl"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/larsrh/dotfilesctl'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4ffa18af6e891b2e56c8e76fca32b0e04b4ea4b0 [INFO] sha for GitHub repo larsrh/dotfilesctl: 4ffa18af6e891b2e56c8e76fca32b0e04b4ea4b0 [INFO] validating manifest of larsrh/dotfilesctl on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of larsrh/dotfilesctl on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing larsrh/dotfilesctl [INFO] finished frobbing larsrh/dotfilesctl [INFO] frobbed toml for larsrh/dotfilesctl written to work/ex/clippy-test-run/sources/stable/gh/larsrh/dotfilesctl/Cargo.toml [INFO] started frobbing larsrh/dotfilesctl [INFO] finished frobbing larsrh/dotfilesctl [INFO] frobbed toml for larsrh/dotfilesctl written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/larsrh/dotfilesctl/Cargo.toml [INFO] crate larsrh/dotfilesctl has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting larsrh/dotfilesctl against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/larsrh/dotfilesctl:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3c159a0a0fb1946abbb2ecaf10de55c423f17ccddb1c376a7287500470f481f4 [INFO] running `"docker" "start" "-a" "3c159a0a0fb1946abbb2ecaf10de55c423f17ccddb1c376a7287500470f481f4"` [INFO] [stderr] Checking fs_extra v1.1.0 [INFO] [stderr] Checking atty v0.2.6 [INFO] [stderr] Checking inotify v0.3.0 [INFO] [stderr] Checking net2 v0.2.32 [INFO] [stderr] Checking filetime v0.1.15 [INFO] [stderr] Compiling dbus v0.4.1 [INFO] [stderr] Checking nix v0.5.1 [INFO] [stderr] Checking proptest v0.4.2 [INFO] [stderr] Checking regex v0.2.6 [INFO] [stderr] Checking clap v2.31.1 [INFO] [stderr] Checking remove_dir_all v0.3.0 [INFO] [stderr] Checking error-chain v0.10.0 [INFO] [stderr] Checking failure v0.1.1 [INFO] [stderr] Checking miow v0.1.5 [INFO] [stderr] Checking tempdir v0.3.6 [INFO] [stderr] Checking env_logger v0.5.4 [INFO] [stderr] Checking mio v0.5.1 [INFO] [stderr] warning: redundant linker flag specified for library `dbus-1` [INFO] [stderr] [INFO] [stderr] Checking notify-rust v3.4.2 [INFO] [stderr] Checking pretty_env_logger v0.2.2 [INFO] [stderr] Checking notify v4.0.3 [INFO] [stderr] Checking dotfilesctl v0.2.1-alpha.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/config.rs:28:52 [INFO] [stderr] | [INFO] [stderr] 28 | let path = match self.home.clone().or_else(env::home_dir) { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/config.rs:28:52 [INFO] [stderr] | [INFO] [stderr] 28 | let path = match self.home.clone().or_else(env::home_dir) { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/dotfiles.rs:346:28 [INFO] [stderr] | [INFO] [stderr] 346 | File::create(path).expect(msg.as_ref()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| { let msg = msg.as_ref(); panic!(msg) }))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/dotfiles.rs:361:33 [INFO] [stderr] | [INFO] [stderr] 361 | unix::symlink(src, dst).expect(msg.as_ref()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| { let msg = msg.as_ref(); panic!(msg) }))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/dotfiles.rs:367:28 [INFO] [stderr] | [INFO] [stderr] 367 | File::create(path).expect(msg.as_ref()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| { let msg = msg.as_ref(); panic!(msg) }))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 24.62s [INFO] running `"docker" "inspect" "3c159a0a0fb1946abbb2ecaf10de55c423f17ccddb1c376a7287500470f481f4"` [INFO] running `"docker" "rm" "-f" "3c159a0a0fb1946abbb2ecaf10de55c423f17ccddb1c376a7287500470f481f4"` [INFO] [stdout] 3c159a0a0fb1946abbb2ecaf10de55c423f17ccddb1c376a7287500470f481f4