[INFO] updating cached repository lars-t-hansen/sexpr-rust
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/lars-t-hansen/sexpr-rust
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/lars-t-hansen/sexpr-rust" "work/ex/clippy-test-run/sources/stable/gh/lars-t-hansen/sexpr-rust"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/lars-t-hansen/sexpr-rust'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/lars-t-hansen/sexpr-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lars-t-hansen/sexpr-rust"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lars-t-hansen/sexpr-rust'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 4498ddae316c6ff125a63d1ec4135107a041eb59
[INFO] sha for GitHub repo lars-t-hansen/sexpr-rust: 4498ddae316c6ff125a63d1ec4135107a041eb59
[INFO] validating manifest of lars-t-hansen/sexpr-rust on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of lars-t-hansen/sexpr-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing lars-t-hansen/sexpr-rust
[INFO] finished frobbing lars-t-hansen/sexpr-rust
[INFO] frobbed toml for lars-t-hansen/sexpr-rust written to work/ex/clippy-test-run/sources/stable/gh/lars-t-hansen/sexpr-rust/Cargo.toml
[INFO] started frobbing lars-t-hansen/sexpr-rust
[INFO] finished frobbing lars-t-hansen/sexpr-rust
[INFO] frobbed toml for lars-t-hansen/sexpr-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lars-t-hansen/sexpr-rust/Cargo.toml
[INFO] crate lars-t-hansen/sexpr-rust has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting lars-t-hansen/sexpr-rust against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/lars-t-hansen/sexpr-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] aa6a82a7a5ed70f46575757612b0fe46614c459772d5294648180aa7234441b2
[INFO] running `"docker" "start" "-a" "aa6a82a7a5ed70f46575757612b0fe46614c459772d5294648180aa7234441b2"`
[INFO] [stderr]     Checking unicode_reader v0.1.1
[INFO] [stderr]     Checking sexpr v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:199:13
[INFO] [stderr]     |
[INFO] [stderr] 199 |             input: input,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `input`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:199:13
[INFO] [stderr]     |
[INFO] [stderr] 199 |             input: input,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `input`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:234:9
[INFO] [stderr]     |
[INFO] [stderr] 234 | /         return match self.peek() {
[INFO] [stderr] 235 | |             OOB  => self.fail("Unexpected EOF"),
[INFO] [stderr] 236 | |             '('  => self.parse_list(),
[INFO] [stderr] 237 | |             '#'  => self.parse_sharp(),
[INFO] [stderr] ...   |
[INFO] [stderr] 242 | |             _    => self.fails(format!("Unknown character {}", self.peek()))
[INFO] [stderr] 243 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 234 |         match self.peek() {
[INFO] [stderr] 235 |             OOB  => self.fail("Unexpected EOF"),
[INFO] [stderr] 236 |             '('  => self.parse_list(),
[INFO] [stderr] 237 |             '#'  => self.parse_sharp(),
[INFO] [stderr] 238 |             '"'  => self.parse_string(),
[INFO] [stderr] 239 |             '\'' => self.parse_quote(),
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:234:9
[INFO] [stderr]     |
[INFO] [stderr] 234 | /         return match self.peek() {
[INFO] [stderr] 235 | |             OOB  => self.fail("Unexpected EOF"),
[INFO] [stderr] 236 | |             '('  => self.parse_list(),
[INFO] [stderr] 237 | |             '#'  => self.parse_sharp(),
[INFO] [stderr] ...   |
[INFO] [stderr] 242 | |             _    => self.fails(format!("Unknown character {}", self.peek()))
[INFO] [stderr] 243 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 234 |         match self.peek() {
[INFO] [stderr] 235 |             OOB  => self.fail("Unexpected EOF"),
[INFO] [stderr] 236 |             '('  => self.parse_list(),
[INFO] [stderr] 237 |             '#'  => self.parse_sharp(),
[INFO] [stderr] 238 |             '"'  => self.parse_string(),
[INFO] [stderr] 239 |             '\'' => self.parse_quote(),
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Symtab`
[INFO] [stderr]    --> src/lib.rs:144:5
[INFO] [stderr]     |
[INFO] [stderr] 144 | /     pub fn new() -> Symtab
[INFO] [stderr] 145 | |     {
[INFO] [stderr] 146 | |         Symtab(HashMap::new())
[INFO] [stderr] 147 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 140 | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Symtab`
[INFO] [stderr]    --> src/lib.rs:144:5
[INFO] [stderr]     |
[INFO] [stderr] 144 | /     pub fn new() -> Symtab
[INFO] [stderr] 145 | |     {
[INFO] [stderr] 146 | |         Symtab(HashMap::new())
[INFO] [stderr] 147 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 140 | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/lib.rs:468:23
[INFO] [stderr]     |
[INFO] [stderr] 468 | fn is_number_syntax(s:&Vec<char>) -> (bool, bool)
[INFO] [stderr]     |                       ^^^^^^^^^^ help: change this to: `&[char]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/lib.rs:468:23
[INFO] [stderr]     |
[INFO] [stderr] 468 | fn is_number_syntax(s:&Vec<char>) -> (bool, bool)
[INFO] [stderr]     |                       ^^^^^^^^^^ help: change this to: `&[char]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]    --> src/lib.rs:529:38
[INFO] [stderr]     |
[INFO] [stderr] 529 |     let mut input = CodePoints::from("  hi ho(37)".as_bytes());
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"  hi ho(37)"`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::string_lit_as_bytes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.67s
[INFO] running `"docker" "inspect" "aa6a82a7a5ed70f46575757612b0fe46614c459772d5294648180aa7234441b2"`
[INFO] running `"docker" "rm" "-f" "aa6a82a7a5ed70f46575757612b0fe46614c459772d5294648180aa7234441b2"`
[INFO] [stdout] aa6a82a7a5ed70f46575757612b0fe46614c459772d5294648180aa7234441b2