[INFO] updating cached repository lannonbr/marc_cli
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/lannonbr/marc_cli
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/lannonbr/marc_cli" "work/ex/clippy-test-run/sources/stable/gh/lannonbr/marc_cli"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/lannonbr/marc_cli'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/lannonbr/marc_cli" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lannonbr/marc_cli"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lannonbr/marc_cli'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 5d97996e98b2a54ac38229a60a8546689988ee91
[INFO] sha for GitHub repo lannonbr/marc_cli: 5d97996e98b2a54ac38229a60a8546689988ee91
[INFO] validating manifest of lannonbr/marc_cli on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of lannonbr/marc_cli on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing lannonbr/marc_cli
[INFO] finished frobbing lannonbr/marc_cli
[INFO] frobbed toml for lannonbr/marc_cli written to work/ex/clippy-test-run/sources/stable/gh/lannonbr/marc_cli/Cargo.toml
[INFO] started frobbing lannonbr/marc_cli
[INFO] finished frobbing lannonbr/marc_cli
[INFO] frobbed toml for lannonbr/marc_cli written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lannonbr/marc_cli/Cargo.toml
[INFO] crate lannonbr/marc_cli has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting lannonbr/marc_cli against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/lannonbr/marc_cli:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] f698dc86fca45fa265c881310b0fc54af5adb19da642bf28441d4c8d41657305
[INFO] running `"docker" "start" "-a" "f698dc86fca45fa265c881310b0fc54af5adb19da642bf28441d4c8d41657305"`
[INFO] [stderr]    Compiling backtrace-sys v0.1.5
[INFO] [stderr]     Checking nix v0.5.1
[INFO] [stderr]     Checking backtrace v0.2.3
[INFO] [stderr]     Checking error-chain v0.5.0
[INFO] [stderr]     Checking marc v1.3.0
[INFO] [stderr]     Checking rustyline v1.0.0
[INFO] [stderr]     Checking marc_cli v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/loader.rs:35:5
[INFO] [stderr]    |
[INFO] [stderr] 35 |     return result_vector;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `result_vector`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/loader.rs:11:31
[INFO] [stderr]    |
[INFO] [stderr] 11 | pub fn load_records(filename: &String) -> Vec<marc::Record<'static>> {
[INFO] [stderr]    |                               ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]    |
[INFO] [stderr] 11 | pub fn load_records(filename: &str) -> Vec<marc::Record<'static>> {
[INFO] [stderr]    |                               ^^^^
[INFO] [stderr] help: change `filename.clone()` to
[INFO] [stderr]    |
[INFO] [stderr] 15 |     let file_path = filename.to_string();
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_err()`
[INFO] [stderr]   --> src/main.rs:19:12
[INFO] [stderr]    |
[INFO] [stderr] 19 |       if let Err(_) = rl.load_history(".marc_cli_history.txt") {
[INFO] [stderr]    |  _____-      ^^^^^^
[INFO] [stderr] 20 | |         println!("No previous history found.");
[INFO] [stderr] 21 | |     }
[INFO] [stderr]    | |_____- help: try this: `if rl.load_history(".marc_cli_history.txt").is_err()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/loader.rs:35:5
[INFO] [stderr]    |
[INFO] [stderr] 35 |     return result_vector;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `result_vector`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/loader.rs:11:31
[INFO] [stderr]    |
[INFO] [stderr] 11 | pub fn load_records(filename: &String) -> Vec<marc::Record<'static>> {
[INFO] [stderr]    |                               ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]    |
[INFO] [stderr] 11 | pub fn load_records(filename: &str) -> Vec<marc::Record<'static>> {
[INFO] [stderr]    |                               ^^^^
[INFO] [stderr] help: change `filename.clone()` to
[INFO] [stderr]    |
[INFO] [stderr] 15 |     let file_path = filename.to_string();
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_err()`
[INFO] [stderr]   --> src/main.rs:19:12
[INFO] [stderr]    |
[INFO] [stderr] 19 |       if let Err(_) = rl.load_history(".marc_cli_history.txt") {
[INFO] [stderr]    |  _____-      ^^^^^^
[INFO] [stderr] 20 | |         println!("No previous history found.");
[INFO] [stderr] 21 | |     }
[INFO] [stderr]    | |_____- help: try this: `if rl.load_history(".marc_cli_history.txt").is_err()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 8.77s
[INFO] running `"docker" "inspect" "f698dc86fca45fa265c881310b0fc54af5adb19da642bf28441d4c8d41657305"`
[INFO] running `"docker" "rm" "-f" "f698dc86fca45fa265c881310b0fc54af5adb19da642bf28441d4c8d41657305"`
[INFO] [stdout] f698dc86fca45fa265c881310b0fc54af5adb19da642bf28441d4c8d41657305