[INFO] updating cached repository lampij/HashTable [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/lampij/HashTable [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/lampij/HashTable" "work/ex/clippy-test-run/sources/stable/gh/lampij/HashTable"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/lampij/HashTable'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/lampij/HashTable" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lampij/HashTable"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lampij/HashTable'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6dd4f350b75ac9d941cf815b203a9fc94bcdba9c [INFO] sha for GitHub repo lampij/HashTable: 6dd4f350b75ac9d941cf815b203a9fc94bcdba9c [INFO] validating manifest of lampij/HashTable on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lampij/HashTable on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lampij/HashTable [INFO] finished frobbing lampij/HashTable [INFO] frobbed toml for lampij/HashTable written to work/ex/clippy-test-run/sources/stable/gh/lampij/HashTable/Cargo.toml [INFO] started frobbing lampij/HashTable [INFO] finished frobbing lampij/HashTable [INFO] frobbed toml for lampij/HashTable written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lampij/HashTable/Cargo.toml [INFO] crate lampij/HashTable has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lampij/HashTable against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/lampij/HashTable:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 745c2b118172560bdb152861bae63a516375cda0b2572e9d11526656aa678a82 [INFO] running `"docker" "start" "-a" "745c2b118172560bdb152861bae63a516375cda0b2572e9d11526656aa678a82"` [INFO] [stderr] Checking HashTable v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/hash_table.rs:24:17 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn hash_fun(mut key: &str) -> usize { [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/hash_table.rs:26:6 [INFO] [stderr] | [INFO] [stderr] 26 | let mut key_as_byte_array = key.as_bytes(); [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: crate `HashTable` should have a snake case name such as `hash_table` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/hash_table.rs:8:29 [INFO] [stderr] | [INFO] [stderr] 8 | pub fn add(&mut self, key: &String, value: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/hash_table.rs:8:45 [INFO] [stderr] | [INFO] [stderr] 8 | pub fn add(&mut self, key: &String, value: &String) { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 8 | pub fn add(&mut self, key: &String, value: &str) { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `value.clone()` to [INFO] [stderr] | [INFO] [stderr] 9 | self.internal_collection[hash_fun(&key)] = value.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/hash_table.rs:14:25 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn get(&self, key: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/hash_table.rs:29:20 [INFO] [stderr] | [INFO] [stderr] 29 | table_location = tmp_tab_loc.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `tmp_tab_loc` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/hash_table.rs:24:17 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn hash_fun(mut key: &str) -> usize { [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/hash_table.rs:26:6 [INFO] [stderr] | [INFO] [stderr] 26 | let mut key_as_byte_array = key.as_bytes(); [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `HashTable` [INFO] [stderr] --> src/hash_table.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | pub struct HashTable { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `add` [INFO] [stderr] --> src/hash_table.rs:8:2 [INFO] [stderr] | [INFO] [stderr] 8 | pub fn add(&mut self, key: &String, value: &String) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get` [INFO] [stderr] --> src/hash_table.rs:14:2 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn get(&self, key: &String) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/hash_table.rs:18:2 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn new() -> HashTable { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `hash_fun` [INFO] [stderr] --> src/hash_table.rs:24:1 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn hash_fun(mut key: &str) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: crate `HashTable` should have a snake case name such as `hash_table` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/hash_table.rs:8:29 [INFO] [stderr] | [INFO] [stderr] 8 | pub fn add(&mut self, key: &String, value: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/hash_table.rs:8:45 [INFO] [stderr] | [INFO] [stderr] 8 | pub fn add(&mut self, key: &String, value: &String) { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 8 | pub fn add(&mut self, key: &String, value: &str) { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `value.clone()` to [INFO] [stderr] | [INFO] [stderr] 9 | self.internal_collection[hash_fun(&key)] = value.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/hash_table.rs:14:25 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn get(&self, key: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/hash_table.rs:29:20 [INFO] [stderr] | [INFO] [stderr] 29 | table_location = tmp_tab_loc.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `tmp_tab_loc` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.91s [INFO] running `"docker" "inspect" "745c2b118172560bdb152861bae63a516375cda0b2572e9d11526656aa678a82"` [INFO] running `"docker" "rm" "-f" "745c2b118172560bdb152861bae63a516375cda0b2572e9d11526656aa678a82"` [INFO] [stdout] 745c2b118172560bdb152861bae63a516375cda0b2572e9d11526656aa678a82