[INFO] updating cached repository lambdahands/advent-of-code-2018
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/lambdahands/advent-of-code-2018
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/lambdahands/advent-of-code-2018" "work/ex/clippy-test-run/sources/stable/gh/lambdahands/advent-of-code-2018"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/lambdahands/advent-of-code-2018'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/lambdahands/advent-of-code-2018" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lambdahands/advent-of-code-2018"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lambdahands/advent-of-code-2018'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 507511f034a8c043b6116814d4bada930257965b
[INFO] sha for GitHub repo lambdahands/advent-of-code-2018: 507511f034a8c043b6116814d4bada930257965b
[INFO] validating manifest of lambdahands/advent-of-code-2018 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of lambdahands/advent-of-code-2018 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing lambdahands/advent-of-code-2018
[INFO] finished frobbing lambdahands/advent-of-code-2018
[INFO] frobbed toml for lambdahands/advent-of-code-2018 written to work/ex/clippy-test-run/sources/stable/gh/lambdahands/advent-of-code-2018/Cargo.toml
[INFO] started frobbing lambdahands/advent-of-code-2018
[INFO] finished frobbing lambdahands/advent-of-code-2018
[INFO] frobbed toml for lambdahands/advent-of-code-2018 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lambdahands/advent-of-code-2018/Cargo.toml
[INFO] crate lambdahands/advent-of-code-2018 has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting lambdahands/advent-of-code-2018 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/lambdahands/advent-of-code-2018:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] a24030be858843b7daa69ed85bbbbb7c8cb6cbd65a92538d6fbaa99a2ccb7cbb
[INFO] running `"docker" "start" "-a" "a24030be858843b7daa69ed85bbbbb7c8cb6cbd65a92538d6fbaa99a2ccb7cbb"`
[INFO] [stderr]     Checking num-complex v0.2.1
[INFO] [stderr]     Checking approx v0.3.0
[INFO] [stderr]     Checking memchr v2.1.1
[INFO] [stderr]     Checking rand v0.5.5
[INFO] [stderr]     Checking nom v4.1.1
[INFO] [stderr]     Checking alga v0.7.2
[INFO] [stderr]     Checking nalgebra v0.16.11
[INFO] [stderr]     Checking advent-of-code v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]  --> src/day1.rs:9:49
[INFO] [stderr]   |
[INFO] [stderr] 9 | fn update_total(op: &str, total: &mut i32, num: &i32) {
[INFO] [stderr]   |                                                 ^^^^ help: consider passing by value instead: `i32`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]   --> src/day2.rs:48:5
[INFO] [stderr]    |
[INFO] [stderr] 48 |     find_id(text).map(|i| println!("Common ID Letters: {}", i));
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
[INFO] [stderr]    |     |
[INFO] [stderr]    |     help: try this: `if let Some(i) = find_id(text) { $ crate :: io :: _print ( format_args_nl ! ( $ ( $ arg ) * ) ) ; }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::option_map_unit_fn)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]  --> src/day1.rs:9:49
[INFO] [stderr]   |
[INFO] [stderr] 9 | fn update_total(op: &str, total: &mut i32, num: &i32) {
[INFO] [stderr]   |                                                 ^^^^ help: consider passing by value instead: `i32`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]   --> src/day2.rs:48:5
[INFO] [stderr]    |
[INFO] [stderr] 48 |     find_id(text).map(|i| println!("Common ID Letters: {}", i));
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
[INFO] [stderr]    |     |
[INFO] [stderr]    |     help: try this: `if let Some(i) = find_id(text) { $ crate :: io :: _print ( format_args_nl ! ( $ ( $ arg ) * ) ) ; }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::option_map_unit_fn)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 46.58s
[INFO] running `"docker" "inspect" "a24030be858843b7daa69ed85bbbbb7c8cb6cbd65a92538d6fbaa99a2ccb7cbb"`
[INFO] running `"docker" "rm" "-f" "a24030be858843b7daa69ed85bbbbb7c8cb6cbd65a92538d6fbaa99a2ccb7cbb"`
[INFO] [stdout] a24030be858843b7daa69ed85bbbbb7c8cb6cbd65a92538d6fbaa99a2ccb7cbb