[INFO] updating cached repository lambdabear/increasing_speed_limits [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/lambdabear/increasing_speed_limits [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/lambdabear/increasing_speed_limits" "work/ex/clippy-test-run/sources/stable/gh/lambdabear/increasing_speed_limits"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/lambdabear/increasing_speed_limits'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/lambdabear/increasing_speed_limits" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lambdabear/increasing_speed_limits"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lambdabear/increasing_speed_limits'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 99149c5336fe91b4c321acafbe9b4bb7230f26f6 [INFO] sha for GitHub repo lambdabear/increasing_speed_limits: 99149c5336fe91b4c321acafbe9b4bb7230f26f6 [INFO] validating manifest of lambdabear/increasing_speed_limits on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lambdabear/increasing_speed_limits on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lambdabear/increasing_speed_limits [INFO] finished frobbing lambdabear/increasing_speed_limits [INFO] frobbed toml for lambdabear/increasing_speed_limits written to work/ex/clippy-test-run/sources/stable/gh/lambdabear/increasing_speed_limits/Cargo.toml [INFO] started frobbing lambdabear/increasing_speed_limits [INFO] finished frobbing lambdabear/increasing_speed_limits [INFO] frobbed toml for lambdabear/increasing_speed_limits written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lambdabear/increasing_speed_limits/Cargo.toml [INFO] crate lambdabear/increasing_speed_limits has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lambdabear/increasing_speed_limits against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/lambdabear/increasing_speed_limits:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7c15901d92b6b23c6905ecb7f58839a9c8c39d6e4339f053f2bef197480f135e [INFO] running `"docker" "start" "-a" "7c15901d92b6b23c6905ecb7f58839a9c8c39d6e4339f053f2bef197480f135e"` [INFO] [stderr] Checking increasing-speed-limits v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | input_filename: input_filename, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `input_filename` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | let x = parament[2].parse::().expect("parse error"); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | let y = parament[3].parse::().expect("parse error"); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | let z = parament[4].parse::().expect("parse error"); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:46:17 [INFO] [stderr] | [INFO] [stderr] 46 | let mut a: Vec = Vec::new(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 9th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:47:17 [INFO] [stderr] | [INFO] [stderr] 47 | let mut s: Vec = Vec::new(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | input_filename: input_filename, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `input_filename` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | let x = parament[2].parse::().expect("parse error"); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | let y = parament[3].parse::().expect("parse error"); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | let z = parament[4].parse::().expect("parse error"); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:46:17 [INFO] [stderr] | [INFO] [stderr] 46 | let mut a: Vec = Vec::new(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 9th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:47:17 [INFO] [stderr] | [INFO] [stderr] 47 | let mut s: Vec = Vec::new(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: unused variable: `j` [INFO] [stderr] --> src/lib.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | for j in 0..m { [INFO] [stderr] | ^ help: consider using `_j` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `MOD` should have a snake case name such as `mod` [INFO] [stderr] --> src/compute.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | let MOD = 1_000_000_007; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `seq` [INFO] [stderr] --> src/compute.rs:43:14 [INFO] [stderr] | [INFO] [stderr] 43 | for i in 0..len { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 43 | for (i, ) in seq.iter().enumerate().take(len) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `N` should have a snake case name such as `n` [INFO] [stderr] --> src/lib.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | let N = v[0].parse::().expect("parse error"); [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `j` [INFO] [stderr] --> src/lib.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | for j in 0..m { [INFO] [stderr] | ^ help: consider using `_j` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `MOD` should have a snake case name such as `mod` [INFO] [stderr] --> src/compute.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | let MOD = 1_000_000_007; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `seq` [INFO] [stderr] --> src/compute.rs:43:14 [INFO] [stderr] | [INFO] [stderr] 43 | for i in 0..len { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 43 | for (i, ) in seq.iter().enumerate().take(len) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function `test_BIT` should have a snake case name such as `test_bit` [INFO] [stderr] --> src/compute.rs:60:1 [INFO] [stderr] | [INFO] [stderr] 60 | / fn test_BIT() { [INFO] [stderr] 61 | | let mut tree = BIT::new(5); [INFO] [stderr] 62 | | assert_eq!(vec![0; 6], tree.tree); [INFO] [stderr] 63 | | tree.add(1, 1); [INFO] [stderr] ... | [INFO] [stderr] 79 | | assert_eq!(13, count_inc_seq(s)); [INFO] [stderr] 80 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: variable `N` should have a snake case name such as `n` [INFO] [stderr] --> src/lib.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | let N = v[0].parse::().expect("parse error"); [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.12s [INFO] running `"docker" "inspect" "7c15901d92b6b23c6905ecb7f58839a9c8c39d6e4339f053f2bef197480f135e"` [INFO] running `"docker" "rm" "-f" "7c15901d92b6b23c6905ecb7f58839a9c8c39d6e4339f053f2bef197480f135e"` [INFO] [stdout] 7c15901d92b6b23c6905ecb7f58839a9c8c39d6e4339f053f2bef197480f135e