[INFO] updating cached repository lachlansneff/forge [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/lachlansneff/forge [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/lachlansneff/forge" "work/ex/clippy-test-run/sources/stable/gh/lachlansneff/forge"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/lachlansneff/forge'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/lachlansneff/forge" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lachlansneff/forge"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lachlansneff/forge'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4ea06f25c19c62313ed28b10e94bc5c47bd2d5ea [INFO] sha for GitHub repo lachlansneff/forge: 4ea06f25c19c62313ed28b10e94bc5c47bd2d5ea [INFO] validating manifest of lachlansneff/forge on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lachlansneff/forge on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lachlansneff/forge [INFO] finished frobbing lachlansneff/forge [INFO] frobbed toml for lachlansneff/forge written to work/ex/clippy-test-run/sources/stable/gh/lachlansneff/forge/Cargo.toml [INFO] started frobbing lachlansneff/forge [INFO] finished frobbing lachlansneff/forge [INFO] frobbed toml for lachlansneff/forge written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lachlansneff/forge/Cargo.toml [INFO] crate lachlansneff/forge has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lachlansneff/forge against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/lachlansneff/forge:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d25b445ff6d8f4afc30f7761fd44744489a5a9aca79d0e47223613f13f8f00b3 [INFO] running `"docker" "start" "-a" "d25b445ff6d8f4afc30f7761fd44744489a5a9aca79d0e47223613f13f8f00b3"` [INFO] [stderr] warning: unused manifest key: package.keyword [INFO] [stderr] Checking semver v0.6.0 [INFO] [stderr] Checking toml v0.4.5 [INFO] [stderr] Compiling serde_derive v1.0.23 [INFO] [stderr] Checking rustc_version v0.2.1 [INFO] [stderr] Checking forge v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cli.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | all: all, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `all` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cli.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | all: all, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `all` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Success` [INFO] [stderr] --> src/log.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | Success, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Warning` [INFO] [stderr] --> src/log.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | Warning, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `success` [INFO] [stderr] --> src/log.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn success(s: &str) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `warn` [INFO] [stderr] --> src/log.rs:23:1 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn warn(s: &str) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Cargo` [INFO] [stderr] --> src/cargo.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | Cargo, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `verbose` [INFO] [stderr] --> src/cli.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn verbose(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `version` [INFO] [stderr] --> src/cli.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn version(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/cli.rs:38:34 [INFO] [stderr] | [INFO] [stderr] 38 | !arg.starts_with("-") [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/create.rs:31:20 [INFO] [stderr] | [INFO] [stderr] 31 | xargo.add_flag(match new { [INFO] [stderr] | ____________________^ [INFO] [stderr] 32 | | true => "new", [INFO] [stderr] 33 | | false => "init" [INFO] [stderr] 34 | | }); [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if new { "new" } else { "init" }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Success` [INFO] [stderr] --> src/log.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | Success, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Warning` [INFO] [stderr] --> src/log.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | Warning, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `success` [INFO] [stderr] --> src/log.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn success(s: &str) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `warn` [INFO] [stderr] --> src/log.rs:23:1 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn warn(s: &str) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Cargo` [INFO] [stderr] --> src/cargo.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | Cargo, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `verbose` [INFO] [stderr] --> src/cli.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn verbose(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `version` [INFO] [stderr] --> src/cli.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn version(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/cli.rs:38:34 [INFO] [stderr] | [INFO] [stderr] 38 | !arg.starts_with("-") [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/create.rs:31:20 [INFO] [stderr] | [INFO] [stderr] 31 | xargo.add_flag(match new { [INFO] [stderr] | ____________________^ [INFO] [stderr] 32 | | true => "new", [INFO] [stderr] 33 | | false => "init" [INFO] [stderr] 34 | | }); [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if new { "new" } else { "init" }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.97s [INFO] running `"docker" "inspect" "d25b445ff6d8f4afc30f7761fd44744489a5a9aca79d0e47223613f13f8f00b3"` [INFO] running `"docker" "rm" "-f" "d25b445ff6d8f4afc30f7761fd44744489a5a9aca79d0e47223613f13f8f00b3"` [INFO] [stdout] d25b445ff6d8f4afc30f7761fd44744489a5a9aca79d0e47223613f13f8f00b3