[INFO] updating cached repository lachenmayer/insta-fuzz [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/lachenmayer/insta-fuzz [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/lachenmayer/insta-fuzz" "work/ex/clippy-test-run/sources/stable/gh/lachenmayer/insta-fuzz"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/lachenmayer/insta-fuzz'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/lachenmayer/insta-fuzz" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lachenmayer/insta-fuzz"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lachenmayer/insta-fuzz'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7040c4803bbaeac4acd826740d0055450cf18b19 [INFO] sha for GitHub repo lachenmayer/insta-fuzz: 7040c4803bbaeac4acd826740d0055450cf18b19 [INFO] validating manifest of lachenmayer/insta-fuzz on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lachenmayer/insta-fuzz on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lachenmayer/insta-fuzz [INFO] finished frobbing lachenmayer/insta-fuzz [INFO] frobbed toml for lachenmayer/insta-fuzz written to work/ex/clippy-test-run/sources/stable/gh/lachenmayer/insta-fuzz/Cargo.toml [INFO] started frobbing lachenmayer/insta-fuzz [INFO] finished frobbing lachenmayer/insta-fuzz [INFO] frobbed toml for lachenmayer/insta-fuzz written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lachenmayer/insta-fuzz/Cargo.toml [INFO] crate lachenmayer/insta-fuzz has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lachenmayer/insta-fuzz against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/lachenmayer/insta-fuzz:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] eb213c4dfd66831d3478b658b374a5f084e75545b9ddcf2a73f581d4dda62048 [INFO] running `"docker" "start" "-a" "eb213c4dfd66831d3478b658b374a5f084e75545b9ddcf2a73f581d4dda62048"` [INFO] [stderr] Checking rayon v1.0.1 [INFO] [stderr] Checking jpeg-decoder v0.1.14 [INFO] [stderr] Checking insta v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | / if let &[r, g, b] = pixel { [INFO] [stderr] 37 | | if r > 50 && r as u16 >= (2 * g as u16) && r as u16 >= (2 * b as u16) { [INFO] [stderr] 38 | | reds += 1; [INFO] [stderr] 39 | | } [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 36 | if let [r, g, b] = *pixel { [INFO] [stderr] | ^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:37:20 [INFO] [stderr] | [INFO] [stderr] 37 | if r > 50 && r as u16 >= (2 * g as u16) && r as u16 >= (2 * b as u16) { [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(r)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:37:37 [INFO] [stderr] | [INFO] [stderr] 37 | if r > 50 && r as u16 >= (2 * g as u16) && r as u16 >= (2 * b as u16) { [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:37:50 [INFO] [stderr] | [INFO] [stderr] 37 | if r > 50 && r as u16 >= (2 * g as u16) && r as u16 >= (2 * b as u16) { [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(r)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:37:67 [INFO] [stderr] | [INFO] [stderr] 37 | if r > 50 && r as u16 >= (2 * g as u16) && r as u16 >= (2 * b as u16) { [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:43:30 [INFO] [stderr] | [INFO] [stderr] 43 | let metric = reds as f64 / size as f64; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | / if let &[r, g, b] = pixel { [INFO] [stderr] 37 | | if r > 50 && r as u16 >= (2 * g as u16) && r as u16 >= (2 * b as u16) { [INFO] [stderr] 38 | | reds += 1; [INFO] [stderr] 39 | | } [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 36 | if let [r, g, b] = *pixel { [INFO] [stderr] | ^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:37:20 [INFO] [stderr] | [INFO] [stderr] 37 | if r > 50 && r as u16 >= (2 * g as u16) && r as u16 >= (2 * b as u16) { [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(r)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:37:37 [INFO] [stderr] | [INFO] [stderr] 37 | if r > 50 && r as u16 >= (2 * g as u16) && r as u16 >= (2 * b as u16) { [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:37:50 [INFO] [stderr] | [INFO] [stderr] 37 | if r > 50 && r as u16 >= (2 * g as u16) && r as u16 >= (2 * b as u16) { [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(r)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:37:67 [INFO] [stderr] | [INFO] [stderr] 37 | if r > 50 && r as u16 >= (2 * g as u16) && r as u16 >= (2 * b as u16) { [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:43:30 [INFO] [stderr] | [INFO] [stderr] 43 | let metric = reds as f64 / size as f64; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.98s [INFO] running `"docker" "inspect" "eb213c4dfd66831d3478b658b374a5f084e75545b9ddcf2a73f581d4dda62048"` [INFO] running `"docker" "rm" "-f" "eb213c4dfd66831d3478b658b374a5f084e75545b9ddcf2a73f581d4dda62048"` [INFO] [stdout] eb213c4dfd66831d3478b658b374a5f084e75545b9ddcf2a73f581d4dda62048