[INFO] updating cached repository l3ve/swiTchP [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/l3ve/swiTchP [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/l3ve/swiTchP" "work/ex/clippy-test-run/sources/stable/gh/l3ve/swiTchP"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/l3ve/swiTchP'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/l3ve/swiTchP" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/l3ve/swiTchP"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/l3ve/swiTchP'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] cb184f2fedf90445b9bd7c7650e0e7662163a203 [INFO] sha for GitHub repo l3ve/swiTchP: cb184f2fedf90445b9bd7c7650e0e7662163a203 [INFO] validating manifest of l3ve/swiTchP on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of l3ve/swiTchP on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing l3ve/swiTchP [INFO] finished frobbing l3ve/swiTchP [INFO] frobbed toml for l3ve/swiTchP written to work/ex/clippy-test-run/sources/stable/gh/l3ve/swiTchP/Cargo.toml [INFO] started frobbing l3ve/swiTchP [INFO] finished frobbing l3ve/swiTchP [INFO] frobbed toml for l3ve/swiTchP written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/l3ve/swiTchP/Cargo.toml [INFO] crate l3ve/swiTchP has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting l3ve/swiTchP against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/l3ve/swiTchP:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 913eb7c4d3af37b873e5b71b443f86dce23313b1896b003c6bcba80669ef45f4 [INFO] running `"docker" "start" "-a" "913eb7c4d3af37b873e5b71b443f86dce23313b1896b003c6bcba80669ef45f4"` [INFO] [stderr] Compiling miniz-sys v0.1.10 [INFO] [stderr] Checking flate2 v1.0.1 [INFO] [stderr] Checking to_webp v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/jpeg/mod.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | return Ok(buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(buffer)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/jpeg/mod.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | return buffer; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/jpeg/mod.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | return Cursor::new(data).read_u32::().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Cursor::new(data).read_u32::().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/jpeg/mod.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | return Ok(buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(buffer)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/jpeg/mod.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | return buffer; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/jpeg/mod.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | return Cursor::new(data).read_u32::().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Cursor::new(data).read_u32::().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/jpeg/mod.rs:19:3 [INFO] [stderr] | [INFO] [stderr] 19 | / pub fn new(url: &str) { [INFO] [stderr] 20 | | let mut data_buffer: Vec = Img::get_image_buffer(url).unwrap(); [INFO] [stderr] 21 | | let chucks = Img::chuck_data(&mut data_buffer); [INFO] [stderr] 22 | | println!("{:?}", chucks); [INFO] [stderr] 23 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/jpeg/mod.rs:37:7 [INFO] [stderr] | [INFO] [stderr] 37 | / let mut _chuck_data = Vec::new(); [INFO] [stderr] 38 | | [INFO] [stderr] 39 | | if data[0] == 255u8 { [INFO] [stderr] 40 | | _signature = data.drain(..2).collect(); [INFO] [stderr] ... | [INFO] [stderr] 48 | | _signature = vec![1,2,3]; [INFO] [stderr] 49 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 37 | let _chuck_data = if data[0] == 255u8 { ..; data [INFO] [stderr] 38 | .drain(..(Img::transform_to_decimal(&_data_len) - 2) as usize) [INFO] [stderr] 39 | .collect() } else { ..; Vec::new() }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/jpeg/mod.rs:56:35 [INFO] [stderr] | [INFO] [stderr] 56 | fn transform_to_decimal(buffer: &Vec) -> u32 { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/jpeg/mod.rs:19:3 [INFO] [stderr] | [INFO] [stderr] 19 | / pub fn new(url: &str) { [INFO] [stderr] 20 | | let mut data_buffer: Vec = Img::get_image_buffer(url).unwrap(); [INFO] [stderr] 21 | | let chucks = Img::chuck_data(&mut data_buffer); [INFO] [stderr] 22 | | println!("{:?}", chucks); [INFO] [stderr] 23 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/jpeg/mod.rs:37:7 [INFO] [stderr] | [INFO] [stderr] 37 | / let mut _chuck_data = Vec::new(); [INFO] [stderr] 38 | | [INFO] [stderr] 39 | | if data[0] == 255u8 { [INFO] [stderr] 40 | | _signature = data.drain(..2).collect(); [INFO] [stderr] ... | [INFO] [stderr] 48 | | _signature = vec![1,2,3]; [INFO] [stderr] 49 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 37 | let _chuck_data = if data[0] == 255u8 { ..; data [INFO] [stderr] 38 | .drain(..(Img::transform_to_decimal(&_data_len) - 2) as usize) [INFO] [stderr] 39 | .collect() } else { ..; Vec::new() }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/jpeg/mod.rs:56:35 [INFO] [stderr] | [INFO] [stderr] 56 | fn transform_to_decimal(buffer: &Vec) -> u32 { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.44s [INFO] running `"docker" "inspect" "913eb7c4d3af37b873e5b71b443f86dce23313b1896b003c6bcba80669ef45f4"` [INFO] running `"docker" "rm" "-f" "913eb7c4d3af37b873e5b71b443f86dce23313b1896b003c6bcba80669ef45f4"` [INFO] [stdout] 913eb7c4d3af37b873e5b71b443f86dce23313b1896b003c6bcba80669ef45f4