[INFO] updating cached repository kylejlin/battle-shapes
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/kylejlin/battle-shapes
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/kylejlin/battle-shapes" "work/ex/clippy-test-run/sources/stable/gh/kylejlin/battle-shapes"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kylejlin/battle-shapes'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/kylejlin/battle-shapes" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kylejlin/battle-shapes"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kylejlin/battle-shapes'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] e0beed46db7e6b82cdb9ce32f77f7b5e37557595
[INFO] sha for GitHub repo kylejlin/battle-shapes: e0beed46db7e6b82cdb9ce32f77f7b5e37557595
[INFO] validating manifest of kylejlin/battle-shapes on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of kylejlin/battle-shapes on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing kylejlin/battle-shapes
[INFO] finished frobbing kylejlin/battle-shapes
[INFO] frobbed toml for kylejlin/battle-shapes written to work/ex/clippy-test-run/sources/stable/gh/kylejlin/battle-shapes/Cargo.toml
[INFO] started frobbing kylejlin/battle-shapes
[INFO] finished frobbing kylejlin/battle-shapes
[INFO] frobbed toml for kylejlin/battle-shapes written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kylejlin/battle-shapes/Cargo.toml
[INFO] crate kylejlin/battle-shapes has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting kylejlin/battle-shapes against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/kylejlin/battle-shapes:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 4948e0b9ffc912504280e434e5ffbdd964d05d5cb5b0fdd0ab2d73d6a5baaf70
[INFO] running `"docker" "start" "-a" "4948e0b9ffc912504280e434e5ffbdd964d05d5cb5b0fdd0ab2d73d6a5baaf70"`
[INFO] [stderr]     Checking serde v1.0.46
[INFO] [stderr]     Checking stb_truetype v0.2.2
[INFO] [stderr]     Checking crossbeam-epoch v0.3.1
[INFO] [stderr]     Checking tempfile v3.0.1
[INFO] [stderr]     Checking png v0.12.0
[INFO] [stderr]    Compiling serde_derive v1.0.46
[INFO] [stderr]    Compiling num-derive v0.2.0
[INFO] [stderr]     Checking wayland-window v0.13.3
[INFO] [stderr]     Checking crossbeam-deque v0.2.0
[INFO] [stderr]     Checking rusttype v0.4.3
[INFO] [stderr]     Checking rayon-core v1.4.0
[INFO] [stderr]     Checking winit v0.12.0
[INFO] [stderr]     Checking rayon v1.0.1
[INFO] [stderr]     Checking piston2d-graphics v0.26.0
[INFO] [stderr]     Checking glutin v0.14.0
[INFO] [stderr]     Checking jpeg-decoder v0.1.14
[INFO] [stderr]     Checking image v0.19.0
[INFO] [stderr]     Checking pistoncore-input v0.20.0
[INFO] [stderr]     Checking piston-gfx_texture v0.32.0
[INFO] [stderr]     Checking pistoncore-window v0.31.0
[INFO] [stderr]     Checking piston2d-gfx_graphics v0.51.0
[INFO] [stderr]     Checking pistoncore-event_loop v0.36.0
[INFO] [stderr]     Checking pistoncore-glutin_window v0.46.0
[INFO] [stderr]     Checking piston v0.36.0
[INFO] [stderr]     Checking piston_window v0.79.0
[INFO] [stderr]     Checking battle-shapes v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/battle_shapes/mod.rs:423:16
[INFO] [stderr]     |
[INFO] [stderr] 423 |           } else {
[INFO] [stderr]     |  ________________^
[INFO] [stderr] 424 | |             if self.red_coins > 200.0 {
[INFO] [stderr] 425 | |                 match rand_int(0, 11) {
[INFO] [stderr] 426 | |                     0 ... 4 => {
[INFO] [stderr] ...   |
[INFO] [stderr] 458 | |             }
[INFO] [stderr] 459 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 423 |         } else if self.red_coins > 200.0 {
[INFO] [stderr] 424 |     match rand_int(0, 11) {
[INFO] [stderr] 425 |         0 ... 4 => {
[INFO] [stderr] 426 |             self.force_add_red_troop(
[INFO] [stderr] 427 |                 TroopType::Swordsman,
[INFO] [stderr] 428 |                 position.0,
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/battle_shapes/mod.rs:423:16
[INFO] [stderr]     |
[INFO] [stderr] 423 |           } else {
[INFO] [stderr]     |  ________________^
[INFO] [stderr] 424 | |             if self.red_coins > 200.0 {
[INFO] [stderr] 425 | |                 match rand_int(0, 11) {
[INFO] [stderr] 426 | |                     0 ... 4 => {
[INFO] [stderr] ...   |
[INFO] [stderr] 458 | |             }
[INFO] [stderr] 459 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 423 |         } else if self.red_coins > 200.0 {
[INFO] [stderr] 424 |     match rand_int(0, 11) {
[INFO] [stderr] 425 |         0 ... 4 => {
[INFO] [stderr] 426 |             self.force_add_red_troop(
[INFO] [stderr] 427 |                 TroopType::Swordsman,
[INFO] [stderr] 428 |                 position.0,
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `step`
[INFO] [stderr]   --> src/battle_shapes/battle_field.rs:64:13
[INFO] [stderr]    |
[INFO] [stderr] 64 |         let step = troop.troop_type.get_abs_step() * match troop.team {
[INFO] [stderr]    |             ^^^^ help: consider using `_step` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `is_movable`
[INFO] [stderr]    --> src/battle_shapes/battle_field.rs:260:25
[INFO] [stderr]     |
[INFO] [stderr] 260 |                     let is_movable = engaged_troop.troop_type.is_movable();
[INFO] [stderr]     |                         ^^^^^^^^^^ help: consider using `_is_movable` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `vert_step`
[INFO] [stderr]    --> src/battle_shapes/battle_field.rs:261:25
[INFO] [stderr]     |
[INFO] [stderr] 261 |                     let vert_step = if troop.y > engaged_troop.y {
[INFO] [stderr]     |                         ^^^^^^^^^ help: consider using `_vert_step` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `dt`
[INFO] [stderr]    --> src/battle_shapes/mod.rs:349:39
[INFO] [stderr]     |
[INFO] [stderr] 349 |     pub fn update_computer(&mut self, dt: f64) {
[INFO] [stderr]     |                                       ^^ help: consider using `_dt` instead
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/battle_shapes/troops.rs:42:9
[INFO] [stderr]    |
[INFO] [stderr] 42 | /         match self {
[INFO] [stderr] 43 | |             &Team::Blue => Team::Red,
[INFO] [stderr] 44 | |             &Team::Red => Team::Blue
[INFO] [stderr] 45 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 42 |         match *self {
[INFO] [stderr] 43 |             Team::Blue => Team::Red,
[INFO] [stderr] 44 |             Team::Red => Team::Blue
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/battle_shapes/troops.rs:49:9
[INFO] [stderr]    |
[INFO] [stderr] 49 | /         match self {
[INFO] [stderr] 50 | |             &Team::Blue => [0.0, 0.0, 1.0, 1.0],
[INFO] [stderr] 51 | |             &Team::Red => [1.0, 0.0, 0.0, 1.0]
[INFO] [stderr] 52 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 49 |         match *self {
[INFO] [stderr] 50 |             Team::Blue => [0.0, 0.0, 1.0, 1.0],
[INFO] [stderr] 51 |             Team::Red => [1.0, 0.0, 0.0, 1.0]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/battle_shapes/troops.rs:58:9
[INFO] [stderr]    |
[INFO] [stderr] 58 | /         match self {
[INFO] [stderr] 59 | |             &TroopType::Swordsman => true,
[INFO] [stderr] 60 | |             &TroopType::Wall => true,
[INFO] [stderr] 61 | |             &TroopType::Giant => true,
[INFO] [stderr] ...  |
[INFO] [stderr] 67 | |             &TroopType::CowardArcher => true
[INFO] [stderr] 68 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 58 |         match *self {
[INFO] [stderr] 59 |             TroopType::Swordsman => true,
[INFO] [stderr] 60 |             TroopType::Wall => true,
[INFO] [stderr] 61 |             TroopType::Giant => true,
[INFO] [stderr] 62 |             TroopType::Archer => true,
[INFO] [stderr] 63 |             TroopType::Arrow => false,
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/battle_shapes/troops.rs:72:9
[INFO] [stderr]    |
[INFO] [stderr] 72 | /         match self {
[INFO] [stderr] 73 | |             &TroopType::Swordsman => true,
[INFO] [stderr] 74 | |             &TroopType::Wall => false,
[INFO] [stderr] 75 | |             &TroopType::Giant => true,
[INFO] [stderr] ...  |
[INFO] [stderr] 81 | |             &TroopType::CowardArcher => true
[INFO] [stderr] 82 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 72 |         match *self {
[INFO] [stderr] 73 |             TroopType::Swordsman => true,
[INFO] [stderr] 74 |             TroopType::Wall => false,
[INFO] [stderr] 75 |             TroopType::Giant => true,
[INFO] [stderr] 76 |             TroopType::Archer => true,
[INFO] [stderr] 77 |             TroopType::Arrow => false,
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/battle_shapes/troops.rs:86:9
[INFO] [stderr]    |
[INFO] [stderr] 86 | /         match self {
[INFO] [stderr] 87 | |             &TroopType::Swordsman => 100.0,
[INFO] [stderr] 88 | |             &TroopType::Wall => 300.0,
[INFO] [stderr] 89 | |             &TroopType::Giant => 1000.0,
[INFO] [stderr] ...  |
[INFO] [stderr] 95 | |             &TroopType::CowardArcher => 100.0
[INFO] [stderr] 96 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 86 |         match *self {
[INFO] [stderr] 87 |             TroopType::Swordsman => 100.0,
[INFO] [stderr] 88 |             TroopType::Wall => 300.0,
[INFO] [stderr] 89 |             TroopType::Giant => 1000.0,
[INFO] [stderr] 90 |             TroopType::Archer => 100.0,
[INFO] [stderr] 91 |             TroopType::Arrow => 1.0,
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/battle_shapes/troops.rs:100:9
[INFO] [stderr]     |
[INFO] [stderr] 100 | /         match self {
[INFO] [stderr] 101 | |             &TroopType::Swordsman => 40.0,
[INFO] [stderr] 102 | |             &TroopType::Wall => 40.0,
[INFO] [stderr] 103 | |             &TroopType::Giant => 80.0,
[INFO] [stderr] ...   |
[INFO] [stderr] 109 | |             &TroopType::CowardArcher => 30.0
[INFO] [stderr] 110 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 100 |         match *self {
[INFO] [stderr] 101 |             TroopType::Swordsman => 40.0,
[INFO] [stderr] 102 |             TroopType::Wall => 40.0,
[INFO] [stderr] 103 |             TroopType::Giant => 80.0,
[INFO] [stderr] 104 |             TroopType::Archer => 40.0,
[INFO] [stderr] 105 |             TroopType::Arrow => 10.0,
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/battle_shapes/troops.rs:114:9
[INFO] [stderr]     |
[INFO] [stderr] 114 | /         match self {
[INFO] [stderr] 115 | |             &TroopType::Swordsman => 30.0,
[INFO] [stderr] 116 | |             &TroopType::Wall => 0.0,
[INFO] [stderr] 117 | |             &TroopType::Giant => 100.0,
[INFO] [stderr] ...   |
[INFO] [stderr] 123 | |             &TroopType::CowardArcher => 0.0
[INFO] [stderr] 124 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 114 |         match *self {
[INFO] [stderr] 115 |             TroopType::Swordsman => 30.0,
[INFO] [stderr] 116 |             TroopType::Wall => 0.0,
[INFO] [stderr] 117 |             TroopType::Giant => 100.0,
[INFO] [stderr] 118 |             TroopType::Archer => 0.0,
[INFO] [stderr] 119 |             TroopType::Arrow => 25.0,
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/battle_shapes/troops.rs:128:9
[INFO] [stderr]     |
[INFO] [stderr] 128 | /         match self {
[INFO] [stderr] 129 | |             &TroopType::Swordsman => 0.8,
[INFO] [stderr] 130 | |             &TroopType::Wall => 0.0,
[INFO] [stderr] 131 | |             &TroopType::Giant => 3.5,
[INFO] [stderr] ...   |
[INFO] [stderr] 137 | |             &TroopType::CowardArcher => 2.75
[INFO] [stderr] 138 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 128 |         match *self {
[INFO] [stderr] 129 |             TroopType::Swordsman => 0.8,
[INFO] [stderr] 130 |             TroopType::Wall => 0.0,
[INFO] [stderr] 131 |             TroopType::Giant => 3.5,
[INFO] [stderr] 132 |             TroopType::Archer => 2.0,
[INFO] [stderr] 133 |             TroopType::Arrow => 0.0,
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/battle_shapes/troops.rs:142:9
[INFO] [stderr]     |
[INFO] [stderr] 142 | /         match self {
[INFO] [stderr] 143 | |             &TroopType::Swordsman => 30.0,
[INFO] [stderr] 144 | |             &TroopType::Wall => 10.0,
[INFO] [stderr] 145 | |             &TroopType::Giant => 100.0,
[INFO] [stderr] ...   |
[INFO] [stderr] 151 | |             &TroopType::CowardArcher => 60.0
[INFO] [stderr] 152 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 142 |         match *self {
[INFO] [stderr] 143 |             TroopType::Swordsman => 30.0,
[INFO] [stderr] 144 |             TroopType::Wall => 10.0,
[INFO] [stderr] 145 |             TroopType::Giant => 100.0,
[INFO] [stderr] 146 |             TroopType::Archer => 60.0,
[INFO] [stderr] 147 |             TroopType::Arrow => 0.0,
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/battle_shapes/troops.rs:156:9
[INFO] [stderr]     |
[INFO] [stderr] 156 | /         match self {
[INFO] [stderr] 157 | |             &TroopType::Swordsman => 35.0,
[INFO] [stderr] 158 | |             &TroopType::Wall => 0.0,
[INFO] [stderr] 159 | |             &TroopType::Giant => 12.0,
[INFO] [stderr] ...   |
[INFO] [stderr] 165 | |             &TroopType::CowardArcher => 15.0
[INFO] [stderr] 166 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 156 |         match *self {
[INFO] [stderr] 157 |             TroopType::Swordsman => 35.0,
[INFO] [stderr] 158 |             TroopType::Wall => 0.0,
[INFO] [stderr] 159 |             TroopType::Giant => 12.0,
[INFO] [stderr] 160 |             TroopType::Archer => 20.0,
[INFO] [stderr] 161 |             TroopType::Arrow => 1000.0,
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/battle_shapes/battle_field.rs:49:42
[INFO] [stderr]    |
[INFO] [stderr] 49 |     pub fn update_troop(original_troops: &Vec<Troop>, troop: &mut Troop, dt: f64) -> TroopUpdateResult {
[INFO] [stderr]    |                                          ^^^^^^^^^^^ help: change this to: `&[Troop]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 33
[INFO] [stderr]    --> src/battle_shapes/battle_field.rs:49:5
[INFO] [stderr]     |
[INFO] [stderr] 49  | /     pub fn update_troop(original_troops: &Vec<Troop>, troop: &mut Troop, dt: f64) -> TroopUpdateResult {
[INFO] [stderr] 50  | |         let mut result = TroopUpdateResult::zero_change(Victor::None);
[INFO] [stderr] 51  | |
[INFO] [stderr] 52  | |         if troop.health_bar_counter > dt * HEALTH_BAR_FADE_RATE {
[INFO] [stderr] ...   |
[INFO] [stderr] 305 | |         result
[INFO] [stderr] 306 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/battle_shapes/battle_field.rs:116:54
[INFO] [stderr]     |
[INFO] [stderr] 116 |                                 x: dt * step * 3.0 * (is_movable as u8 as f64),
[INFO] [stderr]     |                                                      ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(is_movable as u8)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/battle_shapes/battle_field.rs:117:53
[INFO] [stderr]     |
[INFO] [stderr] 117 |                                 y: dt * vert_step * (is_movable as u8 as f64),
[INFO] [stderr]     |                                                     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(is_movable as u8)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/battle_shapes/battle_field.rs:142:28
[INFO] [stderr]     |
[INFO] [stderr] 142 |                         && dx.signum() == step.signum()
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(dx.signum() - step.signum()).abs() < error`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::float_cmp)] on by default
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/battle_shapes/battle_field.rs:142:28
[INFO] [stderr]     |
[INFO] [stderr] 142 |                         && dx.signum() == step.signum()
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/battle_shapes/battle_field.rs:248:28
[INFO] [stderr]     |
[INFO] [stderr] 248 |                         && dx.signum() == step.signum()
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(dx.signum() - step.signum()).abs() < error`
[INFO] [stderr]     |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/battle_shapes/battle_field.rs:248:28
[INFO] [stderr]     |
[INFO] [stderr] 248 |                         && dx.signum() == step.signum()
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]    --> src/battle_shapes/battle_field.rs:523:38
[INFO] [stderr]     |
[INFO] [stderr] 523 |                       let multiplier = match &troop.team {
[INFO] [stderr]     |  ______________________________________^
[INFO] [stderr] 524 | |                         &Team::Blue => -3.0,
[INFO] [stderr] 525 | |                         &Team::Red => 0.5
[INFO] [stderr] 526 | |                     };
[INFO] [stderr]     | |_____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 523 |                     let multiplier = match troop.team {
[INFO] [stderr] 524 |                         Team::Blue => -3.0,
[INFO] [stderr] 525 |                         Team::Red => 0.5
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]    --> src/battle_shapes/battle_field.rs:527:49
[INFO] [stderr]     |
[INFO] [stderr] 527 |                       let tip_offset_multiplier = match &troop.team {
[INFO] [stderr]     |  _________________________________________________^
[INFO] [stderr] 528 | |                         &Team::Blue => 0.5,
[INFO] [stderr] 529 | |                         &Team::Red => -1.0
[INFO] [stderr] 530 | |                     };
[INFO] [stderr]     | |_____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 527 |                     let tip_offset_multiplier = match troop.team {
[INFO] [stderr] 528 |                         Team::Blue => 0.5,
[INFO] [stderr] 529 |                         Team::Red => -1.0
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/battle_shapes/mod.rs:191:36
[INFO] [stderr]     |
[INFO] [stderr] 191 |     pub fn update(&mut self, args: &UpdateArgs) {
[INFO] [stderr]     |                                    ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/battle_shapes/mod.rs:226:9
[INFO] [stderr]     |
[INFO] [stderr] 226 | /         if let &Button::Keyboard(key) = args {
[INFO] [stderr] 227 | |             match key {
[INFO] [stderr] 228 | |                 Key::D1 => {
[INFO] [stderr] 229 | |                     self.add_blue_troop_if_legal(TroopType::Swordsman);
[INFO] [stderr] ...   |
[INFO] [stderr] 277 | |             }
[INFO] [stderr] 278 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 226 |         if let Button::Keyboard(key) = *args {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^   ^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 2 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `battle-shapes`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: unused variable: `step`
[INFO] [stderr]   --> src/battle_shapes/battle_field.rs:64:13
[INFO] [stderr]    |
[INFO] [stderr] 64 |         let step = troop.troop_type.get_abs_step() * match troop.team {
[INFO] [stderr]    |             ^^^^ help: consider using `_step` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `is_movable`
[INFO] [stderr]    --> src/battle_shapes/battle_field.rs:260:25
[INFO] [stderr]     |
[INFO] [stderr] 260 |                     let is_movable = engaged_troop.troop_type.is_movable();
[INFO] [stderr]     |                         ^^^^^^^^^^ help: consider using `_is_movable` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `vert_step`
[INFO] [stderr]    --> src/battle_shapes/battle_field.rs:261:25
[INFO] [stderr]     |
[INFO] [stderr] 261 |                     let vert_step = if troop.y > engaged_troop.y {
[INFO] [stderr]     |                         ^^^^^^^^^ help: consider using `_vert_step` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `dt`
[INFO] [stderr]    --> src/battle_shapes/mod.rs:349:39
[INFO] [stderr]     |
[INFO] [stderr] 349 |     pub fn update_computer(&mut self, dt: f64) {
[INFO] [stderr]     |                                       ^^ help: consider using `_dt` instead
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/battle_shapes/troops.rs:42:9
[INFO] [stderr]    |
[INFO] [stderr] 42 | /         match self {
[INFO] [stderr] 43 | |             &Team::Blue => Team::Red,
[INFO] [stderr] 44 | |             &Team::Red => Team::Blue
[INFO] [stderr] 45 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 42 |         match *self {
[INFO] [stderr] 43 |             Team::Blue => Team::Red,
[INFO] [stderr] 44 |             Team::Red => Team::Blue
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/battle_shapes/troops.rs:49:9
[INFO] [stderr]    |
[INFO] [stderr] 49 | /         match self {
[INFO] [stderr] 50 | |             &Team::Blue => [0.0, 0.0, 1.0, 1.0],
[INFO] [stderr] 51 | |             &Team::Red => [1.0, 0.0, 0.0, 1.0]
[INFO] [stderr] 52 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 49 |         match *self {
[INFO] [stderr] 50 |             Team::Blue => [0.0, 0.0, 1.0, 1.0],
[INFO] [stderr] 51 |             Team::Red => [1.0, 0.0, 0.0, 1.0]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/battle_shapes/troops.rs:58:9
[INFO] [stderr]    |
[INFO] [stderr] 58 | /         match self {
[INFO] [stderr] 59 | |             &TroopType::Swordsman => true,
[INFO] [stderr] 60 | |             &TroopType::Wall => true,
[INFO] [stderr] 61 | |             &TroopType::Giant => true,
[INFO] [stderr] ...  |
[INFO] [stderr] 67 | |             &TroopType::CowardArcher => true
[INFO] [stderr] 68 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 58 |         match *self {
[INFO] [stderr] 59 |             TroopType::Swordsman => true,
[INFO] [stderr] 60 |             TroopType::Wall => true,
[INFO] [stderr] 61 |             TroopType::Giant => true,
[INFO] [stderr] 62 |             TroopType::Archer => true,
[INFO] [stderr] 63 |             TroopType::Arrow => false,
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/battle_shapes/troops.rs:72:9
[INFO] [stderr]    |
[INFO] [stderr] 72 | /         match self {
[INFO] [stderr] 73 | |             &TroopType::Swordsman => true,
[INFO] [stderr] 74 | |             &TroopType::Wall => false,
[INFO] [stderr] 75 | |             &TroopType::Giant => true,
[INFO] [stderr] ...  |
[INFO] [stderr] 81 | |             &TroopType::CowardArcher => true
[INFO] [stderr] 82 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 72 |         match *self {
[INFO] [stderr] 73 |             TroopType::Swordsman => true,
[INFO] [stderr] 74 |             TroopType::Wall => false,
[INFO] [stderr] 75 |             TroopType::Giant => true,
[INFO] [stderr] 76 |             TroopType::Archer => true,
[INFO] [stderr] 77 |             TroopType::Arrow => false,
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/battle_shapes/troops.rs:86:9
[INFO] [stderr]    |
[INFO] [stderr] 86 | /         match self {
[INFO] [stderr] 87 | |             &TroopType::Swordsman => 100.0,
[INFO] [stderr] 88 | |             &TroopType::Wall => 300.0,
[INFO] [stderr] 89 | |             &TroopType::Giant => 1000.0,
[INFO] [stderr] ...  |
[INFO] [stderr] 95 | |             &TroopType::CowardArcher => 100.0
[INFO] [stderr] 96 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 86 |         match *self {
[INFO] [stderr] 87 |             TroopType::Swordsman => 100.0,
[INFO] [stderr] 88 |             TroopType::Wall => 300.0,
[INFO] [stderr] 89 |             TroopType::Giant => 1000.0,
[INFO] [stderr] 90 |             TroopType::Archer => 100.0,
[INFO] [stderr] 91 |             TroopType::Arrow => 1.0,
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/battle_shapes/troops.rs:100:9
[INFO] [stderr]     |
[INFO] [stderr] 100 | /         match self {
[INFO] [stderr] 101 | |             &TroopType::Swordsman => 40.0,
[INFO] [stderr] 102 | |             &TroopType::Wall => 40.0,
[INFO] [stderr] 103 | |             &TroopType::Giant => 80.0,
[INFO] [stderr] ...   |
[INFO] [stderr] 109 | |             &TroopType::CowardArcher => 30.0
[INFO] [stderr] 110 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 100 |         match *self {
[INFO] [stderr] 101 |             TroopType::Swordsman => 40.0,
[INFO] [stderr] 102 |             TroopType::Wall => 40.0,
[INFO] [stderr] 103 |             TroopType::Giant => 80.0,
[INFO] [stderr] 104 |             TroopType::Archer => 40.0,
[INFO] [stderr] 105 |             TroopType::Arrow => 10.0,
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/battle_shapes/troops.rs:114:9
[INFO] [stderr]     |
[INFO] [stderr] 114 | /         match self {
[INFO] [stderr] 115 | |             &TroopType::Swordsman => 30.0,
[INFO] [stderr] 116 | |             &TroopType::Wall => 0.0,
[INFO] [stderr] 117 | |             &TroopType::Giant => 100.0,
[INFO] [stderr] ...   |
[INFO] [stderr] 123 | |             &TroopType::CowardArcher => 0.0
[INFO] [stderr] 124 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 114 |         match *self {
[INFO] [stderr] 115 |             TroopType::Swordsman => 30.0,
[INFO] [stderr] 116 |             TroopType::Wall => 0.0,
[INFO] [stderr] 117 |             TroopType::Giant => 100.0,
[INFO] [stderr] 118 |             TroopType::Archer => 0.0,
[INFO] [stderr] 119 |             TroopType::Arrow => 25.0,
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/battle_shapes/troops.rs:128:9
[INFO] [stderr]     |
[INFO] [stderr] 128 | /         match self {
[INFO] [stderr] 129 | |             &TroopType::Swordsman => 0.8,
[INFO] [stderr] 130 | |             &TroopType::Wall => 0.0,
[INFO] [stderr] 131 | |             &TroopType::Giant => 3.5,
[INFO] [stderr] ...   |
[INFO] [stderr] 137 | |             &TroopType::CowardArcher => 2.75
[INFO] [stderr] 138 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 128 |         match *self {
[INFO] [stderr] 129 |             TroopType::Swordsman => 0.8,
[INFO] [stderr] 130 |             TroopType::Wall => 0.0,
[INFO] [stderr] 131 |             TroopType::Giant => 3.5,
[INFO] [stderr] 132 |             TroopType::Archer => 2.0,
[INFO] [stderr] 133 |             TroopType::Arrow => 0.0,
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/battle_shapes/troops.rs:142:9
[INFO] [stderr]     |
[INFO] [stderr] 142 | /         match self {
[INFO] [stderr] 143 | |             &TroopType::Swordsman => 30.0,
[INFO] [stderr] 144 | |             &TroopType::Wall => 10.0,
[INFO] [stderr] 145 | |             &TroopType::Giant => 100.0,
[INFO] [stderr] ...   |
[INFO] [stderr] 151 | |             &TroopType::CowardArcher => 60.0
[INFO] [stderr] 152 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 142 |         match *self {
[INFO] [stderr] 143 |             TroopType::Swordsman => 30.0,
[INFO] [stderr] 144 |             TroopType::Wall => 10.0,
[INFO] [stderr] 145 |             TroopType::Giant => 100.0,
[INFO] [stderr] 146 |             TroopType::Archer => 60.0,
[INFO] [stderr] 147 |             TroopType::Arrow => 0.0,
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/battle_shapes/troops.rs:156:9
[INFO] [stderr]     |
[INFO] [stderr] 156 | /         match self {
[INFO] [stderr] 157 | |             &TroopType::Swordsman => 35.0,
[INFO] [stderr] 158 | |             &TroopType::Wall => 0.0,
[INFO] [stderr] 159 | |             &TroopType::Giant => 12.0,
[INFO] [stderr] ...   |
[INFO] [stderr] 165 | |             &TroopType::CowardArcher => 15.0
[INFO] [stderr] 166 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 156 |         match *self {
[INFO] [stderr] 157 |             TroopType::Swordsman => 35.0,
[INFO] [stderr] 158 |             TroopType::Wall => 0.0,
[INFO] [stderr] 159 |             TroopType::Giant => 12.0,
[INFO] [stderr] 160 |             TroopType::Archer => 20.0,
[INFO] [stderr] 161 |             TroopType::Arrow => 1000.0,
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/battle_shapes/battle_field.rs:49:42
[INFO] [stderr]    |
[INFO] [stderr] 49 |     pub fn update_troop(original_troops: &Vec<Troop>, troop: &mut Troop, dt: f64) -> TroopUpdateResult {
[INFO] [stderr]    |                                          ^^^^^^^^^^^ help: change this to: `&[Troop]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 33
[INFO] [stderr]    --> src/battle_shapes/battle_field.rs:49:5
[INFO] [stderr]     |
[INFO] [stderr] 49  | /     pub fn update_troop(original_troops: &Vec<Troop>, troop: &mut Troop, dt: f64) -> TroopUpdateResult {
[INFO] [stderr] 50  | |         let mut result = TroopUpdateResult::zero_change(Victor::None);
[INFO] [stderr] 51  | |
[INFO] [stderr] 52  | |         if troop.health_bar_counter > dt * HEALTH_BAR_FADE_RATE {
[INFO] [stderr] ...   |
[INFO] [stderr] 305 | |         result
[INFO] [stderr] 306 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/battle_shapes/battle_field.rs:116:54
[INFO] [stderr]     |
[INFO] [stderr] 116 |                                 x: dt * step * 3.0 * (is_movable as u8 as f64),
[INFO] [stderr]     |                                                      ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(is_movable as u8)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/battle_shapes/battle_field.rs:117:53
[INFO] [stderr]     |
[INFO] [stderr] 117 |                                 y: dt * vert_step * (is_movable as u8 as f64),
[INFO] [stderr]     |                                                     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(is_movable as u8)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/battle_shapes/battle_field.rs:142:28
[INFO] [stderr]     |
[INFO] [stderr] 142 |                         && dx.signum() == step.signum()
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(dx.signum() - step.signum()).abs() < error`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::float_cmp)] on by default
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/battle_shapes/battle_field.rs:142:28
[INFO] [stderr]     |
[INFO] [stderr] 142 |                         && dx.signum() == step.signum()
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/battle_shapes/battle_field.rs:248:28
[INFO] [stderr]     |
[INFO] [stderr] 248 |                         && dx.signum() == step.signum()
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(dx.signum() - step.signum()).abs() < error`
[INFO] [stderr]     |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/battle_shapes/battle_field.rs:248:28
[INFO] [stderr]     |
[INFO] [stderr] 248 |                         && dx.signum() == step.signum()
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]    --> src/battle_shapes/battle_field.rs:523:38
[INFO] [stderr]     |
[INFO] [stderr] 523 |                       let multiplier = match &troop.team {
[INFO] [stderr]     |  ______________________________________^
[INFO] [stderr] 524 | |                         &Team::Blue => -3.0,
[INFO] [stderr] 525 | |                         &Team::Red => 0.5
[INFO] [stderr] 526 | |                     };
[INFO] [stderr]     | |_____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 523 |                     let multiplier = match troop.team {
[INFO] [stderr] 524 |                         Team::Blue => -3.0,
[INFO] [stderr] 525 |                         Team::Red => 0.5
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]    --> src/battle_shapes/battle_field.rs:527:49
[INFO] [stderr]     |
[INFO] [stderr] 527 |                       let tip_offset_multiplier = match &troop.team {
[INFO] [stderr]     |  _________________________________________________^
[INFO] [stderr] 528 | |                         &Team::Blue => 0.5,
[INFO] [stderr] 529 | |                         &Team::Red => -1.0
[INFO] [stderr] 530 | |                     };
[INFO] [stderr]     | |_____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 527 |                     let tip_offset_multiplier = match troop.team {
[INFO] [stderr] 528 |                         Team::Blue => 0.5,
[INFO] [stderr] 529 |                         Team::Red => -1.0
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/battle_shapes/mod.rs:191:36
[INFO] [stderr]     |
[INFO] [stderr] 191 |     pub fn update(&mut self, args: &UpdateArgs) {
[INFO] [stderr]     |                                    ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/battle_shapes/mod.rs:226:9
[INFO] [stderr]     |
[INFO] [stderr] 226 | /         if let &Button::Keyboard(key) = args {
[INFO] [stderr] 227 | |             match key {
[INFO] [stderr] 228 | |                 Key::D1 => {
[INFO] [stderr] 229 | |                     self.add_blue_troop_if_legal(TroopType::Swordsman);
[INFO] [stderr] ...   |
[INFO] [stderr] 277 | |             }
[INFO] [stderr] 278 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 226 |         if let Button::Keyboard(key) = *args {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^   ^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 2 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `battle-shapes`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "4948e0b9ffc912504280e434e5ffbdd964d05d5cb5b0fdd0ab2d73d6a5baaf70"`
[INFO] running `"docker" "rm" "-f" "4948e0b9ffc912504280e434e5ffbdd964d05d5cb5b0fdd0ab2d73d6a5baaf70"`
[INFO] [stdout] 4948e0b9ffc912504280e434e5ffbdd964d05d5cb5b0fdd0ab2d73d6a5baaf70