[INFO] updating cached repository kylecorry31/quiet-hours
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/kylecorry31/quiet-hours
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/kylecorry31/quiet-hours" "work/ex/clippy-test-run/sources/stable/gh/kylecorry31/quiet-hours"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kylecorry31/quiet-hours'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/kylecorry31/quiet-hours" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kylecorry31/quiet-hours"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kylecorry31/quiet-hours'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 5ec6204a8f095f2b7d41a5b9612b58e8a81562e0
[INFO] sha for GitHub repo kylecorry31/quiet-hours: 5ec6204a8f095f2b7d41a5b9612b58e8a81562e0
[INFO] validating manifest of kylecorry31/quiet-hours on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of kylecorry31/quiet-hours on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing kylecorry31/quiet-hours
[INFO] finished frobbing kylecorry31/quiet-hours
[INFO] frobbed toml for kylecorry31/quiet-hours written to work/ex/clippy-test-run/sources/stable/gh/kylecorry31/quiet-hours/Cargo.toml
[INFO] started frobbing kylecorry31/quiet-hours
[INFO] finished frobbing kylecorry31/quiet-hours
[INFO] frobbed toml for kylecorry31/quiet-hours written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kylecorry31/quiet-hours/Cargo.toml
[INFO] crate kylecorry31/quiet-hours has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting kylecorry31/quiet-hours against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/kylecorry31/quiet-hours:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] ef162b2882ee3a38b7af61f02ac280ecd806f50434416bcd57f5abca31c65054
[INFO] running `"docker" "start" "-a" "ef162b2882ee3a38b7af61f02ac280ecd806f50434416bcd57f5abca31c65054"`
[INFO] [stderr]     Checking dconf_rs v0.3.0
[INFO] [stderr]     Checking gse_do_not_disturb v1.2.0
[INFO] [stderr]     Checking quiet-hours v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:17:26
[INFO] [stderr]    |
[INFO] [stderr] 17 | const CONFIG_FILE_PATH: &'static str = "quiet-hours/quiet-hours.txt";
[INFO] [stderr]    |                         -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:17:26
[INFO] [stderr]    |
[INFO] [stderr] 17 | const CONFIG_FILE_PATH: &'static str = "quiet-hours/quiet-hours.txt";
[INFO] [stderr]    |                         -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/main.rs:23:48
[INFO] [stderr]    |
[INFO] [stderr] 23 |     let _start_time = Time::from_string(start).expect(format!("Invalid time: {}", start).as_ref());
[INFO] [stderr]    |                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Invalid time: {}", start))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/main.rs:24:44
[INFO] [stderr]    |
[INFO] [stderr] 24 |     let _end_time = Time::from_string(end).expect(format!("Invalid time: {}", end).as_ref());
[INFO] [stderr]    |                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Invalid time: {}", end))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:35:37
[INFO] [stderr]    |
[INFO] [stderr] 35 |     let mut lines = times_str.split("\n").collect::<Vec<&str>>();
[INFO] [stderr]    |                                     ^^^^ help: try using a char instead: `'\n'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:52:33
[INFO] [stderr]    |
[INFO] [stderr] 52 |     let lines = times_str.split("\n").collect::<Vec<&str>>();
[INFO] [stderr]    |                                 ^^^^ help: try using a char instead: `'\n'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/main.rs:118:33
[INFO] [stderr]     |
[INFO] [stderr] 118 |     let lines = times_str.split("\n");
[INFO] [stderr]     |                                 ^^^^ help: try using a char instead: `'\n'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/main.rs:123:32
[INFO] [stderr]     |
[INFO] [stderr] 123 |         let hours = line.split("-").collect::<Vec<&str>>();
[INFO] [stderr]     |                                ^^^ help: try using a char instead: `'-'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/main.rs:156:9
[INFO] [stderr]     |
[INFO] [stderr] 156 | /         let mut quiet_hours = minute_of_day >= start_min && minute_of_day < end_min;
[INFO] [stderr] 157 | |
[INFO] [stderr] 158 | |         // Overnight
[INFO] [stderr] 159 | |         if end_min < start_min {
[INFO] [stderr] 160 | |             quiet_hours = minute_of_day >= start_min || minute_of_day < end_min;
[INFO] [stderr] 161 | |         }
[INFO] [stderr]     | |_________^ help: it is more idiomatic to write: `let <mut> quiet_hours = if end_min < start_min { minute_of_day >= start_min || minute_of_day < end_min } else { minute_of_day >= start_min && minute_of_day < end_min };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/main.rs:23:48
[INFO] [stderr]    |
[INFO] [stderr] 23 |     let _start_time = Time::from_string(start).expect(format!("Invalid time: {}", start).as_ref());
[INFO] [stderr]    |                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Invalid time: {}", start))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/main.rs:24:44
[INFO] [stderr]    |
[INFO] [stderr] 24 |     let _end_time = Time::from_string(end).expect(format!("Invalid time: {}", end).as_ref());
[INFO] [stderr]    |                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Invalid time: {}", end))`
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    |
[INFO] [stderr]    --> src/main.rs:175:19
[INFO] [stderr]     |
[INFO] [stderr] 175 |     let version = format!("{}", crate_version!());
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `env ! ( "CARGO_PKG_VERSION" ).to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:35:37
[INFO] [stderr]    |
[INFO] [stderr] 35 |     let mut lines = times_str.split("\n").collect::<Vec<&str>>();
[INFO] [stderr]    |                                     ^^^^ help: try using a char instead: `'\n'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:52:33
[INFO] [stderr]    |
[INFO] [stderr] 52 |     let lines = times_str.split("\n").collect::<Vec<&str>>();
[INFO] [stderr]    |                                 ^^^^ help: try using a char instead: `'\n'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/main.rs:118:33
[INFO] [stderr]     |
[INFO] [stderr] 118 |     let lines = times_str.split("\n");
[INFO] [stderr]     |                                 ^^^^ help: try using a char instead: `'\n'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/main.rs:123:32
[INFO] [stderr]     |
[INFO] [stderr] 123 |         let hours = line.split("-").collect::<Vec<&str>>();
[INFO] [stderr]     |                                ^^^ help: try using a char instead: `'-'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/main.rs:156:9
[INFO] [stderr]     |
[INFO] [stderr] 156 | /         let mut quiet_hours = minute_of_day >= start_min && minute_of_day < end_min;
[INFO] [stderr] 157 | |
[INFO] [stderr] 158 | |         // Overnight
[INFO] [stderr] 159 | |         if end_min < start_min {
[INFO] [stderr] 160 | |             quiet_hours = minute_of_day >= start_min || minute_of_day < end_min;
[INFO] [stderr] 161 | |         }
[INFO] [stderr]     | |_________^ help: it is more idiomatic to write: `let <mut> quiet_hours = if end_min < start_min { minute_of_day >= start_min || minute_of_day < end_min } else { minute_of_day >= start_min && minute_of_day < end_min };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/main.rs:175:19
[INFO] [stderr]     |
[INFO] [stderr] 175 |     let version = format!("{}", crate_version!());
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `env ! ( "CARGO_PKG_VERSION" ).to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 3.01s
[INFO] running `"docker" "inspect" "ef162b2882ee3a38b7af61f02ac280ecd806f50434416bcd57f5abca31c65054"`
[INFO] running `"docker" "rm" "-f" "ef162b2882ee3a38b7af61f02ac280ecd806f50434416bcd57f5abca31c65054"`
[INFO] [stdout] ef162b2882ee3a38b7af61f02ac280ecd806f50434416bcd57f5abca31c65054