[INFO] updating cached repository kykc/rdp-launcher
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/kykc/rdp-launcher
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/kykc/rdp-launcher" "work/ex/clippy-test-run/sources/stable/gh/kykc/rdp-launcher"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kykc/rdp-launcher'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/kykc/rdp-launcher" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kykc/rdp-launcher"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kykc/rdp-launcher'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] a677b636a3f0e3d95e2adc042a9bd4b9b006c7ec
[INFO] sha for GitHub repo kykc/rdp-launcher: a677b636a3f0e3d95e2adc042a9bd4b9b006c7ec
[INFO] validating manifest of kykc/rdp-launcher on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of kykc/rdp-launcher on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing kykc/rdp-launcher
[INFO] finished frobbing kykc/rdp-launcher
[INFO] frobbed toml for kykc/rdp-launcher written to work/ex/clippy-test-run/sources/stable/gh/kykc/rdp-launcher/Cargo.toml
[INFO] started frobbing kykc/rdp-launcher
[INFO] finished frobbing kykc/rdp-launcher
[INFO] frobbed toml for kykc/rdp-launcher written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kykc/rdp-launcher/Cargo.toml
[INFO] crate kykc/rdp-launcher has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting kykc/rdp-launcher against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/kykc/rdp-launcher:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] a13748b65bcac5f73fa692817b702421cb0cd25eed712cd781f5f7193cb36a99
[INFO] running `"docker" "start" "-a" "a13748b65bcac5f73fa692817b702421cb0cd25eed712cd781f5f7193cb36a99"`
[INFO] [stderr]    Compiling gio v0.5.1
[INFO] [stderr]    Compiling gdk-pixbuf v0.5.0
[INFO] [stderr]    Compiling gdk v0.9.0
[INFO] [stderr]    Compiling gtk v0.5.0
[INFO] [stderr]    Compiling glib-sys v0.7.0
[INFO] [stderr]    Compiling gobject-sys v0.7.0
[INFO] [stderr]    Compiling gio-sys v0.7.0
[INFO] [stderr]    Compiling gdk-pixbuf-sys v0.7.0
[INFO] [stderr]    Compiling pango-sys v0.7.0
[INFO] [stderr]    Compiling gdk-sys v0.7.0
[INFO] [stderr]    Compiling gtk-sys v0.7.0
[INFO] [stderr]     Checking rpassword v2.1.0
[INFO] [stderr]     Checking dirs v1.0.4
[INFO] [stderr]    Compiling serde_derive v1.0.80
[INFO] [stderr]    Compiling cairo-sys-rs v0.7.0
[INFO] [stderr]    Compiling atk-sys v0.7.0
[INFO] [stderr]    Compiling cairo-rs v0.5.0
[INFO] [stderr]     Checking glib v0.6.0
[INFO] [stderr]     Checking pango v0.5.0
[INFO] [stderr]     Checking launch-rdp v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:54:26
[INFO] [stderr]    |
[INFO] [stderr] 54 | const CONFIG_FILE_NAME: &'static str = "rdp-config.json";
[INFO] [stderr]    |                         -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:55:24
[INFO] [stderr]    |
[INFO] [stderr] 55 | const COMMAND_TO_RUN: &'static str = "xfreerdp";
[INFO] [stderr]    |                       -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:56:17
[INFO] [stderr]    |
[INFO] [stderr] 56 | const VERSION: &'static str = env!("CARGO_PKG_VERSION");
[INFO] [stderr]    |                -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:58:18
[INFO] [stderr]    |
[INFO] [stderr] 58 | const ARG_MODE: &'static str = "ARG_MODE";
[INFO] [stderr]    |                 -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:59:20
[INFO] [stderr]    |
[INFO] [stderr] 59 | const ARG_SERVER: &'static str = "ARG_SERVER";
[INFO] [stderr]    |                   -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:60:18
[INFO] [stderr]    |
[INFO] [stderr] 60 | const ARG_USER: &'static str = "ARG_USER";
[INFO] [stderr]    |                 -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:62:22
[INFO] [stderr]    |
[INFO] [stderr] 62 | const ARG_MODE_GUI: &'static str = "gui";
[INFO] [stderr]    |                     -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:63:22
[INFO] [stderr]    |
[INFO] [stderr] 63 | const ARG_MODE_CLI: &'static str = "cli";
[INFO] [stderr]    |                     -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:54:26
[INFO] [stderr]    |
[INFO] [stderr] 54 | const CONFIG_FILE_NAME: &'static str = "rdp-config.json";
[INFO] [stderr]    |                         -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:55:24
[INFO] [stderr]    |
[INFO] [stderr] 55 | const COMMAND_TO_RUN: &'static str = "xfreerdp";
[INFO] [stderr]    |                       -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:56:17
[INFO] [stderr]    |
[INFO] [stderr] 56 | const VERSION: &'static str = env!("CARGO_PKG_VERSION");
[INFO] [stderr]    |                -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:58:18
[INFO] [stderr]    |
[INFO] [stderr] 58 | const ARG_MODE: &'static str = "ARG_MODE";
[INFO] [stderr]    |                 -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:59:20
[INFO] [stderr]    |
[INFO] [stderr] 59 | const ARG_SERVER: &'static str = "ARG_SERVER";
[INFO] [stderr]    |                   -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:60:18
[INFO] [stderr]    |
[INFO] [stderr] 60 | const ARG_USER: &'static str = "ARG_USER";
[INFO] [stderr]    |                 -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:62:22
[INFO] [stderr]    |
[INFO] [stderr] 62 | const ARG_MODE_GUI: &'static str = "gui";
[INFO] [stderr]    |                     -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:63:22
[INFO] [stderr]    |
[INFO] [stderr] 63 | const ARG_MODE_CLI: &'static str = "cli";
[INFO] [stderr]    |                     -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/main.rs:83:23
[INFO] [stderr]    |
[INFO] [stderr] 83 |     let config_file = PathBuf::from(home_dir).join(CONFIG_FILE_NAME);
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `PathBuf::from()`: `home_dir`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:205:24
[INFO] [stderr]     |
[INFO] [stderr] 205 |         has_password = state.borrow().password.len() > 0;
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!state.borrow().password.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/main.rs:83:23
[INFO] [stderr]    |
[INFO] [stderr] 83 |     let config_file = PathBuf::from(home_dir).join(CONFIG_FILE_NAME);
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `PathBuf::from()`: `home_dir`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:205:24
[INFO] [stderr]     |
[INFO] [stderr] 205 |         has_password = state.borrow().password.len() > 0;
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!state.borrow().password.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1m 55s
[INFO] running `"docker" "inspect" "a13748b65bcac5f73fa692817b702421cb0cd25eed712cd781f5f7193cb36a99"`
[INFO] running `"docker" "rm" "-f" "a13748b65bcac5f73fa692817b702421cb0cd25eed712cd781f5f7193cb36a99"`
[INFO] [stdout] a13748b65bcac5f73fa692817b702421cb0cd25eed712cd781f5f7193cb36a99