[INFO] updating cached repository kybp/tetris [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kybp/tetris [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kybp/tetris" "work/ex/clippy-test-run/sources/stable/gh/kybp/tetris"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kybp/tetris'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kybp/tetris" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kybp/tetris"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kybp/tetris'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 383ce8c6198dbfd2273a0470ad7e1a1548875319 [INFO] sha for GitHub repo kybp/tetris: 383ce8c6198dbfd2273a0470ad7e1a1548875319 [INFO] validating manifest of kybp/tetris on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kybp/tetris on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kybp/tetris [INFO] finished frobbing kybp/tetris [INFO] frobbed toml for kybp/tetris written to work/ex/clippy-test-run/sources/stable/gh/kybp/tetris/Cargo.toml [INFO] started frobbing kybp/tetris [INFO] finished frobbing kybp/tetris [INFO] frobbed toml for kybp/tetris written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kybp/tetris/Cargo.toml [INFO] crate kybp/tetris has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kybp/tetris against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/kybp/tetris:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4cf8d4690974399deb69ec108e118ea469f107f052516271c71cf758bb4914fc [INFO] running `"docker" "start" "-a" "4cf8d4690974399deb69ec108e118ea469f107f052516271c71cf758bb4914fc"` [INFO] [stderr] Compiling serde v0.8.21 [INFO] [stderr] Checking piston-shaders_graphics2d v0.1.0 [INFO] [stderr] Compiling miniz-sys v0.1.7 [INFO] [stderr] Compiling x11-dl v2.12.0 [INFO] [stderr] Compiling wayland-scanner v0.7.6 [INFO] [stderr] Checking deque v0.3.1 [INFO] [stderr] Checking pistoncore-input v0.15.0 [INFO] [stderr] Checking piston2d-graphics v0.19.0 [INFO] [stderr] Compiling glutin v0.7.1 [INFO] [stderr] Checking num-rational v0.1.35 [INFO] [stderr] Checking rayon v0.6.0 [INFO] [stderr] Checking enum_primitive v0.1.0 [INFO] [stderr] Checking memmap v0.4.0 [INFO] [stderr] Compiling wayland-client v0.7.6 [INFO] [stderr] Checking flate2 v0.2.14 [INFO] [stderr] Checking pistoncore-window v0.24.0 [INFO] [stderr] Checking pistoncore-event_loop v0.27.0 [INFO] [stderr] Checking png v0.5.2 [INFO] [stderr] Checking jpeg-decoder v0.1.10 [INFO] [stderr] Checking piston v0.27.0 [INFO] [stderr] Checking image v0.10.4 [INFO] [stderr] Compiling serde_json v0.8.4 [INFO] [stderr] Compiling target_build_utils v0.1.2 [INFO] [stderr] Compiling libloading v0.3.1 [INFO] [stderr] Checking piston2d-opengl_graphics v0.36.2 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.7.6 [INFO] [stderr] Checking wayland-window v0.4.3 [INFO] [stderr] Checking wayland-kbd v0.6.2 [INFO] [stderr] Checking winit v0.5.6 [INFO] [stderr] Checking pistoncore-glutin_window v0.33.0 [INFO] [stderr] Checking tetris v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/block.rs:38:17 [INFO] [stderr] | [INFO] [stderr] 38 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:153:13 [INFO] [stderr] | [INFO] [stderr] 153 | counts: counts, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `counts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/block.rs:38:17 [INFO] [stderr] | [INFO] [stderr] 38 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:153:13 [INFO] [stderr] | [INFO] [stderr] 153 | counts: counts, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `counts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/block.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | n as Scalar * CELL_SIZE [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/block.rs:63:52 [INFO] [stderr] | [INFO] [stderr] 63 | &self, direction: Direction, placed_cells: &Vec> [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/block.rs:65:25 [INFO] [stderr] | [INFO] [stderr] 65 | let mut moved = self.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/block.rs:70:35 [INFO] [stderr] | [INFO] [stderr] 70 | fn valid(&self, placed_cells: &Vec>) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/block.rs:76:21 [INFO] [stderr] | [INFO] [stderr] 76 | self.x == cell.x && self.y == cell.y [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(self.x - cell.x).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/block.rs:76:21 [INFO] [stderr] | [INFO] [stderr] 76 | self.x == cell.x && self.y == cell.y [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/block.rs:76:41 [INFO] [stderr] | [INFO] [stderr] 76 | self.x == cell.x && self.y == cell.y [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(self.y - cell.y).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/block.rs:76:41 [INFO] [stderr] | [INFO] [stderr] 76 | self.x == cell.x && self.y == cell.y [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/block.rs:103:48 [INFO] [stderr] | [INFO] [stderr] 103 | pub fn try_rotate(&mut self, placed_cells: &Vec>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/block.rs:141:29 [INFO] [stderr] | [INFO] [stderr] 141 | let scale = (if cell.x == origin_x { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(cell.x - origin_x).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/block.rs:141:29 [INFO] [stderr] | [INFO] [stderr] 141 | let scale = (if cell.x == origin_x { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/block.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | n as Scalar * CELL_SIZE [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/block.rs:63:52 [INFO] [stderr] | [INFO] [stderr] 63 | &self, direction: Direction, placed_cells: &Vec> [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/block.rs:65:25 [INFO] [stderr] | [INFO] [stderr] 65 | let mut moved = self.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/block.rs:70:35 [INFO] [stderr] | [INFO] [stderr] 70 | fn valid(&self, placed_cells: &Vec>) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/block.rs:76:21 [INFO] [stderr] | [INFO] [stderr] 76 | self.x == cell.x && self.y == cell.y [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(self.x - cell.x).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/block.rs:76:21 [INFO] [stderr] | [INFO] [stderr] 76 | self.x == cell.x && self.y == cell.y [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/block.rs:76:41 [INFO] [stderr] | [INFO] [stderr] 76 | self.x == cell.x && self.y == cell.y [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(self.y - cell.y).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/block.rs:76:41 [INFO] [stderr] | [INFO] [stderr] 76 | self.x == cell.x && self.y == cell.y [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/block.rs:163:35 [INFO] [stderr] | [INFO] [stderr] 163 | fn valid(&self, placed_cells: &Vec>) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/block.rs:168:52 [INFO] [stderr] | [INFO] [stderr] 168 | &self, direction: Direction, placed_cells: &Vec> [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/block.rs:176:56 [INFO] [stderr] | [INFO] [stderr] 176 | &mut self, direction: Direction, placed_cells: &Vec> [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/block.rs:103:48 [INFO] [stderr] | [INFO] [stderr] 103 | pub fn try_rotate(&mut self, placed_cells: &Vec>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/block.rs:141:29 [INFO] [stderr] | [INFO] [stderr] 141 | let scale = (if cell.x == origin_x { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(cell.x - origin_x).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/block.rs:141:29 [INFO] [stderr] | [INFO] [stderr] 141 | let scale = (if cell.x == origin_x { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/block.rs:163:35 [INFO] [stderr] | [INFO] [stderr] 163 | fn valid(&self, placed_cells: &Vec>) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/block.rs:168:52 [INFO] [stderr] | [INFO] [stderr] 168 | &self, direction: Direction, placed_cells: &Vec> [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/block.rs:176:56 [INFO] [stderr] | [INFO] [stderr] 176 | &mut self, direction: Direction, placed_cells: &Vec> [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:65:23 [INFO] [stderr] | [INFO] [stderr] 65 | placed_cells: &Vec>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:82:29 [INFO] [stderr] | [INFO] [stderr] 82 | placed_cells: &Vec>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/main.rs:164:16 [INFO] [stderr] | [INFO] [stderr] 164 | if cell.y == row[0].y { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(cell.y - row[0].y).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/main.rs:164:16 [INFO] [stderr] | [INFO] [stderr] 164 | if cell.y == row[0].y { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `placed_cells`. [INFO] [stderr] --> src/main.rs:183:22 [INFO] [stderr] | [INFO] [stderr] 183 | for j in i..placed_cells.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 183 | for in placed_cells.iter_mut().skip(i) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:65:23 [INFO] [stderr] | [INFO] [stderr] 65 | placed_cells: &Vec>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:82:29 [INFO] [stderr] | [INFO] [stderr] 82 | placed_cells: &Vec>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `tetris`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/main.rs:164:16 [INFO] [stderr] | [INFO] [stderr] 164 | if cell.y == row[0].y { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(cell.y - row[0].y).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/main.rs:164:16 [INFO] [stderr] | [INFO] [stderr] 164 | if cell.y == row[0].y { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `placed_cells`. [INFO] [stderr] --> src/main.rs:183:22 [INFO] [stderr] | [INFO] [stderr] 183 | for j in i..placed_cells.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 183 | for in placed_cells.iter_mut().skip(i) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `tetris`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "4cf8d4690974399deb69ec108e118ea469f107f052516271c71cf758bb4914fc"` [INFO] running `"docker" "rm" "-f" "4cf8d4690974399deb69ec108e118ea469f107f052516271c71cf758bb4914fc"` [INFO] [stdout] 4cf8d4690974399deb69ec108e118ea469f107f052516271c71cf758bb4914fc