[INFO] updating cached repository kwyse/qube [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kwyse/qube [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kwyse/qube" "work/ex/clippy-test-run/sources/stable/gh/kwyse/qube"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kwyse/qube'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kwyse/qube" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kwyse/qube"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kwyse/qube'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1a21ac22465b38eb4cc81621213c9ac8922c6620 [INFO] sha for GitHub repo kwyse/qube: 1a21ac22465b38eb4cc81621213c9ac8922c6620 [INFO] validating manifest of kwyse/qube on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kwyse/qube on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kwyse/qube [INFO] finished frobbing kwyse/qube [INFO] frobbed toml for kwyse/qube written to work/ex/clippy-test-run/sources/stable/gh/kwyse/qube/Cargo.toml [INFO] started frobbing kwyse/qube [INFO] finished frobbing kwyse/qube [INFO] frobbed toml for kwyse/qube written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kwyse/qube/Cargo.toml [INFO] crate kwyse/qube has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kwyse/qube against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/kwyse/qube:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e00dc3a57c7fd45143a8106b06e6a53dc3ca8594a747f8d0bfd2f79bfa05732b [INFO] running `"docker" "start" "-a" "e00dc3a57c7fd45143a8106b06e6a53dc3ca8594a747f8d0bfd2f79bfa05732b"` [INFO] [stderr] Checking mio v0.6.15 [INFO] [stderr] Checking want v0.0.6 [INFO] [stderr] Checking tokio-io v0.1.8 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Checking tokio-threadpool v0.1.6 [INFO] [stderr] Checking tokio-codec v0.1.0 [INFO] [stderr] Checking h2 v0.1.12 [INFO] [stderr] Checking tokio-fs v0.1.3 [INFO] [stderr] Checking tokio-reactor v0.1.5 [INFO] [stderr] Checking mio-uds v0.6.6 [INFO] [stderr] Checking tokio-uds v0.2.1 [INFO] [stderr] Checking tokio-tcp v0.1.1 [INFO] [stderr] Checking tokio-udp v0.1.2 [INFO] [stderr] Checking tokio v0.1.8 [INFO] [stderr] Checking hyper v0.12.9 [INFO] [stderr] Checking qube v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:24:10 [INFO] [stderr] | [INFO] [stderr] 24 | .unwrap_or("Nothing here! Best write something!".to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "Nothing here! Best write something!".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:27:29 [INFO] [stderr] | [INFO] [stderr] 27 | fn parse_markdown(markdown: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/main.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | get_file_names(ARTICLES_PATH).unwrap_or(Vec::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `get_file_names(ARTICLES_PATH).unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:24:10 [INFO] [stderr] | [INFO] [stderr] 24 | .unwrap_or("Nothing here! Best write something!".to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "Nothing here! Best write something!".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:27:29 [INFO] [stderr] | [INFO] [stderr] 27 | fn parse_markdown(markdown: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/main.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | get_file_names(ARTICLES_PATH).unwrap_or(Vec::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `get_file_names(ARTICLES_PATH).unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 22.99s [INFO] running `"docker" "inspect" "e00dc3a57c7fd45143a8106b06e6a53dc3ca8594a747f8d0bfd2f79bfa05732b"` [INFO] running `"docker" "rm" "-f" "e00dc3a57c7fd45143a8106b06e6a53dc3ca8594a747f8d0bfd2f79bfa05732b"` [INFO] [stdout] e00dc3a57c7fd45143a8106b06e6a53dc3ca8594a747f8d0bfd2f79bfa05732b