[INFO] updating cached repository kwilson/rust_tutorial_guessing_game [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kwilson/rust_tutorial_guessing_game [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kwilson/rust_tutorial_guessing_game" "work/ex/clippy-test-run/sources/stable/gh/kwilson/rust_tutorial_guessing_game"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kwilson/rust_tutorial_guessing_game'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kwilson/rust_tutorial_guessing_game" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kwilson/rust_tutorial_guessing_game"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kwilson/rust_tutorial_guessing_game'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7c076f389a4be51d867020fcfa6aaeccd723e80a [INFO] sha for GitHub repo kwilson/rust_tutorial_guessing_game: 7c076f389a4be51d867020fcfa6aaeccd723e80a [INFO] validating manifest of kwilson/rust_tutorial_guessing_game on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kwilson/rust_tutorial_guessing_game on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kwilson/rust_tutorial_guessing_game [INFO] finished frobbing kwilson/rust_tutorial_guessing_game [INFO] frobbed toml for kwilson/rust_tutorial_guessing_game written to work/ex/clippy-test-run/sources/stable/gh/kwilson/rust_tutorial_guessing_game/Cargo.toml [INFO] started frobbing kwilson/rust_tutorial_guessing_game [INFO] finished frobbing kwilson/rust_tutorial_guessing_game [INFO] frobbed toml for kwilson/rust_tutorial_guessing_game written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kwilson/rust_tutorial_guessing_game/Cargo.toml [INFO] crate kwilson/rust_tutorial_guessing_game has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kwilson/rust_tutorial_guessing_game against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/kwilson/rust_tutorial_guessing_game:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c0ec412ce09fd59070b58be5e31cf69e636e4c34ef1aa402db5086ccf00c4c31 [INFO] running `"docker" "start" "-a" "c0ec412ce09fd59070b58be5e31cf69e636e4c34ef1aa402db5086ccf00c4c31"` [INFO] [stderr] Checking guessing_game v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | / return match read_line().trim().parse::() { [INFO] [stderr] 51 | | Ok(num) => num, [INFO] [stderr] 52 | | Err(_) => default_value [INFO] [stderr] 53 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 50 | match read_line().trim().parse::() { [INFO] [stderr] 51 | Ok(num) => num, [INFO] [stderr] 52 | Err(_) => default_value [INFO] [stderr] 53 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | return rand::thread_rng().gen_range(min, max + 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `rand::thread_rng().gen_range(min, max + 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | return value; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | / return match read_line().trim().parse::() { [INFO] [stderr] 51 | | Ok(num) => num, [INFO] [stderr] 52 | | Err(_) => default_value [INFO] [stderr] 53 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 50 | match read_line().trim().parse::() { [INFO] [stderr] 51 | Ok(num) => num, [INFO] [stderr] 52 | Err(_) => default_value [INFO] [stderr] 53 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | return rand::thread_rng().gen_range(min, max + 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `rand::thread_rng().gen_range(min, max + 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | return value; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.93s [INFO] running `"docker" "inspect" "c0ec412ce09fd59070b58be5e31cf69e636e4c34ef1aa402db5086ccf00c4c31"` [INFO] running `"docker" "rm" "-f" "c0ec412ce09fd59070b58be5e31cf69e636e4c34ef1aa402db5086ccf00c4c31"` [INFO] [stdout] c0ec412ce09fd59070b58be5e31cf69e636e4c34ef1aa402db5086ccf00c4c31