[INFO] updating cached repository kw-udon/succinct_tree [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kw-udon/succinct_tree [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kw-udon/succinct_tree" "work/ex/clippy-test-run/sources/stable/gh/kw-udon/succinct_tree"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kw-udon/succinct_tree'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kw-udon/succinct_tree" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kw-udon/succinct_tree"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kw-udon/succinct_tree'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 294e92fee0dc18dbf38f0a39e6d63c576e0a0908 [INFO] sha for GitHub repo kw-udon/succinct_tree: 294e92fee0dc18dbf38f0a39e6d63c576e0a0908 [INFO] validating manifest of kw-udon/succinct_tree on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kw-udon/succinct_tree on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kw-udon/succinct_tree [INFO] finished frobbing kw-udon/succinct_tree [INFO] frobbed toml for kw-udon/succinct_tree written to work/ex/clippy-test-run/sources/stable/gh/kw-udon/succinct_tree/Cargo.toml [INFO] started frobbing kw-udon/succinct_tree [INFO] finished frobbing kw-udon/succinct_tree [INFO] frobbed toml for kw-udon/succinct_tree written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kw-udon/succinct_tree/Cargo.toml [INFO] crate kw-udon/succinct_tree has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kw-udon/succinct_tree against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/kw-udon/succinct_tree:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5037edb52a02e0a6dc581d3925fa45c1f8eea8a2f579249668eefa07aa46e7da [INFO] running `"docker" "start" "-a" "5037edb52a02e0a6dc581d3925fa45c1f8eea8a2f579249668eefa07aa46e7da"` [INFO] [stderr] Checking succinct_tree v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rank_select.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | b: b, [INFO] [stderr] | ^^^^ help: replace it with: `b` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rank_select.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | r1: r1, [INFO] [stderr] | ^^^^^^ help: replace it with: `r1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rank_select.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | r2: r2, [INFO] [stderr] | ^^^^^^ help: replace it with: `r2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rank_select.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | tree: tree, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tree` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/rank_select.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | let c = (rank_table[idx as usize] >> (((3 - ((x + 1) % 3)) % 3) * 2) as u8) & 0b11; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/balanced_paren.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | p: p, [INFO] [stderr] | ^^^^ help: replace it with: `p` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/balanced_paren.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | p_idx: p_idx, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `p_idx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/balanced_paren.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | b: b, [INFO] [stderr] | ^^^^ help: replace it with: `b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/balanced_paren.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | p1: p1, [INFO] [stderr] | ^^^^^^ help: replace it with: `p1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/balanced_paren.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/balanced_paren.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | let y = RankSelectIndex::select(b, x as u8); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dfuds_tree.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | inv: inv, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `inv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/dfuds_tree.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | let s = RankSelectIndex::select(&t.inv, r + 1); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rank_select.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | b: b, [INFO] [stderr] | ^^^^ help: replace it with: `b` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rank_select.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | r1: r1, [INFO] [stderr] | ^^^^^^ help: replace it with: `r1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rank_select.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | r2: r2, [INFO] [stderr] | ^^^^^^ help: replace it with: `r2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rank_select.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | tree: tree, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tree` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/rank_select.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | let c = (rank_table[idx as usize] >> (((3 - ((x + 1) % 3)) % 3) * 2) as u8) & 0b11; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/balanced_paren.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | p: p, [INFO] [stderr] | ^^^^ help: replace it with: `p` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/balanced_paren.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | p_idx: p_idx, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `p_idx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/balanced_paren.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | b: b, [INFO] [stderr] | ^^^^ help: replace it with: `b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/balanced_paren.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | p1: p1, [INFO] [stderr] | ^^^^^^ help: replace it with: `p1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/balanced_paren.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/balanced_paren.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | let y = RankSelectIndex::select(b, x as u8); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dfuds_tree.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | inv: inv, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `inv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/dfuds_tree.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | let s = RankSelectIndex::select(&t.inv, r + 1); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rank_select.rs:32:36 [INFO] [stderr] | [INFO] [stderr] 32 | let rank_table: [u8; 8] = [0b000000, 0b000001, 0b000101, 0b000110, 0b010101, 0b010110, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rank_select.rs:32:46 [INFO] [stderr] | [INFO] [stderr] 32 | let rank_table: [u8; 8] = [0b000000, 0b000001, 0b000101, 0b000110, 0b010101, 0b010110, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rank_select.rs:32:56 [INFO] [stderr] | [INFO] [stderr] 32 | let rank_table: [u8; 8] = [0b000000, 0b000001, 0b000101, 0b000110, 0b010101, 0b010110, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rank_select.rs:32:66 [INFO] [stderr] | [INFO] [stderr] 32 | let rank_table: [u8; 8] = [0b000000, 0b000001, 0b000101, 0b000110, 0b010101, 0b010110, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rank_select.rs:32:76 [INFO] [stderr] | [INFO] [stderr] 32 | let rank_table: [u8; 8] = [0b000000, 0b000001, 0b000101, 0b000110, 0b010101, 0b010110, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rank_select.rs:32:86 [INFO] [stderr] | [INFO] [stderr] 32 | let rank_table: [u8; 8] = [0b000000, 0b000001, 0b000101, 0b000110, 0b010101, 0b010110, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_0110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rank_select.rs:33:36 [INFO] [stderr] | [INFO] [stderr] 33 | 0b011010, 0b011011]; [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_1010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rank_select.rs:33:46 [INFO] [stderr] | [INFO] [stderr] 33 | 0b011010, 0b011011]; [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_1011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/balanced_paren.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | y [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/balanced_paren.rs:92:17 [INFO] [stderr] | [INFO] [stderr] 92 | let y = RankSelectIndex::select(b, x as u8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/dfuds_tree.rs:18:44 [INFO] [stderr] | [INFO] [stderr] 18 | let inv = RankSelectIndex::new(p ^ 0xffffffffffffffff); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::mem::size_of` [INFO] [stderr] --> src/main.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use std::mem::size_of; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rank_select.rs:32:36 [INFO] [stderr] | [INFO] [stderr] 32 | let rank_table: [u8; 8] = [0b000000, 0b000001, 0b000101, 0b000110, 0b010101, 0b010110, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rank_select.rs:32:46 [INFO] [stderr] | [INFO] [stderr] 32 | let rank_table: [u8; 8] = [0b000000, 0b000001, 0b000101, 0b000110, 0b010101, 0b010110, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rank_select.rs:32:56 [INFO] [stderr] | [INFO] [stderr] 32 | let rank_table: [u8; 8] = [0b000000, 0b000001, 0b000101, 0b000110, 0b010101, 0b010110, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rank_select.rs:32:66 [INFO] [stderr] | [INFO] [stderr] 32 | let rank_table: [u8; 8] = [0b000000, 0b000001, 0b000101, 0b000110, 0b010101, 0b010110, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rank_select.rs:32:76 [INFO] [stderr] | [INFO] [stderr] 32 | let rank_table: [u8; 8] = [0b000000, 0b000001, 0b000101, 0b000110, 0b010101, 0b010110, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rank_select.rs:32:86 [INFO] [stderr] | [INFO] [stderr] 32 | let rank_table: [u8; 8] = [0b000000, 0b000001, 0b000101, 0b000110, 0b010101, 0b010110, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_0110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rank_select.rs:33:36 [INFO] [stderr] | [INFO] [stderr] 33 | 0b011010, 0b011011]; [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_1010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rank_select.rs:33:46 [INFO] [stderr] | [INFO] [stderr] 33 | 0b011010, 0b011011]; [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_1011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rank_select.rs:157:20 [INFO] [stderr] | [INFO] [stderr] 157 | let bits = 0b1011101010110101000100010010111011111100100111010111110111001011; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b1011_1010_1011_0101_0001_0001_0010_1110_1111_1100_1001_1101_0111_1101_1100_1011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rank_select.rs:168:20 [INFO] [stderr] | [INFO] [stderr] 168 | let bits = 0b1011101010110101000100010010111011111100100111010111110111001011; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b1011_1010_1011_0101_0001_0001_0010_1110_1111_1100_1001_1101_0111_1101_1100_1011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/balanced_paren.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | y [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/balanced_paren.rs:92:17 [INFO] [stderr] | [INFO] [stderr] 92 | let y = RankSelectIndex::select(b, x as u8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/dfuds_tree.rs:18:44 [INFO] [stderr] | [INFO] [stderr] 18 | let inv = RankSelectIndex::new(p ^ 0xffffffffffffffff); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::mem::size_of` [INFO] [stderr] --> src/main.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use std::mem::size_of; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/util.rs:2:20 [INFO] [stderr] | [INFO] [stderr] 2 | pub fn get_bitl(b: &u64, i: u8) -> u8 { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/rank_select.rs:30:28 [INFO] [stderr] | [INFO] [stderr] 30 | let idx = ((r.b >> ((63 - ((x / 3) * 3 + 2)) as u64)) as u8) & 0b111; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(63 - ((x / 3) * 3 + 2))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/balanced_paren.rs:51:15 [INFO] [stderr] | [INFO] [stderr] 51 | while !((get_bitl(&bp.p, p_star) & get_bitl(&bp.b.b, p_star)) == 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(get_bitl(&bp.p, p_star) & get_bitl(&bp.b.b, p_star)) != 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/balanced_paren.rs:106:20 [INFO] [stderr] | [INFO] [stderr] 106 | if stack.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/balanced_paren.rs:160:20 [INFO] [stderr] | [INFO] [stderr] 160 | if stack.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/util.rs:2:20 [INFO] [stderr] | [INFO] [stderr] 2 | pub fn get_bitl(b: &u64, i: u8) -> u8 { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/rank_select.rs:30:28 [INFO] [stderr] | [INFO] [stderr] 30 | let idx = ((r.b >> ((63 - ((x / 3) * 3 + 2)) as u64)) as u8) & 0b111; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(63 - ((x / 3) * 3 + 2))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/rank_select.rs:138:18 [INFO] [stderr] | [INFO] [stderr] 138 | for i in 0..x + 1 { [INFO] [stderr] | ^^^^^^^^ help: use: `0..=x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/rank_select.rs:171:18 [INFO] [stderr] | [INFO] [stderr] 171 | for i in 1..pop + 1 { [INFO] [stderr] | ^^^^^^^^^^ help: use: `1..=pop` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/balanced_paren.rs:51:15 [INFO] [stderr] | [INFO] [stderr] 51 | while !((get_bitl(&bp.p, p_star) & get_bitl(&bp.b.b, p_star)) == 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(get_bitl(&bp.p, p_star) & get_bitl(&bp.b.b, p_star)) != 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/balanced_paren.rs:106:20 [INFO] [stderr] | [INFO] [stderr] 106 | if stack.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/balanced_paren.rs:160:20 [INFO] [stderr] | [INFO] [stderr] 160 | if stack.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.15s [INFO] running `"docker" "inspect" "5037edb52a02e0a6dc581d3925fa45c1f8eea8a2f579249668eefa07aa46e7da"` [INFO] running `"docker" "rm" "-f" "5037edb52a02e0a6dc581d3925fa45c1f8eea8a2f579249668eefa07aa46e7da"` [INFO] [stdout] 5037edb52a02e0a6dc581d3925fa45c1f8eea8a2f579249668eefa07aa46e7da