[INFO] updating cached repository kvineet/bcryptonator [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kvineet/bcryptonator [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kvineet/bcryptonator" "work/ex/clippy-test-run/sources/stable/gh/kvineet/bcryptonator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kvineet/bcryptonator'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kvineet/bcryptonator" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kvineet/bcryptonator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kvineet/bcryptonator'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 23812c09e73e74557762a2855da2cc7060c6a008 [INFO] sha for GitHub repo kvineet/bcryptonator: 23812c09e73e74557762a2855da2cc7060c6a008 [INFO] validating manifest of kvineet/bcryptonator on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kvineet/bcryptonator on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kvineet/bcryptonator [INFO] finished frobbing kvineet/bcryptonator [INFO] frobbed toml for kvineet/bcryptonator written to work/ex/clippy-test-run/sources/stable/gh/kvineet/bcryptonator/Cargo.toml [INFO] started frobbing kvineet/bcryptonator [INFO] finished frobbing kvineet/bcryptonator [INFO] frobbed toml for kvineet/bcryptonator written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kvineet/bcryptonator/Cargo.toml [INFO] crate kvineet/bcryptonator has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kvineet/bcryptonator against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/kvineet/bcryptonator:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a10328cfed29df48606fe94f9d79f7c2f141ea1783c6fe81926e94c4f54c6d67 [INFO] running `"docker" "start" "-a" "a10328cfed29df48606fe94f9d79f7c2f141ea1783c6fe81926e94c4f54c6d67"` [INFO] [stderr] Compiling syn v0.13.7 [INFO] [stderr] Checking block-cipher-trait v0.5.0 [INFO] [stderr] Checking blowfish v0.3.0 [INFO] [stderr] Checking bcrypt v0.2.0 [INFO] [stderr] Compiling serde_derive_internals v0.23.1 [INFO] [stderr] Compiling serde_derive v1.0.45 [INFO] [stderr] Checking docopt v0.8.3 [INFO] [stderr] Checking bcryptonator v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:9:17 [INFO] [stderr] | [INFO] [stderr] 9 | const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:10:15 [INFO] [stderr] | [INFO] [stderr] 10 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:9:17 [INFO] [stderr] | [INFO] [stderr] 9 | const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:10:15 [INFO] [stderr] | [INFO] [stderr] 10 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | / match args.flag_version { [INFO] [stderr] 38 | | true => println!("Version {}", VERSION), [INFO] [stderr] 39 | | false => encrypt(args.arg_passwords, args.flag_cost as u32) [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if args.flag_version { println!("Version {}", VERSION) } else { encrypt(args.arg_passwords, args.flag_cost as u32) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | / match args.flag_version { [INFO] [stderr] 38 | | true => println!("Version {}", VERSION), [INFO] [stderr] 39 | | false => encrypt(args.arg_passwords, args.flag_cost as u32) [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if args.flag_version { println!("Version {}", VERSION) } else { encrypt(args.arg_passwords, args.flag_cost as u32) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 22.31s [INFO] running `"docker" "inspect" "a10328cfed29df48606fe94f9d79f7c2f141ea1783c6fe81926e94c4f54c6d67"` [INFO] running `"docker" "rm" "-f" "a10328cfed29df48606fe94f9d79f7c2f141ea1783c6fe81926e94c4f54c6d67"` [INFO] [stdout] a10328cfed29df48606fe94f9d79f7c2f141ea1783c6fe81926e94c4f54c6d67