[INFO] updating cached repository kurnevsky/nc-task [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kurnevsky/nc-task [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kurnevsky/nc-task" "work/ex/clippy-test-run/sources/stable/gh/kurnevsky/nc-task"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kurnevsky/nc-task'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kurnevsky/nc-task" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kurnevsky/nc-task"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kurnevsky/nc-task'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e23a70cd20f4272de78b9f0458834e31e9cb332c [INFO] sha for GitHub repo kurnevsky/nc-task: e23a70cd20f4272de78b9f0458834e31e9cb332c [INFO] validating manifest of kurnevsky/nc-task on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kurnevsky/nc-task on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kurnevsky/nc-task [INFO] finished frobbing kurnevsky/nc-task [INFO] frobbed toml for kurnevsky/nc-task written to work/ex/clippy-test-run/sources/stable/gh/kurnevsky/nc-task/Cargo.toml [INFO] started frobbing kurnevsky/nc-task [INFO] finished frobbing kurnevsky/nc-task [INFO] frobbed toml for kurnevsky/nc-task written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kurnevsky/nc-task/Cargo.toml [INFO] crate kurnevsky/nc-task has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kurnevsky/nc-task against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/kurnevsky/nc-task:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0f4b85d67f648f49a8a1cab98d8d33f2011ccc4abee9e9830254347db0543e65 [INFO] running `"docker" "start" "-a" "0f4b85d67f648f49a8a1cab98d8d33f2011ccc4abee9e9830254347db0543e65"` [INFO] [stderr] Checking bytes v0.4.9 [INFO] [stderr] Checking parking_lot_core v0.2.14 [INFO] [stderr] Checking parking_lot v0.6.3 [INFO] [stderr] Checking tokio-io v0.1.7 [INFO] [stderr] Checking http v0.1.8 [INFO] [stderr] Checking tokio-codec v0.1.0 [INFO] [stderr] Checking tokio-reactor v0.1.2 [INFO] [stderr] Checking tokio-fs v0.1.2 [INFO] [stderr] Checking tokio-tcp v0.1.0 [INFO] [stderr] Checking tokio-udp v0.1.1 [INFO] [stderr] Checking tokio v0.1.7 [INFO] [stderr] Checking h2 v0.1.10 [INFO] [stderr] Checking hyper v0.12.7 [INFO] [stderr] Checking rp v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/proxy_editor_service.rs:44:24 [INFO] [stderr] | [INFO] [stderr] 44 | if let Some(_) = self.routes.write().remove(req.uri().path()) { [INFO] [stderr] | _________________- ^^^^^^^ [INFO] [stderr] 45 | | Box::new(future::ok(Response::new(Body::empty()))) [INFO] [stderr] 46 | | } else { [INFO] [stderr] 47 | | Box::new(future::ok(Response::builder() [INFO] [stderr] ... | [INFO] [stderr] 50 | | .unwrap())) [INFO] [stderr] 51 | | } [INFO] [stderr] | |_________________- help: try this: `if self.routes.write().remove(req.uri().path()).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/proxy_editor_service.rs:44:24 [INFO] [stderr] | [INFO] [stderr] 44 | if let Some(_) = self.routes.write().remove(req.uri().path()) { [INFO] [stderr] | _________________- ^^^^^^^ [INFO] [stderr] 45 | | Box::new(future::ok(Response::new(Body::empty()))) [INFO] [stderr] 46 | | } else { [INFO] [stderr] 47 | | Box::new(future::ok(Response::builder() [INFO] [stderr] ... | [INFO] [stderr] 50 | | .unwrap())) [INFO] [stderr] 51 | | } [INFO] [stderr] | |_________________- help: try this: `if self.routes.write().remove(req.uri().path()).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 22.47s [INFO] running `"docker" "inspect" "0f4b85d67f648f49a8a1cab98d8d33f2011ccc4abee9e9830254347db0543e65"` [INFO] running `"docker" "rm" "-f" "0f4b85d67f648f49a8a1cab98d8d33f2011ccc4abee9e9830254347db0543e65"` [INFO] [stdout] 0f4b85d67f648f49a8a1cab98d8d33f2011ccc4abee9e9830254347db0543e65