[INFO] updating cached repository kurikaesu/Rust-Iterative-MergeSort [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kurikaesu/Rust-Iterative-MergeSort [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kurikaesu/Rust-Iterative-MergeSort" "work/ex/clippy-test-run/sources/stable/gh/kurikaesu/Rust-Iterative-MergeSort"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kurikaesu/Rust-Iterative-MergeSort'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kurikaesu/Rust-Iterative-MergeSort" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kurikaesu/Rust-Iterative-MergeSort"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kurikaesu/Rust-Iterative-MergeSort'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f2f48105720814f8309187f541f0ee6ab6404f0a [INFO] sha for GitHub repo kurikaesu/Rust-Iterative-MergeSort: f2f48105720814f8309187f541f0ee6ab6404f0a [INFO] validating manifest of kurikaesu/Rust-Iterative-MergeSort on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kurikaesu/Rust-Iterative-MergeSort on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kurikaesu/Rust-Iterative-MergeSort [INFO] finished frobbing kurikaesu/Rust-Iterative-MergeSort [INFO] frobbed toml for kurikaesu/Rust-Iterative-MergeSort written to work/ex/clippy-test-run/sources/stable/gh/kurikaesu/Rust-Iterative-MergeSort/Cargo.toml [INFO] started frobbing kurikaesu/Rust-Iterative-MergeSort [INFO] finished frobbing kurikaesu/Rust-Iterative-MergeSort [INFO] frobbed toml for kurikaesu/Rust-Iterative-MergeSort written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kurikaesu/Rust-Iterative-MergeSort/Cargo.toml [INFO] crate kurikaesu/Rust-Iterative-MergeSort has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kurikaesu/Rust-Iterative-MergeSort against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/kurikaesu/Rust-Iterative-MergeSort:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 10bf4f539c755ce3cfb75a8ee592924c0a233a5c78fbefbaa4922cf13c13ae0f [INFO] running `"docker" "start" "-a" "10bf4f539c755ce3cfb75a8ee592924c0a233a5c78fbefbaa4922cf13c13ae0f"` [INFO] [stderr] Checking MergeSortIterative v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | return y; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `y` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | return vec; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `vec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:118:5 [INFO] [stderr] | [INFO] [stderr] 118 | return vec; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `vec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | return y; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `y` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | return vec; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `vec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:118:5 [INFO] [stderr] | [INFO] [stderr] 118 | return vec; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `vec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: crate `MergeSortIterative` should have a snake case name such as `merge_sort_iterative` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: crate `MergeSortIterative` should have a snake case name such as `merge_sort_iterative` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/main.rs:73:32 [INFO] [stderr] | [INFO] [stderr] 73 | let left_parts: Vec = vec[left..mid + 1].iter().map(|&x| x).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `vec[left..mid + 1].iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:73:36 [INFO] [stderr] | [INFO] [stderr] 73 | let left_parts: Vec = vec[left..mid + 1].iter().map(|&x| x).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: use: `left..=mid` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/main.rs:74:33 [INFO] [stderr] | [INFO] [stderr] 74 | let right_parts: Vec = vec[(mid+1)..(right+1)].iter().map(|&x| x).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `vec[(mid+1)..(right+1)].iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:74:37 [INFO] [stderr] | [INFO] [stderr] 74 | let right_parts: Vec = vec[(mid+1)..(right+1)].iter().map(|&x| x).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `((mid+1)..=right)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/main.rs:73:32 [INFO] [stderr] | [INFO] [stderr] 73 | let left_parts: Vec = vec[left..mid + 1].iter().map(|&x| x).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `vec[left..mid + 1].iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:73:36 [INFO] [stderr] | [INFO] [stderr] 73 | let left_parts: Vec = vec[left..mid + 1].iter().map(|&x| x).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: use: `left..=mid` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/main.rs:74:33 [INFO] [stderr] | [INFO] [stderr] 74 | let right_parts: Vec = vec[(mid+1)..(right+1)].iter().map(|&x| x).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `vec[(mid+1)..(right+1)].iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:74:37 [INFO] [stderr] | [INFO] [stderr] 74 | let right_parts: Vec = vec[(mid+1)..(right+1)].iter().map(|&x| x).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `((mid+1)..=right)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.76s [INFO] running `"docker" "inspect" "10bf4f539c755ce3cfb75a8ee592924c0a233a5c78fbefbaa4922cf13c13ae0f"` [INFO] running `"docker" "rm" "-f" "10bf4f539c755ce3cfb75a8ee592924c0a233a5c78fbefbaa4922cf13c13ae0f"` [INFO] [stdout] 10bf4f539c755ce3cfb75a8ee592924c0a233a5c78fbefbaa4922cf13c13ae0f