[INFO] updating cached repository kurenaif/git-remote-open [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kurenaif/git-remote-open [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kurenaif/git-remote-open" "work/ex/clippy-test-run/sources/stable/gh/kurenaif/git-remote-open"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kurenaif/git-remote-open'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kurenaif/git-remote-open" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kurenaif/git-remote-open"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kurenaif/git-remote-open'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 291c637bc92cf568456711bfbaf22b897f31fbb3 [INFO] sha for GitHub repo kurenaif/git-remote-open: 291c637bc92cf568456711bfbaf22b897f31fbb3 [INFO] validating manifest of kurenaif/git-remote-open on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kurenaif/git-remote-open on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kurenaif/git-remote-open [INFO] finished frobbing kurenaif/git-remote-open [INFO] frobbed toml for kurenaif/git-remote-open written to work/ex/clippy-test-run/sources/stable/gh/kurenaif/git-remote-open/Cargo.toml [INFO] started frobbing kurenaif/git-remote-open [INFO] finished frobbing kurenaif/git-remote-open [INFO] frobbed toml for kurenaif/git-remote-open written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kurenaif/git-remote-open/Cargo.toml [INFO] crate kurenaif/git-remote-open has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kurenaif/git-remote-open against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/kurenaif/git-remote-open:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f1359020d88d7968e0de7d88a7f978594b8c92df91c95b5318b6344b9ef5d882 [INFO] running `"docker" "start" "-a" "f1359020d88d7968e0de7d88a7f978594b8c92df91c95b5318b6344b9ef5d882"` [INFO] [stderr] Checking git-remote-open v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:13:28 [INFO] [stderr] | [INFO] [stderr] 13 | fn status_2_result(status: &ExitStatus, message: &'static str) -> Result { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `ExitStatus` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/main.rs:79:33 [INFO] [stderr] | [INFO] [stderr] 79 | let re = Regex::new(r"\.git$").unwrap(); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivial_regex)] on by default [INFO] [stderr] = help: consider using `str::ends_with` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:13:28 [INFO] [stderr] | [INFO] [stderr] 13 | fn status_2_result(status: &ExitStatus, message: &'static str) -> Result { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `ExitStatus` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/main.rs:79:33 [INFO] [stderr] | [INFO] [stderr] 79 | let re = Regex::new(r"\.git$").unwrap(); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivial_regex)] on by default [INFO] [stderr] = help: consider using `str::ends_with` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:150:9 [INFO] [stderr] | [INFO] [stderr] 150 | open::that(open_url); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:150:9 [INFO] [stderr] | [INFO] [stderr] 150 | open::that(open_url); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.50s [INFO] running `"docker" "inspect" "f1359020d88d7968e0de7d88a7f978594b8c92df91c95b5318b6344b9ef5d882"` [INFO] running `"docker" "rm" "-f" "f1359020d88d7968e0de7d88a7f978594b8c92df91c95b5318b6344b9ef5d882"` [INFO] [stdout] f1359020d88d7968e0de7d88a7f978594b8c92df91c95b5318b6344b9ef5d882