[INFO] updating cached repository kunihiko-t/rust-tree [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kunihiko-t/rust-tree [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kunihiko-t/rust-tree" "work/ex/clippy-test-run/sources/stable/gh/kunihiko-t/rust-tree"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kunihiko-t/rust-tree'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kunihiko-t/rust-tree" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kunihiko-t/rust-tree"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kunihiko-t/rust-tree'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 872a396fdda6f24956f41dcb6eeec2b77d92e578 [INFO] sha for GitHub repo kunihiko-t/rust-tree: 872a396fdda6f24956f41dcb6eeec2b77d92e578 [INFO] validating manifest of kunihiko-t/rust-tree on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kunihiko-t/rust-tree on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kunihiko-t/rust-tree [INFO] finished frobbing kunihiko-t/rust-tree [INFO] frobbed toml for kunihiko-t/rust-tree written to work/ex/clippy-test-run/sources/stable/gh/kunihiko-t/rust-tree/Cargo.toml [INFO] started frobbing kunihiko-t/rust-tree [INFO] finished frobbing kunihiko-t/rust-tree [INFO] frobbed toml for kunihiko-t/rust-tree written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kunihiko-t/rust-tree/Cargo.toml [INFO] crate kunihiko-t/rust-tree has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kunihiko-t/rust-tree against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/kunihiko-t/rust-tree:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a95a3d6bba1f939d025ceac86aad701f16435a8fe2b376f4531f5990dfed08b2 [INFO] running `"docker" "start" "-a" "a95a3d6bba1f939d025ceac86aad701f16435a8fe2b376f4531f5990dfed08b2"` [INFO] [stderr] Checking rust-tree v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:105:36 [INFO] [stderr] | [INFO] [stderr] 105 | print!("{}{}", indent, "└──") [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:107:36 [INFO] [stderr] | [INFO] [stderr] 107 | print!("{}{}", indent, "├──") [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:105:36 [INFO] [stderr] | [INFO] [stderr] 105 | print!("{}{}", indent, "└──") [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:107:36 [INFO] [stderr] | [INFO] [stderr] 107 | print!("{}{}", indent, "├──") [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:61:5 [INFO] [stderr] | [INFO] [stderr] 61 | md [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:54:14 [INFO] [stderr] | [INFO] [stderr] 54 | let md = match f { [INFO] [stderr] | ______________^ [INFO] [stderr] 55 | | Ok(v) => v, [INFO] [stderr] 56 | | Err(e) => { [INFO] [stderr] 57 | | println!("{}", e); [INFO] [stderr] 58 | | process::exit(1); [INFO] [stderr] 59 | | } [INFO] [stderr] 60 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:73:5 [INFO] [stderr] | [INFO] [stderr] 73 | fis [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:66:15 [INFO] [stderr] | [INFO] [stderr] 66 | let fis = match d { [INFO] [stderr] | _______________^ [INFO] [stderr] 67 | | Ok(v) => v, [INFO] [stderr] 68 | | Err(e) => { [INFO] [stderr] 69 | | println!("Could not read directory {}. {}", path.to_str().unwrap(), e); [INFO] [stderr] 70 | | process::exit(1); [INFO] [stderr] 71 | | } [INFO] [stderr] 72 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:98:13 [INFO] [stderr] | [INFO] [stderr] 98 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:61:5 [INFO] [stderr] | [INFO] [stderr] 61 | md [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:54:14 [INFO] [stderr] | [INFO] [stderr] 54 | let md = match f { [INFO] [stderr] | ______________^ [INFO] [stderr] 55 | | Ok(v) => v, [INFO] [stderr] 56 | | Err(e) => { [INFO] [stderr] 57 | | println!("{}", e); [INFO] [stderr] 58 | | process::exit(1); [INFO] [stderr] 59 | | } [INFO] [stderr] 60 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:73:5 [INFO] [stderr] | [INFO] [stderr] 73 | fis [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:66:15 [INFO] [stderr] | [INFO] [stderr] 66 | let fis = match d { [INFO] [stderr] | _______________^ [INFO] [stderr] 67 | | Ok(v) => v, [INFO] [stderr] 68 | | Err(e) => { [INFO] [stderr] 69 | | println!("Could not read directory {}. {}", path.to_str().unwrap(), e); [INFO] [stderr] 70 | | process::exit(1); [INFO] [stderr] 71 | | } [INFO] [stderr] 72 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:98:13 [INFO] [stderr] | [INFO] [stderr] 98 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:90:30 [INFO] [stderr] | [INFO] [stderr] 90 | .starts_with(".") && !flags.show_dot_files [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:90:30 [INFO] [stderr] | [INFO] [stderr] 90 | .starts_with(".") && !flags.show_dot_files [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.29s [INFO] running `"docker" "inspect" "a95a3d6bba1f939d025ceac86aad701f16435a8fe2b376f4531f5990dfed08b2"` [INFO] running `"docker" "rm" "-f" "a95a3d6bba1f939d025ceac86aad701f16435a8fe2b376f4531f5990dfed08b2"` [INFO] [stdout] a95a3d6bba1f939d025ceac86aad701f16435a8fe2b376f4531f5990dfed08b2