[INFO] updating cached repository kumikoda/cryptopals-rust
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/kumikoda/cryptopals-rust
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/kumikoda/cryptopals-rust" "work/ex/clippy-test-run/sources/stable/gh/kumikoda/cryptopals-rust"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kumikoda/cryptopals-rust'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/kumikoda/cryptopals-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kumikoda/cryptopals-rust"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kumikoda/cryptopals-rust'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 83823beadc86fb5192134f30c476b4203ec4a938
[INFO] sha for GitHub repo kumikoda/cryptopals-rust: 83823beadc86fb5192134f30c476b4203ec4a938
[INFO] validating manifest of kumikoda/cryptopals-rust on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of kumikoda/cryptopals-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing kumikoda/cryptopals-rust
[INFO] finished frobbing kumikoda/cryptopals-rust
[INFO] frobbed toml for kumikoda/cryptopals-rust written to work/ex/clippy-test-run/sources/stable/gh/kumikoda/cryptopals-rust/Cargo.toml
[INFO] started frobbing kumikoda/cryptopals-rust
[INFO] finished frobbing kumikoda/cryptopals-rust
[INFO] frobbed toml for kumikoda/cryptopals-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kumikoda/cryptopals-rust/Cargo.toml
[INFO] crate kumikoda/cryptopals-rust has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting kumikoda/cryptopals-rust against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/kumikoda/cryptopals-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 7bc2a7141d07d507536d83f708824a1efbadea87c73bee1c820b73cc82709993
[INFO] running `"docker" "start" "-a" "7bc2a7141d07d507536d83f708824a1efbadea87c73bee1c820b73cc82709993"`
[INFO] [stderr]     Checking cryptopals v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/conversions.rs:35:5
[INFO] [stderr]    |
[INFO] [stderr] 35 |     return b64_bytes;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `b64_bytes`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/conversions.rs:23:37
[INFO] [stderr]    |
[INFO] [stderr] 23 |             b64_bytes.push(((buff & 0b111111000000) >> 6) as u8);
[INFO] [stderr]    |                                     ^^^^^^^^^^^^^^ help: consider: `0b1111_1100_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/conversions.rs:26:36
[INFO] [stderr]    |
[INFO] [stderr] 26 |             b64_bytes.push((buff & 0b000000111111) as u8);
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^ help: consider: `0b0000_0011_1111`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `super::hex_to_base64`
[INFO] [stderr]   --> src/conversions.rs:40:9
[INFO] [stderr]    |
[INFO] [stderr] 40 |     use super::hex_to_base64;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/base64.rs:18:28
[INFO] [stderr]    |
[INFO] [stderr] 18 |             let mut mask = 0b111111000000000000000000;
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b1111_1100_0000_0000_0000_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: operator precedence can trip the unwary
[INFO] [stderr]   --> src/base64.rs:20:30
[INFO] [stderr]    |
[INFO] [stderr] 20 |                 let value = ((buff & mask) >> 18 - n * 6) as u8;
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(buff & mask) >> (18 - n * 6)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::precedence)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/hex.rs:31:5
[INFO] [stderr]    |
[INFO] [stderr] 31 |     return packed_bytes;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `packed_bytes`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/hex.rs:38:38
[INFO] [stderr]    |
[INFO] [stderr] 38 |         encoded.push(encode_one((b & 0b11110000) >> 4));
[INFO] [stderr]    |                                      ^^^^^^^^^^ help: consider: `0b1111_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/hex.rs:39:37
[INFO] [stderr]    |
[INFO] [stderr] 39 |         encoded.push(encode_one(b & 0b00001111));
[INFO] [stderr]    |                                     ^^^^^^^^^^ help: consider: `0b0000_1111`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/crypto.rs:12:5
[INFO] [stderr]    |
[INFO] [stderr] 12 |     return xored;
[INFO] [stderr]    |     ^^^^^^^^^^^^^ help: remove `return` as shown: `xored`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/crypto.rs:22:5
[INFO] [stderr]    |
[INFO] [stderr] 22 |     return xored;
[INFO] [stderr]    |     ^^^^^^^^^^^^^ help: remove `return` as shown: `xored`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/english.rs:46:5
[INFO] [stderr]    |
[INFO] [stderr] 46 |     return cos_sim(freqs, expected);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `cos_sim(freqs, expected)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/english.rs:71:5
[INFO] [stderr]    |
[INFO] [stderr] 71 |     return sum_of_products / (sum_of_a_squares.sqrt() * sum_of_b_squares.sqrt());
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `sum_of_products / (sum_of_a_squares.sqrt() * sum_of_b_squares.sqrt())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/conversions.rs:35:5
[INFO] [stderr]    |
[INFO] [stderr] 35 |     return b64_bytes;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `b64_bytes`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/conversions.rs:23:37
[INFO] [stderr]    |
[INFO] [stderr] 23 |             b64_bytes.push(((buff & 0b111111000000) >> 6) as u8);
[INFO] [stderr]    |                                     ^^^^^^^^^^^^^^ help: consider: `0b1111_1100_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/conversions.rs:26:36
[INFO] [stderr]    |
[INFO] [stderr] 26 |             b64_bytes.push((buff & 0b000000111111) as u8);
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^ help: consider: `0b0000_0011_1111`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/base64.rs:18:28
[INFO] [stderr]    |
[INFO] [stderr] 18 |             let mut mask = 0b111111000000000000000000;
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b1111_1100_0000_0000_0000_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: operator precedence can trip the unwary
[INFO] [stderr]   --> src/base64.rs:20:30
[INFO] [stderr]    |
[INFO] [stderr] 20 |                 let value = ((buff & mask) >> 18 - n * 6) as u8;
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(buff & mask) >> (18 - n * 6)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::precedence)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/hex.rs:31:5
[INFO] [stderr]    |
[INFO] [stderr] 31 |     return packed_bytes;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `packed_bytes`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/hex.rs:38:38
[INFO] [stderr]    |
[INFO] [stderr] 38 |         encoded.push(encode_one((b & 0b11110000) >> 4));
[INFO] [stderr]    |                                      ^^^^^^^^^^ help: consider: `0b1111_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/hex.rs:39:37
[INFO] [stderr]    |
[INFO] [stderr] 39 |         encoded.push(encode_one(b & 0b00001111));
[INFO] [stderr]    |                                     ^^^^^^^^^^ help: consider: `0b0000_1111`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/crypto.rs:12:5
[INFO] [stderr]    |
[INFO] [stderr] 12 |     return xored;
[INFO] [stderr]    |     ^^^^^^^^^^^^^ help: remove `return` as shown: `xored`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/crypto.rs:22:5
[INFO] [stderr]    |
[INFO] [stderr] 22 |     return xored;
[INFO] [stderr]    |     ^^^^^^^^^^^^^ help: remove `return` as shown: `xored`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/english.rs:46:5
[INFO] [stderr]    |
[INFO] [stderr] 46 |     return cos_sim(freqs, expected);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `cos_sim(freqs, expected)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/english.rs:71:5
[INFO] [stderr]    |
[INFO] [stderr] 71 |     return sum_of_products / (sum_of_a_squares.sqrt() * sum_of_b_squares.sqrt());
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `sum_of_products / (sum_of_a_squares.sqrt() * sum_of_b_squares.sqrt())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `i`
[INFO] [stderr]   --> src/hex.rs:37:10
[INFO] [stderr]    |
[INFO] [stderr] 37 |     for (i, &b) in bytes.iter().enumerate() {
[INFO] [stderr]    |          ^ help: consider using `_i` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `i`
[INFO] [stderr]   --> src/english.rs:37:10
[INFO] [stderr]    |
[INFO] [stderr] 37 |     for (i, &c) in s.as_bytes().iter().enumerate() {
[INFO] [stderr]    |          ^ help: consider using `_i` instead
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]  --> src/hex.rs:4:9
[INFO] [stderr]   |
[INFO] [stderr] 4 |     let mut bytes: Vec<u8> = s.as_bytes().to_vec();
[INFO] [stderr]   |         ----^^^^^
[INFO] [stderr]   |         |
[INFO] [stderr]   |         help: remove this `mut`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/conversions.rs:18:17
[INFO] [stderr]    |
[INFO] [stderr] 18 |         buff += hex as u16;
[INFO] [stderr]    |                 ^^^^^^^^^^ help: try: `u16::from(hex)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `i`
[INFO] [stderr]   --> src/hex.rs:37:10
[INFO] [stderr]    |
[INFO] [stderr] 37 |     for (i, &b) in bytes.iter().enumerate() {
[INFO] [stderr]    |          ^ help: consider using `_i` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `i`
[INFO] [stderr]   --> src/english.rs:37:10
[INFO] [stderr]    |
[INFO] [stderr] 37 |     for (i, &c) in s.as_bytes().iter().enumerate() {
[INFO] [stderr]    |          ^ help: consider using `_i` instead
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/base64.rs:15:17
[INFO] [stderr]    |
[INFO] [stderr] 15 |         buff |= b as u32;
[INFO] [stderr]    |                 ^^^^^^^^ help: try: `u32::from(b)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `encoded`.
[INFO] [stderr]   --> src/base64.rs:27:14
[INFO] [stderr]    |
[INFO] [stderr] 27 |     for i in encoded.len() - to_pad..encoded.len() {
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 27 |     for <item> in encoded.iter_mut().skip(encoded.len() - to_pad) {
[INFO] [stderr]    |         ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `bytes`.
[INFO] [stderr]   --> src/crypto.rs:18:14
[INFO] [stderr]    |
[INFO] [stderr] 18 |     for i in 0..bytes.len() {
[INFO] [stderr]    |              ^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 18 |     for <item> in &bytes {
[INFO] [stderr]    |         ^^^^^^    ^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/english.rs:39:28
[INFO] [stderr]    |
[INFO] [stderr] 39 |             b'a'...b'z' => freqs[(c - b'a') as usize] = freqs[(c - b'a') as usize] + 1.0,
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `freqs[(c - b'a') as usize] += 1.0`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/english.rs:40:28
[INFO] [stderr]    |
[INFO] [stderr] 40 |             b'A'...b'Z' => freqs[(c - b'A') as usize] = freqs[(c - b'A') as usize] + 1.0,
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `freqs[(c - b'A') as usize] += 1.0`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/english.rs:41:21
[INFO] [stderr]    |
[INFO] [stderr] 41 |             b' ' => freqs[26] = freqs[26] + 1.0,
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `freqs[26] += 1.0`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/english.rs:42:18
[INFO] [stderr]    |
[INFO] [stderr] 42 |             _ => freqs[27] = freqs[27] + 1.0,
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `freqs[27] += 1.0`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: variable `A` should have a snake case name such as `a`
[INFO] [stderr]   --> src/english.rs:50:16
[INFO] [stderr]    |
[INFO] [stderr] 50 | pub fn cos_sim(A: Vec<f64>, B: Vec<f64>) -> f64 {
[INFO] [stderr]    |                ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(non_snake_case)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variable `B` should have a snake case name such as `b`
[INFO] [stderr]   --> src/english.rs:50:29
[INFO] [stderr]    |
[INFO] [stderr] 50 | pub fn cos_sim(A: Vec<f64>, B: Vec<f64>) -> f64 {
[INFO] [stderr]    |                             ^
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/english.rs:55:8
[INFO] [stderr]    |
[INFO] [stderr] 55 |     if A.len() == 0 {
[INFO] [stderr]    |        ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `A.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/english.rs:66:9
[INFO] [stderr]    |
[INFO] [stderr] 66 |         sum_of_products = sum_of_products + a * b;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sum_of_products += a * b`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/english.rs:67:9
[INFO] [stderr]    |
[INFO] [stderr] 67 |         sum_of_a_squares = sum_of_a_squares + a * a;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sum_of_a_squares += a * a`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/english.rs:68:9
[INFO] [stderr]    |
[INFO] [stderr] 68 |         sum_of_b_squares = sum_of_b_squares + b * b;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sum_of_b_squares += b * b`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]  --> src/hex.rs:4:9
[INFO] [stderr]   |
[INFO] [stderr] 4 |     let mut bytes: Vec<u8> = s.as_bytes().to_vec();
[INFO] [stderr]   |         ----^^^^^
[INFO] [stderr]   |         |
[INFO] [stderr]   |         help: remove this `mut`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/conversions.rs:18:17
[INFO] [stderr]    |
[INFO] [stderr] 18 |         buff += hex as u16;
[INFO] [stderr]    |                 ^^^^^^^^^^ help: try: `u16::from(hex)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/base64.rs:15:17
[INFO] [stderr]    |
[INFO] [stderr] 15 |         buff |= b as u32;
[INFO] [stderr]    |                 ^^^^^^^^ help: try: `u32::from(b)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `encoded`.
[INFO] [stderr]   --> src/base64.rs:27:14
[INFO] [stderr]    |
[INFO] [stderr] 27 |     for i in encoded.len() - to_pad..encoded.len() {
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 27 |     for <item> in encoded.iter_mut().skip(encoded.len() - to_pad) {
[INFO] [stderr]    |         ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]   --> src/hex.rs:60:27
[INFO] [stderr]    |
[INFO] [stderr] 60 |         assert_eq!(bytes, "foobar".as_bytes());
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"foobar"`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::string_lit_as_bytes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `bytes`.
[INFO] [stderr]   --> src/crypto.rs:18:14
[INFO] [stderr]    |
[INFO] [stderr] 18 |     for i in 0..bytes.len() {
[INFO] [stderr]    |              ^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 18 |     for <item> in &bytes {
[INFO] [stderr]    |         ^^^^^^    ^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/english.rs:39:28
[INFO] [stderr]    |
[INFO] [stderr] 39 |             b'a'...b'z' => freqs[(c - b'a') as usize] = freqs[(c - b'a') as usize] + 1.0,
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `freqs[(c - b'a') as usize] += 1.0`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/english.rs:40:28
[INFO] [stderr]    |
[INFO] [stderr] 40 |             b'A'...b'Z' => freqs[(c - b'A') as usize] = freqs[(c - b'A') as usize] + 1.0,
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `freqs[(c - b'A') as usize] += 1.0`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/english.rs:41:21
[INFO] [stderr]    |
[INFO] [stderr] 41 |             b' ' => freqs[26] = freqs[26] + 1.0,
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `freqs[26] += 1.0`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/english.rs:42:18
[INFO] [stderr]    |
[INFO] [stderr] 42 |             _ => freqs[27] = freqs[27] + 1.0,
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `freqs[27] += 1.0`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: variable `A` should have a snake case name such as `a`
[INFO] [stderr]   --> src/english.rs:50:16
[INFO] [stderr]    |
[INFO] [stderr] 50 | pub fn cos_sim(A: Vec<f64>, B: Vec<f64>) -> f64 {
[INFO] [stderr]    |                ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(non_snake_case)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variable `B` should have a snake case name such as `b`
[INFO] [stderr]   --> src/english.rs:50:29
[INFO] [stderr]    |
[INFO] [stderr] 50 | pub fn cos_sim(A: Vec<f64>, B: Vec<f64>) -> f64 {
[INFO] [stderr]    |                             ^
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/english.rs:55:8
[INFO] [stderr]    |
[INFO] [stderr] 55 |     if A.len() == 0 {
[INFO] [stderr]    |        ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `A.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/english.rs:66:9
[INFO] [stderr]    |
[INFO] [stderr] 66 |         sum_of_products = sum_of_products + a * b;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sum_of_products += a * b`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/english.rs:67:9
[INFO] [stderr]    |
[INFO] [stderr] 67 |         sum_of_a_squares = sum_of_a_squares + a * a;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sum_of_a_squares += a * a`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/english.rs:68:9
[INFO] [stderr]    |
[INFO] [stderr] 68 |         sum_of_b_squares = sum_of_b_squares + b * b;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sum_of_b_squares += b * b`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]   --> src/english.rs:85:9
[INFO] [stderr]    |
[INFO] [stderr] 85 |         assert_eq!(sim, 1.0);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::float_cmp)] on by default
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]   --> src/english.rs:85:9
[INFO] [stderr]    |
[INFO] [stderr] 85 |         assert_eq!(sim, 1.0);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]   --> src/english.rs:95:9
[INFO] [stderr]    |
[INFO] [stderr] 95 |         assert_eq!(sim, 0.0);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]   --> src/english.rs:95:9
[INFO] [stderr]    |
[INFO] [stderr] 95 |         assert_eq!(sim, 0.0);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/english.rs:105:9
[INFO] [stderr]     |
[INFO] [stderr] 105 |         assert_eq!(sim, -1.0);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/english.rs:105:9
[INFO] [stderr]     |
[INFO] [stderr] 105 |         assert_eq!(sim, -1.0);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 3 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `cryptopals`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] error: build failed
[INFO] running `"docker" "inspect" "7bc2a7141d07d507536d83f708824a1efbadea87c73bee1c820b73cc82709993"`
[INFO] running `"docker" "rm" "-f" "7bc2a7141d07d507536d83f708824a1efbadea87c73bee1c820b73cc82709993"`
[INFO] [stdout] 7bc2a7141d07d507536d83f708824a1efbadea87c73bee1c820b73cc82709993