[INFO] updating cached repository kumabook/readability-demo [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kumabook/readability-demo [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kumabook/readability-demo" "work/ex/clippy-test-run/sources/stable/gh/kumabook/readability-demo"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kumabook/readability-demo'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kumabook/readability-demo" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kumabook/readability-demo"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kumabook/readability-demo'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] db8f44c38e55668e095f147e94b0c7895232fe90 [INFO] sha for GitHub repo kumabook/readability-demo: db8f44c38e55668e095f147e94b0c7895232fe90 [INFO] validating manifest of kumabook/readability-demo on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kumabook/readability-demo on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kumabook/readability-demo [INFO] finished frobbing kumabook/readability-demo [INFO] frobbed toml for kumabook/readability-demo written to work/ex/clippy-test-run/sources/stable/gh/kumabook/readability-demo/Cargo.toml [INFO] started frobbing kumabook/readability-demo [INFO] finished frobbing kumabook/readability-demo [INFO] frobbed toml for kumabook/readability-demo written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kumabook/readability-demo/Cargo.toml [INFO] crate kumabook/readability-demo has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kumabook/readability-demo against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/kumabook/readability-demo:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 505883962cfe7a76cd86c11f8054e312417c08c2276787e9bbfa372fd3554866 [INFO] running `"docker" "start" "-a" "505883962cfe7a76cd86c11f8054e312417c08c2276787e9bbfa372fd3554866"` [INFO] [stderr] Compiling openssl v0.9.20 [INFO] [stderr] Compiling openssl-sys v0.9.20 [INFO] [stderr] Checking serde_json v0.8.6 [INFO] [stderr] Checking serde_json v1.0.6 [INFO] [stderr] Compiling string_cache_codegen v0.4.0 [INFO] [stderr] Checking hyper v0.10.13 [INFO] [stderr] Compiling serde_derive v1.0.20 [INFO] [stderr] Compiling string_cache v0.6.2 [INFO] [stderr] Compiling markup5ever v0.3.2 [INFO] [stderr] Checking iron v0.5.1 [INFO] [stderr] Checking persistent v0.3.0 [INFO] [stderr] Checking mount v0.3.0 [INFO] [stderr] Checking router v0.5.1 [INFO] [stderr] Checking native-tls v0.1.4 [INFO] [stderr] Checking hyper-native-tls v0.2.4 [INFO] [stderr] Checking staticfile v0.4.0 [INFO] [stderr] Checking html5ever v0.18.0 [INFO] [stderr] Checking bodyparser v0.5.0 [INFO] [stderr] Checking urlencoded v0.5.0 [INFO] [stderr] Checking readability v0.1.2 [INFO] [stderr] Checking readability-demo v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | let ref params = try!(req.get_ref::()); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 61 | let params = &(match $ expr { [INFO] [stderr] 62 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 63 | :: Err ( err ) => { [INFO] [stderr] 64 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 65 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:70:31 [INFO] [stderr] | [INFO] [stderr] 70 | readability2(req).map_err(|err| IronError::from(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `IronError::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | let ref params = try!(req.get_ref::()); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 61 | let params = &(match $ expr { [INFO] [stderr] 62 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 63 | :: Err ( err ) => { [INFO] [stderr] 64 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 65 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:70:31 [INFO] [stderr] | [INFO] [stderr] 70 | readability2(req).map_err(|err| IronError::from(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `IronError::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 25.64s [INFO] running `"docker" "inspect" "505883962cfe7a76cd86c11f8054e312417c08c2276787e9bbfa372fd3554866"` [INFO] running `"docker" "rm" "-f" "505883962cfe7a76cd86c11f8054e312417c08c2276787e9bbfa372fd3554866"` [INFO] [stdout] 505883962cfe7a76cd86c11f8054e312417c08c2276787e9bbfa372fd3554866