[INFO] updating cached repository ktalmadge/Rust-Tracer
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/ktalmadge/Rust-Tracer
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/ktalmadge/Rust-Tracer" "work/ex/clippy-test-run/sources/stable/gh/ktalmadge/Rust-Tracer"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ktalmadge/Rust-Tracer'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/ktalmadge/Rust-Tracer" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ktalmadge/Rust-Tracer"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ktalmadge/Rust-Tracer'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] a50d5dd888aa169b8a4a10327eca453a697cbb98
[INFO] sha for GitHub repo ktalmadge/Rust-Tracer: a50d5dd888aa169b8a4a10327eca453a697cbb98
[INFO] validating manifest of ktalmadge/Rust-Tracer on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of ktalmadge/Rust-Tracer on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing ktalmadge/Rust-Tracer
[INFO] finished frobbing ktalmadge/Rust-Tracer
[INFO] frobbed toml for ktalmadge/Rust-Tracer written to work/ex/clippy-test-run/sources/stable/gh/ktalmadge/Rust-Tracer/Cargo.toml
[INFO] started frobbing ktalmadge/Rust-Tracer
[INFO] finished frobbing ktalmadge/Rust-Tracer
[INFO] frobbed toml for ktalmadge/Rust-Tracer written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ktalmadge/Rust-Tracer/Cargo.toml
[INFO] crate ktalmadge/Rust-Tracer has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting ktalmadge/Rust-Tracer against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ktalmadge/Rust-Tracer:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 08a50e500f5b6bef00ceeaa61714b1c758dd6560788d89ac843a2a9711f612e4
[INFO] running `"docker" "start" "-a" "08a50e500f5b6bef00ceeaa61714b1c758dd6560788d89ac843a2a9711f612e4"`
[INFO] [stderr]     Checking rand v0.3.16
[INFO] [stderr]     Checking num_cpus v1.7.0
[INFO] [stderr]     Checking inflate v0.3.2
[INFO] [stderr]     Checking deflate v0.7.17
[INFO] [stderr]     Checking rayon-core v1.2.1
[INFO] [stderr]     Checking cgmath v0.15.0
[INFO] [stderr]     Checking rayon v0.8.2
[INFO] [stderr]     Checking png v0.10.0
[INFO] [stderr]     Checking jpeg-decoder v0.1.13
[INFO] [stderr]     Checking image v0.16.0
[INFO] [stderr]     Checking raytracer v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]   --> src/ray_tracer/object/triangle/mod.rs:61:13
[INFO] [stderr]    |
[INFO] [stderr] 61 |         let u: f64 = f * s.dot(h);
[INFO] [stderr]    |             ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 6th binding whose name is just one char
[INFO] [stderr]   --> src/ray_tracer/object/triangle/mod.rs:67:13
[INFO] [stderr]    |
[INFO] [stderr] 67 |         let q: Vector3<f64> = s.cross(v1v2);
[INFO] [stderr]    |             ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 7th binding whose name is just one char
[INFO] [stderr]   --> src/ray_tracer/object/triangle/mod.rs:68:13
[INFO] [stderr]    |
[INFO] [stderr] 68 |         let v: f64 = f * ray.direction.dot(q);
[INFO] [stderr]    |             ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 8th binding whose name is just one char
[INFO] [stderr]   --> src/ray_tracer/object/triangle/mod.rs:75:13
[INFO] [stderr]    |
[INFO] [stderr] 75 |         let t: f64 = f * v1v3.dot(q);
[INFO] [stderr]    |             ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]   --> src/ray_tracer/object/triangle/mod.rs:61:13
[INFO] [stderr]    |
[INFO] [stderr] 61 |         let u: f64 = f * s.dot(h);
[INFO] [stderr]    |             ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 6th binding whose name is just one char
[INFO] [stderr]   --> src/ray_tracer/object/triangle/mod.rs:67:13
[INFO] [stderr]    |
[INFO] [stderr] 67 |         let q: Vector3<f64> = s.cross(v1v2);
[INFO] [stderr]    |             ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 7th binding whose name is just one char
[INFO] [stderr]   --> src/ray_tracer/object/triangle/mod.rs:68:13
[INFO] [stderr]    |
[INFO] [stderr] 68 |         let v: f64 = f * ray.direction.dot(q);
[INFO] [stderr]    |             ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 8th binding whose name is just one char
[INFO] [stderr]   --> src/ray_tracer/object/triangle/mod.rs:75:13
[INFO] [stderr]    |
[INFO] [stderr] 75 |         let t: f64 = f * v1v3.dot(q);
[INFO] [stderr]    |             ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: lint name `needless_range_loop` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr]  --> src/ray_tracer/reader/mod.rs:1:45
[INFO] [stderr]   |
[INFO] [stderr] 1 | #![cfg_attr(feature = "cargo-clippy", allow(needless_range_loop))]
[INFO] [stderr]   |                                             ^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_range_loop`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(renamed_and_removed_lints)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: lint name `needless_range_loop` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr] warning: lint name `needless_range_loop` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr]  --> src/ray_tracer/reader/mod.rs:1:45
[INFO] [stderr]   |
[INFO] [stderr] 1 | #![cfg_attr(feature = "cargo-clippy", allow(needless_range_loop))]
[INFO] [stderr]   |                                             ^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_range_loop`
[INFO] [stderr]  --> src/ray_tracer/reader/mod.rs:1:45
[INFO] [stderr]   |
[INFO] [stderr] 1 | #![cfg_attr(feature = "cargo-clippy", allow(needless_range_loop))]
[INFO] [stderr]   |                                             ^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_range_loop`
[INFO] [stderr] 
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(renamed_and_removed_lints)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: lint name `needless_range_loop` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr]  --> src/ray_tracer/reader/mod.rs:1:45
[INFO] [stderr]   |
[INFO] [stderr] 1 | #![cfg_attr(feature = "cargo-clippy", allow(needless_range_loop))]
[INFO] [stderr]   |                                             ^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_range_loop`
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/ray_tracer/ray/mod.rs:33:9
[INFO] [stderr]    |
[INFO] [stderr] 33 |         f64::from((other - self.origin).magnitude())
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `f64::from()`: `(other - self.origin).magnitude()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/ray_tracer/ray/mod.rs:33:9
[INFO] [stderr]    |
[INFO] [stderr] 33 |         f64::from((other - self.origin).magnitude())
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `f64::from()`: `(other - self.origin).magnitude()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/ray_tracer/scene/configuration/mod.rs:42:13
[INFO] [stderr]    |
[INFO] [stderr] 42 |             f64::from(vector[0]),
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: consider removing `f64::from()`: `vector[0]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/ray_tracer/scene/configuration/mod.rs:43:13
[INFO] [stderr]    |
[INFO] [stderr] 43 |             f64::from(vector[1]),
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: consider removing `f64::from()`: `vector[1]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/ray_tracer/scene/configuration/mod.rs:44:13
[INFO] [stderr]    |
[INFO] [stderr] 44 |             f64::from(vector[2]),
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: consider removing `f64::from()`: `vector[2]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `x` is only used to index `color_buffer`.
[INFO] [stderr]   --> src/ray_tracer/tone/mod.rs:11:14
[INFO] [stderr]    |
[INFO] [stderr] 11 |     for x in 0..width {
[INFO] [stderr]    |              ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 11 |     for <item> in color_buffer.iter().take(width) {
[INFO] [stderr]    |         ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `x` is only used to index `color_buffer`.
[INFO] [stderr]   --> src/ray_tracer/tone/mod.rs:28:14
[INFO] [stderr]    |
[INFO] [stderr] 28 |     for x in 0..width {
[INFO] [stderr]    |              ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 28 |     for <item> in color_buffer.iter_mut().take(width) {
[INFO] [stderr]    |         ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `x` is used to index `color_buffer`
[INFO] [stderr]   --> src/ray_tracer/mod.rs:28:14
[INFO] [stderr]    |
[INFO] [stderr] 28 |     for x in 0..width {
[INFO] [stderr]    |              ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 28 |     for (x, <item>) in color_buffer.iter().enumerate().take(width) {
[INFO] [stderr]    |         ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/ray_tracer/scene/configuration/mod.rs:42:13
[INFO] [stderr]    |
[INFO] [stderr] 42 |             f64::from(vector[0]),
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: consider removing `f64::from()`: `vector[0]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/ray_tracer/scene/configuration/mod.rs:43:13
[INFO] [stderr]    |
[INFO] [stderr] 43 |             f64::from(vector[1]),
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: consider removing `f64::from()`: `vector[1]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/ray_tracer/scene/configuration/mod.rs:44:13
[INFO] [stderr]    |
[INFO] [stderr] 44 |             f64::from(vector[2]),
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: consider removing `f64::from()`: `vector[2]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `x` is only used to index `color_buffer`.
[INFO] [stderr]   --> src/ray_tracer/tone/mod.rs:11:14
[INFO] [stderr]    |
[INFO] [stderr] 11 |     for x in 0..width {
[INFO] [stderr]    |              ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 11 |     for <item> in color_buffer.iter().take(width) {
[INFO] [stderr]    |         ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `x` is only used to index `color_buffer`.
[INFO] [stderr]   --> src/ray_tracer/tone/mod.rs:28:14
[INFO] [stderr]    |
[INFO] [stderr] 28 |     for x in 0..width {
[INFO] [stderr]    |              ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 28 |     for <item> in color_buffer.iter_mut().take(width) {
[INFO] [stderr]    |         ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `x` is used to index `color_buffer`
[INFO] [stderr]   --> src/ray_tracer/mod.rs:28:14
[INFO] [stderr]    |
[INFO] [stderr] 28 |     for x in 0..width {
[INFO] [stderr]    |              ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 28 |     for (x, <item>) in color_buffer.iter().enumerate().take(width) {
[INFO] [stderr]    |         ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 19.04s
[INFO] running `"docker" "inspect" "08a50e500f5b6bef00ceeaa61714b1c758dd6560788d89ac843a2a9711f612e4"`
[INFO] running `"docker" "rm" "-f" "08a50e500f5b6bef00ceeaa61714b1c758dd6560788d89ac843a2a9711f612e4"`
[INFO] [stdout] 08a50e500f5b6bef00ceeaa61714b1c758dd6560788d89ac843a2a9711f612e4