[INFO] updating cached repository kryptan/pcx [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kryptan/pcx [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kryptan/pcx" "work/ex/clippy-test-run/sources/stable/gh/kryptan/pcx"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kryptan/pcx'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kryptan/pcx" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kryptan/pcx"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kryptan/pcx'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] bf7c80442b6847683e974ddb4c3fe5e41dca0fc6 [INFO] sha for GitHub repo kryptan/pcx: bf7c80442b6847683e974ddb4c3fe5e41dca0fc6 [INFO] validating manifest of kryptan/pcx on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kryptan/pcx on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kryptan/pcx [INFO] finished frobbing kryptan/pcx [INFO] frobbed toml for kryptan/pcx written to work/ex/clippy-test-run/sources/stable/gh/kryptan/pcx/Cargo.toml [INFO] started frobbing kryptan/pcx [INFO] finished frobbing kryptan/pcx [INFO] frobbed toml for kryptan/pcx written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kryptan/pcx/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kryptan/pcx against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/kryptan/pcx:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8a72b21faf651b723e43ae0f5077b280a31f62d8e55f9ca8e7690255927ca7fe [INFO] running `"docker" "start" "-a" "8a72b21faf651b723e43ae0f5077b280a31f62d8e55f9ca8e7690255927ca7fe"` [INFO] [stderr] Compiling byteorder v1.3.1 [INFO] [stderr] Checking deflate v0.7.19 [INFO] [stderr] Checking pcx v0.2.3 (/opt/crater/workdir) [INFO] [stderr] Checking png v0.12.0 [INFO] [stderr] Checking image v0.20.1 [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/test_samples.rs:18:16 [INFO] [stderr] | [INFO] [stderr] 18 | assert_eq!(pcx.width() as u32, reference_image.width()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(pcx.width())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/test_samples.rs:19:16 [INFO] [stderr] | [INFO] [stderr] 19 | assert_eq!(pcx.height() as u32, reference_image.height()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(pcx.height())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `i * 3` [INFO] [stderr] --> src/test_samples.rs:36:37 [INFO] [stderr] | [INFO] [stderr] 36 | let pcx_r = palette[i * 3 + 0]; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(x as usize) * 3` [INFO] [stderr] --> src/test_samples.rs:62:47 [INFO] [stderr] | [INFO] [stderr] 62 | let pcx_r = image[y as usize][(x as usize) * 3 + 0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.67s [INFO] running `"docker" "inspect" "8a72b21faf651b723e43ae0f5077b280a31f62d8e55f9ca8e7690255927ca7fe"` [INFO] running `"docker" "rm" "-f" "8a72b21faf651b723e43ae0f5077b280a31f62d8e55f9ca8e7690255927ca7fe"` [INFO] [stdout] 8a72b21faf651b723e43ae0f5077b280a31f62d8e55f9ca8e7690255927ca7fe