[INFO] updating cached repository krishnakumar4a4/casync-rs
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/krishnakumar4a4/casync-rs
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/krishnakumar4a4/casync-rs" "work/ex/clippy-test-run/sources/stable/gh/krishnakumar4a4/casync-rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/krishnakumar4a4/casync-rs'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/krishnakumar4a4/casync-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/krishnakumar4a4/casync-rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/krishnakumar4a4/casync-rs'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] c2e2f94b29546e91c9ff737016e9384c2592b434
[INFO] sha for GitHub repo krishnakumar4a4/casync-rs: c2e2f94b29546e91c9ff737016e9384c2592b434
[INFO] validating manifest of krishnakumar4a4/casync-rs on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of krishnakumar4a4/casync-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing krishnakumar4a4/casync-rs
[INFO] finished frobbing krishnakumar4a4/casync-rs
[INFO] frobbed toml for krishnakumar4a4/casync-rs written to work/ex/clippy-test-run/sources/stable/gh/krishnakumar4a4/casync-rs/Cargo.toml
[INFO] started frobbing krishnakumar4a4/casync-rs
[INFO] finished frobbing krishnakumar4a4/casync-rs
[INFO] frobbed toml for krishnakumar4a4/casync-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/krishnakumar4a4/casync-rs/Cargo.toml
[INFO] crate krishnakumar4a4/casync-rs has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting krishnakumar4a4/casync-rs against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/krishnakumar4a4/casync-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 4ad65503bb68d791004f49ecfa4c65822eb019e782495113d091dddcb1e26279
[INFO] running `"docker" "start" "-a" "4ad65503bb68d791004f49ecfa4c65822eb019e782495113d091dddcb1e26279"`
[INFO] [stderr]     Checking fmt-extra v0.1.2
[INFO] [stderr]    Compiling base64 v0.5.2
[INFO] [stderr]     Checking hash-roll v0.2.0
[INFO] [stderr]    Compiling blob v0.2.0
[INFO] [stderr]    Compiling zstd-sys v1.4.4+zstd.1.3.5
[INFO] [stderr]     Checking zstd-safe v1.4.4+zstd.1.3.5
[INFO] [stderr]     Checking zstd v0.4.19+zstd.1.3.5
[INFO] [stderr]     Checking casync-rs v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/chunker/mod.rs:38:13
[INFO] [stderr]    |
[INFO] [stderr] 38 |             input: input,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `input`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: literal with an empty format string
[INFO] [stderr]   --> src/main.rs:49:75
[INFO] [stderr]    |
[INFO] [stderr] 49 |                 println!("Unable to create chunk store at {}, reason {}", "default.cstr", e);
[INFO] [stderr]    |                                                                           ^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::print_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/chunker/mod.rs:38:13
[INFO] [stderr]    |
[INFO] [stderr] 38 |             input: input,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `input`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: literal with an empty format string
[INFO] [stderr]   --> src/main.rs:49:75
[INFO] [stderr]    |
[INFO] [stderr] 49 |                 println!("Unable to create chunk store at {}, reason {}", "default.cstr", e);
[INFO] [stderr]    |                                                                           ^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::print_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/chunker/mod.rs:39:29
[INFO] [stderr]    |
[INFO] [stderr] 39 |             chunk_min_size: 512000,
[INFO] [stderr]    |                             ^^^^^^ help: consider: `512_000`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/chunker/mod.rs:40:29
[INFO] [stderr]    |
[INFO] [stderr] 40 |             chunk_max_size: 1024000,
[INFO] [stderr]    |                             ^^^^^^^ help: consider: `1_024_000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/chunker/mod.rs:63:18
[INFO] [stderr]    |
[INFO] [stderr] 63 |     chunk_size > 512000 && chunk_size < 1024000
[INFO] [stderr]    |                  ^^^^^^ help: consider: `512_000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/chunker/mod.rs:63:41
[INFO] [stderr]    |
[INFO] [stderr] 63 |     chunk_size > 512000 && chunk_size < 1024000
[INFO] [stderr]    |                                         ^^^^^^^ help: consider: `1_024_000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/chunker/mod.rs:39:29
[INFO] [stderr]    |
[INFO] [stderr] 39 |             chunk_min_size: 512000,
[INFO] [stderr]    |                             ^^^^^^ help: consider: `512_000`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/chunker/mod.rs:40:29
[INFO] [stderr]    |
[INFO] [stderr] 40 |             chunk_max_size: 1024000,
[INFO] [stderr]    |                             ^^^^^^^ help: consider: `1_024_000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/chunker/mod.rs:63:18
[INFO] [stderr]    |
[INFO] [stderr] 63 |     chunk_size > 512000 && chunk_size < 1024000
[INFO] [stderr]    |                  ^^^^^^ help: consider: `512_000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/chunker/mod.rs:63:41
[INFO] [stderr]    |
[INFO] [stderr] 63 |     chunk_size > 512000 && chunk_size < 1024000
[INFO] [stderr]    |                                         ^^^^^^^ help: consider: `1_024_000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/chunker/mod.rs:72:29
[INFO] [stderr]    |
[INFO] [stderr] 72 |         chunk_buf.push_back(each_byte.clone());
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `each_byte`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]   --> src/chunker/mod.rs:94:5
[INFO] [stderr]    |
[INFO] [stderr] 94 |     chunk_index_file.write_all(&chunk_hash_bytes);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_must_use)] on by default
[INFO] [stderr]    = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]    --> src/chunker/mod.rs:116:5
[INFO] [stderr]     |
[INFO] [stderr] 116 |     chunk_index_file.write_all(&chunk_size);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]    --> src/chunker/mod.rs:153:12
[INFO] [stderr]     |
[INFO] [stderr] 153 |         if ! (array1[i] == array2[i]) {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `array1[i] != array2[i]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::nonminimal_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]    --> src/chunker/mod.rs:171:5
[INFO] [stderr]     |
[INFO] [stderr] 171 |     io::copy(&mut data.as_slices().0, &mut encoder);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]    --> src/chunker/mod.rs:172:5
[INFO] [stderr]     |
[INFO] [stderr] 172 |     encoder.finish();
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]   --> src/assembler/mod.rs:19:5
[INFO] [stderr]    |
[INFO] [stderr] 19 | /     loop {
[INFO] [stderr] 20 | |         //TODO: Use seek for optimization, instead of read_exact
[INFO] [stderr] 21 | |         // and match_arrays
[INFO] [stderr] 22 | |         match index_file_to_read.read_exact(&mut read_buf) {
[INFO] [stderr] ...  |
[INFO] [stderr] 40 | |         output_file_for_extraction.write_all(&buffer[..]);
[INFO] [stderr] 41 | |     };
[INFO] [stderr]    | |_____^ help: try: `while let Ok(()) = index_file_to_read.read_exact(&mut read_buf) { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]   --> src/assembler/mod.rs:39:9
[INFO] [stderr]    |
[INFO] [stderr] 39 |         io::copy(&mut decoder, &mut buffer);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]   --> src/assembler/mod.rs:40:9
[INFO] [stderr]    |
[INFO] [stderr] 40 |         output_file_for_extraction.write_all(&buffer[..]);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/chunker/mod.rs:72:29
[INFO] [stderr]    |
[INFO] [stderr] 72 |         chunk_buf.push_back(each_byte.clone());
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `each_byte`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]   --> src/chunker/mod.rs:94:5
[INFO] [stderr]    |
[INFO] [stderr] 94 |     chunk_index_file.write_all(&chunk_hash_bytes);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_must_use)] on by default
[INFO] [stderr]    = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]    --> src/chunker/mod.rs:116:5
[INFO] [stderr]     |
[INFO] [stderr] 116 |     chunk_index_file.write_all(&chunk_size);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]    --> src/chunker/mod.rs:153:12
[INFO] [stderr]     |
[INFO] [stderr] 153 |         if ! (array1[i] == array2[i]) {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `array1[i] != array2[i]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::nonminimal_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]    --> src/chunker/mod.rs:171:5
[INFO] [stderr]     |
[INFO] [stderr] 171 |     io::copy(&mut data.as_slices().0, &mut encoder);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]    --> src/chunker/mod.rs:172:5
[INFO] [stderr]     |
[INFO] [stderr] 172 |     encoder.finish();
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]   --> src/assembler/mod.rs:19:5
[INFO] [stderr]    |
[INFO] [stderr] 19 | /     loop {
[INFO] [stderr] 20 | |         //TODO: Use seek for optimization, instead of read_exact
[INFO] [stderr] 21 | |         // and match_arrays
[INFO] [stderr] 22 | |         match index_file_to_read.read_exact(&mut read_buf) {
[INFO] [stderr] ...  |
[INFO] [stderr] 40 | |         output_file_for_extraction.write_all(&buffer[..]);
[INFO] [stderr] 41 | |     };
[INFO] [stderr]    | |_____^ help: try: `while let Ok(()) = index_file_to_read.read_exact(&mut read_buf) { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]   --> src/assembler/mod.rs:39:9
[INFO] [stderr]    |
[INFO] [stderr] 39 |         io::copy(&mut decoder, &mut buffer);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]   --> src/assembler/mod.rs:40:9
[INFO] [stderr]    |
[INFO] [stderr] 40 |         output_file_for_extraction.write_all(&buffer[..]);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 53.93s
[INFO] running `"docker" "inspect" "4ad65503bb68d791004f49ecfa4c65822eb019e782495113d091dddcb1e26279"`
[INFO] running `"docker" "rm" "-f" "4ad65503bb68d791004f49ecfa4c65822eb019e782495113d091dddcb1e26279"`
[INFO] [stdout] 4ad65503bb68d791004f49ecfa4c65822eb019e782495113d091dddcb1e26279