[INFO] updating cached repository krdln/shelly
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/krdln/shelly
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/krdln/shelly" "work/ex/clippy-test-run/sources/stable/gh/krdln/shelly"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/krdln/shelly'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/krdln/shelly" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/krdln/shelly"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/krdln/shelly'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 6471db5e6973b62a070a74c3592ef82b8cf8feb3
[INFO] sha for GitHub repo krdln/shelly: 6471db5e6973b62a070a74c3592ef82b8cf8feb3
[INFO] validating manifest of krdln/shelly on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of krdln/shelly on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing krdln/shelly
[INFO] finished frobbing krdln/shelly
[INFO] frobbed toml for krdln/shelly written to work/ex/clippy-test-run/sources/stable/gh/krdln/shelly/Cargo.toml
[INFO] started frobbing krdln/shelly
[INFO] finished frobbing krdln/shelly
[INFO] frobbed toml for krdln/shelly written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/krdln/shelly/Cargo.toml
[INFO] crate krdln/shelly has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting krdln/shelly against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/krdln/shelly:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 230d560bad47bdc1360b9dda3195fcce762ee71594670bcf0bbfd9bb293e9912
[INFO] running `"docker" "start" "-a" "230d560bad47bdc1360b9dda3195fcce762ee71594670bcf0bbfd9bb293e9912"`
[INFO] [stderr]     Checking toml v0.4.10
[INFO] [stderr]     Checking tempdir v0.3.7
[INFO] [stderr]    Compiling structopt-derive v0.2.14
[INFO] [stderr]    Compiling serde_derive v1.0.81
[INFO] [stderr]     Checking structopt v0.2.14
[INFO] [stderr]     Checking shelly v1.0.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/syntax/v2/stage2.rs:162:42
[INFO] [stderr]     |
[INFO] [stderr] 162 |                 output.push(TT::Symbol { symbol: symbol, span })
[INFO] [stderr]     |                                          ^^^^^^^^^^^^^^ help: replace it with: `symbol`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/syntax/mod.rs:204:25
[INFO] [stderr]     |
[INFO] [stderr] 204 |                         span: span,
[INFO] [stderr]     |                         ^^^^^^^^^^ help: replace it with: `span`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/syntax/v2/stage2.rs:162:42
[INFO] [stderr]     |
[INFO] [stderr] 162 |                 output.push(TT::Symbol { symbol: symbol, span })
[INFO] [stderr]     |                                          ^^^^^^^^^^^^^^ help: replace it with: `symbol`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/syntax/mod.rs:204:25
[INFO] [stderr]     |
[INFO] [stderr] 204 |                         span: span,
[INFO] [stderr]     |                         ^^^^^^^^^^ help: replace it with: `span`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: this looks like an `else if` but the `else` is missing
[INFO] [stderr]   --> src/syntax/v2/muncher.rs:57:10
[INFO] [stderr]    |
[INFO] [stderr] 57 |         } if source.as_bytes().get(start) == Some(&b'\n') {
[INFO] [stderr]    |          ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::suspicious_else_formatting)] on by default
[INFO] [stderr]    = note: to remove this lint, add the missing `else` or add a new line before the second `if`
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/syntax/mod.rs:162:28
[INFO] [stderr]     |
[INFO] [stderr] 162 |                       } else {
[INFO] [stderr]     |  ____________________________^
[INFO] [stderr] 163 | |                         if !v2::ident_is_keyword(&name) && !name.ends_with(".exe") {
[INFO] [stderr] 164 | |                             usages.push(Usage { span, item: Item::function(name) });
[INFO] [stderr] 165 | |                         }
[INFO] [stderr] 166 | |                     }
[INFO] [stderr]     | |_____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 162 |                     } else if !v2::ident_is_keyword(&name) && !name.ends_with(".exe") {
[INFO] [stderr] 163 |     usages.push(Usage { span, item: Item::function(name) });
[INFO] [stderr] 164 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this looks like an `else if` but the `else` is missing
[INFO] [stderr]   --> src/syntax/v2/muncher.rs:57:10
[INFO] [stderr]    |
[INFO] [stderr] 57 |         } if source.as_bytes().get(start) == Some(&b'\n') {
[INFO] [stderr]    |          ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::suspicious_else_formatting)] on by default
[INFO] [stderr]    = note: to remove this lint, add the missing `else` or add a new line before the second `if`
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/syntax/mod.rs:162:28
[INFO] [stderr]     |
[INFO] [stderr] 162 |                       } else {
[INFO] [stderr]     |  ____________________________^
[INFO] [stderr] 163 | |                         if !v2::ident_is_keyword(&name) && !name.ends_with(".exe") {
[INFO] [stderr] 164 | |                             usages.push(Usage { span, item: Item::function(name) });
[INFO] [stderr] 165 | |                         }
[INFO] [stderr] 166 | |                     }
[INFO] [stderr]     | |_____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 162 |                     } else if !v2::ident_is_keyword(&name) && !name.ends_with(".exe") {
[INFO] [stderr] 163 |     usages.push(Usage { span, item: Item::function(name) });
[INFO] [stderr] 164 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lint.rs:119:18
[INFO] [stderr]     |
[INFO] [stderr] 119 |     pub fn level(&self, config: &Config) -> Level {
[INFO] [stderr]     |                  ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lint.rs:124:14
[INFO] [stderr]     |
[INFO] [stderr] 124 |             .unwrap_or(self.default_level());
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.default_level())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against true are unnecessary
[INFO] [stderr]    --> src/lint.rs:329:12
[INFO] [stderr]     |
[INFO] [stderr] 329 |         if self.encountered_lints.insert(message.lint) == true
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `self.encountered_lints.insert(message.lint)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/syntax/v2/muncher.rs:52:1
[INFO] [stderr]    |
[INFO] [stderr] 52 | / fn find_line<'source>(byte_offset: usize, source: &'source str) -> &'source str {
[INFO] [stderr] 53 | |     let mut start = byte_offset as usize;
[INFO] [stderr] 54 | |     loop {
[INFO] [stderr] 55 | |         if start == 0 {
[INFO] [stderr] ...  |
[INFO] [stderr] 63 | |     source[start..].lines().next().unwrap_or("")
[INFO] [stderr] 64 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/syntax/v2/stage1.rs:68:16
[INFO] [stderr]    |
[INFO] [stderr] 68 |     fn closing(&self) -> char {
[INFO] [stderr]    |                ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]    --> src/syntax/v2/stage2.rs:349:36
[INFO] [stderr]     |
[INFO] [stderr] 349 |                               if let Some(_) = stream.peek() {
[INFO] [stderr]     |  _____________________________-      ^^^^^^^
[INFO] [stderr] 350 | |                                 return span.start.error("Variable name expected in {}-block");
[INFO] [stderr] 351 | |                             }
[INFO] [stderr]     | |_____________________________- help: try this: `if stream.peek().is_some()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]    --> src/syntax/mod.rs:155:30
[INFO] [stderr]     |
[INFO] [stderr] 155 |         while let Some(tt) = iter.next() {
[INFO] [stderr]     |                              ^^^^^^^^^^^ help: try: `for tt in iter { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::while_let_on_iterator)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/syntax/mod.rs:156:13
[INFO] [stderr]     |
[INFO] [stderr] 156 | /             match *tt {
[INFO] [stderr] 157 | |                 TT::Cmdlet { span, ident } => {
[INFO] [stderr] 158 | |                     let name = ident.cut_from(source).to_owned();
[INFO] [stderr] 159 | |
[INFO] [stderr] ...   |
[INFO] [stderr] 168 | |                 _ => {}
[INFO] [stderr] 169 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 156 |             if let TT::Cmdlet { span, ident } = *tt {
[INFO] [stderr] 157 |     let name = ident.cut_from(source).to_owned();
[INFO] [stderr] 158 | 
[INFO] [stderr] 159 |     if is_function_definition {
[INFO] [stderr] 160 |         definitions.push(Definition { span, item: Item::function(name) });
[INFO] [stderr] 161 |     } else {
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/syntax/mod.rs:180:9
[INFO] [stderr]     |
[INFO] [stderr] 180 | /         match (stream, delim) {
[INFO] [stderr] 181 | |             // TODO: stop representing class names as "fields".
[INFO] [stderr] 182 | |             (&[TT::Field { span, ident }], Some(v2::Delimiter::Bracket)) => {
[INFO] [stderr] 183 | |                 // This is just a heuristic – not every [<word in brackets>] is necessarily
[INFO] [stderr] ...   |
[INFO] [stderr] 188 | |             _ => {}
[INFO] [stderr] 189 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 180 |         if let (&[TT::Field { span, ident }], Some(v2::Delimiter::Bracket)) = (stream, delim) {
[INFO] [stderr] 181 |     // This is just a heuristic – not every [<word in brackets>] is necessarily
[INFO] [stderr] 182 |     // a class name. But every usage of a class name should be of such form
[INFO] [stderr] 183 |     let name = ident.cut_from(source).to_owned();
[INFO] [stderr] 184 |     usages.push(Usage { span, item: Item::class(name) });
[INFO] [stderr] 185 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/syntax/mod.rs:192:13
[INFO] [stderr]     |
[INFO] [stderr] 192 | /             match window {
[INFO] [stderr] 193 | |                 &[TT::ClassKeyword { .. }, TT::Field { span, ident }] => {
[INFO] [stderr] 194 | |                     let name = ident.cut_from(source).to_owned();
[INFO] [stderr] 195 | |                     definitions.push(Definition { span, item: Item::class(name) });
[INFO] [stderr] ...   |
[INFO] [stderr] 209 | |                 _ => {}
[INFO] [stderr] 210 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 192 |             match *window {
[INFO] [stderr] 193 |                 [TT::ClassKeyword { .. }, TT::Field { span, ident }] => {
[INFO] [stderr] 194 |                     let name = ident.cut_from(source).to_owned();
[INFO] [stderr] 195 |                     definitions.push(Definition { span, item: Item::class(name) });
[INFO] [stderr] 196 |                 }
[INFO] [stderr] 197 | 
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/strictness.rs:25:23
[INFO] [stderr]    |
[INFO] [stderr] 25 |                 span: usage.span.clone()
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `usage.span`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `VecEmitter`
[INFO] [stderr]    --> src/lib.rs:178:5
[INFO] [stderr]     |
[INFO] [stderr] 178 | /     pub fn new() -> VecEmitter {
[INFO] [stderr] 179 | |         VecEmitter { emitted_items: Vec::new() }
[INFO] [stderr] 180 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 173 | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lint.rs:119:18
[INFO] [stderr]     |
[INFO] [stderr] 119 |     pub fn level(&self, config: &Config) -> Level {
[INFO] [stderr]     |                  ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lint.rs:124:14
[INFO] [stderr]     |
[INFO] [stderr] 124 |             .unwrap_or(self.default_level());
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.default_level())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against true are unnecessary
[INFO] [stderr]    --> src/lint.rs:329:12
[INFO] [stderr]     |
[INFO] [stderr] 329 |         if self.encountered_lints.insert(message.lint) == true
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `self.encountered_lints.insert(message.lint)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/syntax/v2/muncher.rs:52:1
[INFO] [stderr]    |
[INFO] [stderr] 52 | / fn find_line<'source>(byte_offset: usize, source: &'source str) -> &'source str {
[INFO] [stderr] 53 | |     let mut start = byte_offset as usize;
[INFO] [stderr] 54 | |     loop {
[INFO] [stderr] 55 | |         if start == 0 {
[INFO] [stderr] ...  |
[INFO] [stderr] 63 | |     source[start..].lines().next().unwrap_or("")
[INFO] [stderr] 64 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/syntax/v2/stage1.rs:68:16
[INFO] [stderr]    |
[INFO] [stderr] 68 |     fn closing(&self) -> char {
[INFO] [stderr]    |                ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]    --> src/syntax/v2/stage2.rs:349:36
[INFO] [stderr]     |
[INFO] [stderr] 349 |                               if let Some(_) = stream.peek() {
[INFO] [stderr]     |  _____________________________-      ^^^^^^^
[INFO] [stderr] 350 | |                                 return span.start.error("Variable name expected in {}-block");
[INFO] [stderr] 351 | |                             }
[INFO] [stderr]     | |_____________________________- help: try this: `if stream.peek().is_some()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]    --> src/syntax/mod.rs:155:30
[INFO] [stderr]     |
[INFO] [stderr] 155 |         while let Some(tt) = iter.next() {
[INFO] [stderr]     |                              ^^^^^^^^^^^ help: try: `for tt in iter { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::while_let_on_iterator)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/syntax/mod.rs:156:13
[INFO] [stderr]     |
[INFO] [stderr] 156 | /             match *tt {
[INFO] [stderr] 157 | |                 TT::Cmdlet { span, ident } => {
[INFO] [stderr] 158 | |                     let name = ident.cut_from(source).to_owned();
[INFO] [stderr] 159 | |
[INFO] [stderr] ...   |
[INFO] [stderr] 168 | |                 _ => {}
[INFO] [stderr] 169 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 156 |             if let TT::Cmdlet { span, ident } = *tt {
[INFO] [stderr] 157 |     let name = ident.cut_from(source).to_owned();
[INFO] [stderr] 158 | 
[INFO] [stderr] 159 |     if is_function_definition {
[INFO] [stderr] 160 |         definitions.push(Definition { span, item: Item::function(name) });
[INFO] [stderr] 161 |     } else {
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/syntax/mod.rs:180:9
[INFO] [stderr]     |
[INFO] [stderr] 180 | /         match (stream, delim) {
[INFO] [stderr] 181 | |             // TODO: stop representing class names as "fields".
[INFO] [stderr] 182 | |             (&[TT::Field { span, ident }], Some(v2::Delimiter::Bracket)) => {
[INFO] [stderr] 183 | |                 // This is just a heuristic – not every [<word in brackets>] is necessarily
[INFO] [stderr] ...   |
[INFO] [stderr] 188 | |             _ => {}
[INFO] [stderr] 189 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 180 |         if let (&[TT::Field { span, ident }], Some(v2::Delimiter::Bracket)) = (stream, delim) {
[INFO] [stderr] 181 |     // This is just a heuristic – not every [<word in brackets>] is necessarily
[INFO] [stderr] 182 |     // a class name. But every usage of a class name should be of such form
[INFO] [stderr] 183 |     let name = ident.cut_from(source).to_owned();
[INFO] [stderr] 184 |     usages.push(Usage { span, item: Item::class(name) });
[INFO] [stderr] 185 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/syntax/mod.rs:192:13
[INFO] [stderr]     |
[INFO] [stderr] 192 | /             match window {
[INFO] [stderr] 193 | |                 &[TT::ClassKeyword { .. }, TT::Field { span, ident }] => {
[INFO] [stderr] 194 | |                     let name = ident.cut_from(source).to_owned();
[INFO] [stderr] 195 | |                     definitions.push(Definition { span, item: Item::class(name) });
[INFO] [stderr] ...   |
[INFO] [stderr] 209 | |                 _ => {}
[INFO] [stderr] 210 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 192 |             match *window {
[INFO] [stderr] 193 |                 [TT::ClassKeyword { .. }, TT::Field { span, ident }] => {
[INFO] [stderr] 194 |                     let name = ident.cut_from(source).to_owned();
[INFO] [stderr] 195 |                     definitions.push(Definition { span, item: Item::class(name) });
[INFO] [stderr] 196 |                 }
[INFO] [stderr] 197 | 
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/strictness.rs:25:23
[INFO] [stderr]    |
[INFO] [stderr] 25 |                 span: usage.span.clone()
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `usage.span`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `VecEmitter`
[INFO] [stderr]    --> src/lib.rs:178:5
[INFO] [stderr]     |
[INFO] [stderr] 178 | /     pub fn new() -> VecEmitter {
[INFO] [stderr] 179 | |         VecEmitter { emitted_items: Vec::new() }
[INFO] [stderr] 180 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 173 | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unused `#[macro_use]` import
[INFO] [stderr]   --> src/main.rs:14:1
[INFO] [stderr]    |
[INFO] [stderr] 14 | #[macro_use]
[INFO] [stderr]    | ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused `#[macro_use]` import
[INFO] [stderr]   --> src/main.rs:14:1
[INFO] [stderr]    |
[INFO] [stderr] 14 | #[macro_use]
[INFO] [stderr]    | ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'failure::Error::causes': please use the 'iter_chain()' method instead
[INFO] [stderr]    --> src/main.rs:112:24
[INFO] [stderr]     |
[INFO] [stderr] 112 |         for cause in e.causes() {
[INFO] [stderr]     |                        ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'failure::Error::causes': please use the 'iter_chain()' method instead
[INFO] [stderr]    --> src/main.rs:112:24
[INFO] [stderr]     |
[INFO] [stderr] 112 |         for cause in e.causes() {
[INFO] [stderr]     |                        ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 24.31s
[INFO] running `"docker" "inspect" "230d560bad47bdc1360b9dda3195fcce762ee71594670bcf0bbfd9bb293e9912"`
[INFO] running `"docker" "rm" "-f" "230d560bad47bdc1360b9dda3195fcce762ee71594670bcf0bbfd9bb293e9912"`
[INFO] [stdout] 230d560bad47bdc1360b9dda3195fcce762ee71594670bcf0bbfd9bb293e9912