[INFO] updating cached repository krdln/rustnightlyhash [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/krdln/rustnightlyhash [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/krdln/rustnightlyhash" "work/ex/clippy-test-run/sources/stable/gh/krdln/rustnightlyhash"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/krdln/rustnightlyhash'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/krdln/rustnightlyhash" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/krdln/rustnightlyhash"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/krdln/rustnightlyhash'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 50a6c8dc1f0f5f09e539a1768274fd6df0010c47 [INFO] sha for GitHub repo krdln/rustnightlyhash: 50a6c8dc1f0f5f09e539a1768274fd6df0010c47 [INFO] validating manifest of krdln/rustnightlyhash on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of krdln/rustnightlyhash on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing krdln/rustnightlyhash [INFO] finished frobbing krdln/rustnightlyhash [INFO] frobbed toml for krdln/rustnightlyhash written to work/ex/clippy-test-run/sources/stable/gh/krdln/rustnightlyhash/Cargo.toml [INFO] started frobbing krdln/rustnightlyhash [INFO] finished frobbing krdln/rustnightlyhash [INFO] frobbed toml for krdln/rustnightlyhash written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/krdln/rustnightlyhash/Cargo.toml [INFO] crate krdln/rustnightlyhash has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting krdln/rustnightlyhash against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/krdln/rustnightlyhash:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 653cf683b07c7e4cfbbc9a20c50db58f692aef38ecf4f5f698c7d61aa652c0b4 [INFO] running `"docker" "start" "-a" "653cf683b07c7e4cfbbc9a20c50db58f692aef38ecf4f5f698c7d61aa652c0b4"` [INFO] [stderr] Compiling openssl v0.9.9 [INFO] [stderr] Compiling openssl-sys v0.9.9 [INFO] [stderr] Checking serde_json v0.9.9 [INFO] [stderr] Checking aho-corasick v0.6.3 [INFO] [stderr] Checking hyper v0.10.5 [INFO] [stderr] Checking regex v0.2.1 [INFO] [stderr] Checking docopt v0.7.0 [INFO] [stderr] Checking native-tls v0.1.1 [INFO] [stderr] Checking hyper-native-tls v0.2.2 [INFO] [stderr] Checking rustnightlyhash v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:43:15 [INFO] [stderr] | [INFO] [stderr] 43 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:43:15 [INFO] [stderr] | [INFO] [stderr] 43 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | / match p.get(0).and_then(Json::as_str) { [INFO] [stderr] 36 | | Some("revision") => return Some((tryo!( p.get(1).and_then(Json::as_str).map(Into::into) ), tm)), [INFO] [stderr] 37 | | _ => () [INFO] [stderr] 38 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some("revision") = p.get(0).and_then(Json::as_str) { return Some((tryo!( p.get(1).and_then(Json::as_str).map(Into::into) ), tm)) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:95:17 [INFO] [stderr] | [INFO] [stderr] 95 | assert!(range.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!range.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | / match p.get(0).and_then(Json::as_str) { [INFO] [stderr] 36 | | Some("revision") => return Some((tryo!( p.get(1).and_then(Json::as_str).map(Into::into) ), tm)), [INFO] [stderr] 37 | | _ => () [INFO] [stderr] 38 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some("revision") = p.get(0).and_then(Json::as_str) { return Some((tryo!( p.get(1).and_then(Json::as_str).map(Into::into) ), tm)) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:95:17 [INFO] [stderr] | [INFO] [stderr] 95 | assert!(range.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!range.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 15.94s [INFO] running `"docker" "inspect" "653cf683b07c7e4cfbbc9a20c50db58f692aef38ecf4f5f698c7d61aa652c0b4"` [INFO] running `"docker" "rm" "-f" "653cf683b07c7e4cfbbc9a20c50db58f692aef38ecf4f5f698c7d61aa652c0b4"` [INFO] [stdout] 653cf683b07c7e4cfbbc9a20c50db58f692aef38ecf4f5f698c7d61aa652c0b4