[INFO] updating cached repository kprav33n/aoc18.rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kprav33n/aoc18.rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kprav33n/aoc18.rs" "work/ex/clippy-test-run/sources/stable/gh/kprav33n/aoc18.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kprav33n/aoc18.rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kprav33n/aoc18.rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kprav33n/aoc18.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kprav33n/aoc18.rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 84d7f47b5cfea1710a280890d304d39ec1a63992 [INFO] sha for GitHub repo kprav33n/aoc18.rs: 84d7f47b5cfea1710a280890d304d39ec1a63992 [INFO] validating manifest of kprav33n/aoc18.rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kprav33n/aoc18.rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kprav33n/aoc18.rs [INFO] finished frobbing kprav33n/aoc18.rs [INFO] frobbed toml for kprav33n/aoc18.rs written to work/ex/clippy-test-run/sources/stable/gh/kprav33n/aoc18.rs/Cargo.toml [INFO] started frobbing kprav33n/aoc18.rs [INFO] finished frobbing kprav33n/aoc18.rs [INFO] frobbed toml for kprav33n/aoc18.rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kprav33n/aoc18.rs/Cargo.toml [INFO] crate kprav33n/aoc18.rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kprav33n/aoc18.rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/kprav33n/aoc18.rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 248a6b49398b16f671ae8db78f5839ac71cba6d7763a596658da877a3b664ac4 [INFO] running `"docker" "start" "-a" "248a6b49398b16f671ae8db78f5839ac71cba6d7763a596658da877a3b664ac4"` [INFO] [stderr] Checking nom v4.1.1 [INFO] [stderr] Checking aoc18 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/day10.rs:61:17 [INFO] [stderr] | [INFO] [stderr] 61 | for i in 0..100000 { [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/day04.rs:347:55 [INFO] [stderr] | [INFO] [stderr] 347 | chrono::NaiveDate::from_ymd(1518, 11, 01).and_hms(23, 58, 0) [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_prefixed_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 347 | chrono::NaiveDate::from_ymd(1518, 11, 1).and_hms(23, 58, 0) [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 347 | chrono::NaiveDate::from_ymd(1518, 11, 0o1).and_hms(23, 58, 0) [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/day10.rs:61:17 [INFO] [stderr] | [INFO] [stderr] 61 | for i in 0..100000 { [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: This binary expression can be simplified [INFO] [stderr] --> src/day04.rs:205:1 [INFO] [stderr] | [INFO] [stderr] 205 | / named!( [INFO] [stderr] 206 | | time<&str, DateTime>, [INFO] [stderr] 207 | | map_res!( [INFO] [stderr] 208 | | take_while_m_n!(16, 16, |_| true), [INFO] [stderr] 209 | | |s: &str| DateTime::parse_from_str(s, "%Y-%m-%d %H:%M") [INFO] [stderr] 210 | | ) [INFO] [stderr] 211 | | ); [INFO] [stderr] | |__^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_comparisons)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_comparisons [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `plane` [INFO] [stderr] --> src/day06.rs:29:18 [INFO] [stderr] | [INFO] [stderr] 29 | for j in 0..BOUND { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 29 | for (j, ) in plane.iter_mut().enumerate().take(BOUND) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `plane`. [INFO] [stderr] --> src/day06.rs:55:18 [INFO] [stderr] | [INFO] [stderr] 55 | for j in 0..BOUND { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 55 | for in plane.iter_mut().take(BOUND) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `plane` [INFO] [stderr] --> src/day06.rs:92:18 [INFO] [stderr] | [INFO] [stderr] 92 | for j in 0..BOUND { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 92 | for (j, ) in plane.iter_mut().enumerate().take(BOUND) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `plane`. [INFO] [stderr] --> src/day06.rs:106:14 [INFO] [stderr] | [INFO] [stderr] 106 | for i in 0..BOUND { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 106 | for in plane.iter().take(BOUND) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/day07.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | / for _ in deps.neighbors_directed(n, petgraph::Incoming) { [INFO] [stderr] 40 | | continue 'outer; [INFO] [stderr] 41 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/day07.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | / for _ in deps.neighbors_directed(r.1, petgraph::Incoming) { [INFO] [stderr] 59 | | continue 'removal; [INFO] [stderr] 60 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/day07.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | / for _ in deps.neighbors_directed(n, petgraph::Incoming) { [INFO] [stderr] 105 | | continue 'outer; [INFO] [stderr] 106 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/day07.rs:131:25 [INFO] [stderr] | [INFO] [stderr] 131 | / for _ in deps.neighbors_directed(r.1, petgraph::Incoming) { [INFO] [stderr] 132 | | continue 'removal; [INFO] [stderr] 133 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/day07.rs:175:5 [INFO] [stderr] | [INFO] [stderr] 175 | / fn new(size: usize, factor: usize) -> (mpsc::Sender, mpsc::Receiver<(char, usize)>) { [INFO] [stderr] 176 | | let (tx_in, rx_in) = mpsc::channel(); [INFO] [stderr] 177 | | let (tx_out, rx_out) = mpsc::channel(); [INFO] [stderr] 178 | | let mut crew = Crew { [INFO] [stderr] ... | [INFO] [stderr] 196 | | (tx_in, rx_out) [INFO] [stderr] 197 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day10.rs:47:16 [INFO] [stderr] | [INFO] [stderr] 47 | .split("\n") [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day10.rs:90:28 [INFO] [stderr] | [INFO] [stderr] 90 | fn entries_bounds(entries: &Vec) -> (i64, i64, i64, i64) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Entry]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day10.rs:104:26 [INFO] [stderr] | [INFO] [stderr] 104 | fn plot_entries(entries: &Vec, min_x: i64, min_y: i64, max_x: i64, max_y: i64) -> String { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Entry]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/day10.rs:112:5 [INFO] [stderr] | [INFO] [stderr] 112 | / bitmap [INFO] [stderr] 113 | | .iter() [INFO] [stderr] 114 | | .map(|v| v.into_iter().collect::() + "\n") [INFO] [stderr] 115 | | .into_iter() [INFO] [stderr] | |____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into_iter()` [INFO] [stderr] | [INFO] [stderr] 112 | bitmap [INFO] [stderr] 113 | .iter() [INFO] [stderr] 114 | .map(|v| v.into_iter().collect::() + "\n") [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/day10.rs:114:20 [INFO] [stderr] | [INFO] [stderr] 114 | .map(|v| v.into_iter().collect::() + "\n") [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: the loop variable `x` is used to index `grid` [INFO] [stderr] --> src/day11.rs:17:14 [INFO] [stderr] | [INFO] [stderr] 17 | for x in 0..SIZE { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 17 | for (x, ) in grid.iter_mut().enumerate().take(SIZE) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `x` is used to index `grid` [INFO] [stderr] --> src/day11.rs:67:14 [INFO] [stderr] | [INFO] [stderr] 67 | for x in 0..SIZE { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 67 | for (x, ) in grid.iter_mut().enumerate().take(SIZE) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `aoc18`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: This binary expression can be simplified [INFO] [stderr] --> src/day04.rs:205:1 [INFO] [stderr] | [INFO] [stderr] 205 | / named!( [INFO] [stderr] 206 | | time<&str, DateTime>, [INFO] [stderr] 207 | | map_res!( [INFO] [stderr] 208 | | take_while_m_n!(16, 16, |_| true), [INFO] [stderr] 209 | | |s: &str| DateTime::parse_from_str(s, "%Y-%m-%d %H:%M") [INFO] [stderr] 210 | | ) [INFO] [stderr] 211 | | ); [INFO] [stderr] | |__^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_comparisons)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_comparisons [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `plane` [INFO] [stderr] --> src/day06.rs:29:18 [INFO] [stderr] | [INFO] [stderr] 29 | for j in 0..BOUND { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 29 | for (j, ) in plane.iter_mut().enumerate().take(BOUND) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `plane`. [INFO] [stderr] --> src/day06.rs:55:18 [INFO] [stderr] | [INFO] [stderr] 55 | for j in 0..BOUND { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 55 | for in plane.iter_mut().take(BOUND) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `plane` [INFO] [stderr] --> src/day06.rs:92:18 [INFO] [stderr] | [INFO] [stderr] 92 | for j in 0..BOUND { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 92 | for (j, ) in plane.iter_mut().enumerate().take(BOUND) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `plane`. [INFO] [stderr] --> src/day06.rs:106:14 [INFO] [stderr] | [INFO] [stderr] 106 | for i in 0..BOUND { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 106 | for in plane.iter().take(BOUND) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/day07.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | / for _ in deps.neighbors_directed(n, petgraph::Incoming) { [INFO] [stderr] 40 | | continue 'outer; [INFO] [stderr] 41 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/day07.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | / for _ in deps.neighbors_directed(r.1, petgraph::Incoming) { [INFO] [stderr] 59 | | continue 'removal; [INFO] [stderr] 60 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/day07.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | / for _ in deps.neighbors_directed(n, petgraph::Incoming) { [INFO] [stderr] 105 | | continue 'outer; [INFO] [stderr] 106 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/day07.rs:131:25 [INFO] [stderr] | [INFO] [stderr] 131 | / for _ in deps.neighbors_directed(r.1, petgraph::Incoming) { [INFO] [stderr] 132 | | continue 'removal; [INFO] [stderr] 133 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/day07.rs:175:5 [INFO] [stderr] | [INFO] [stderr] 175 | / fn new(size: usize, factor: usize) -> (mpsc::Sender, mpsc::Receiver<(char, usize)>) { [INFO] [stderr] 176 | | let (tx_in, rx_in) = mpsc::channel(); [INFO] [stderr] 177 | | let (tx_out, rx_out) = mpsc::channel(); [INFO] [stderr] 178 | | let mut crew = Crew { [INFO] [stderr] ... | [INFO] [stderr] 196 | | (tx_in, rx_out) [INFO] [stderr] 197 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day10.rs:47:16 [INFO] [stderr] | [INFO] [stderr] 47 | .split("\n") [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day10.rs:90:28 [INFO] [stderr] | [INFO] [stderr] 90 | fn entries_bounds(entries: &Vec) -> (i64, i64, i64, i64) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Entry]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day10.rs:104:26 [INFO] [stderr] | [INFO] [stderr] 104 | fn plot_entries(entries: &Vec, min_x: i64, min_y: i64, max_x: i64, max_y: i64) -> String { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Entry]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/day10.rs:112:5 [INFO] [stderr] | [INFO] [stderr] 112 | / bitmap [INFO] [stderr] 113 | | .iter() [INFO] [stderr] 114 | | .map(|v| v.into_iter().collect::() + "\n") [INFO] [stderr] 115 | | .into_iter() [INFO] [stderr] | |____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into_iter()` [INFO] [stderr] | [INFO] [stderr] 112 | bitmap [INFO] [stderr] 113 | .iter() [INFO] [stderr] 114 | .map(|v| v.into_iter().collect::() + "\n") [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/day10.rs:114:20 [INFO] [stderr] | [INFO] [stderr] 114 | .map(|v| v.into_iter().collect::() + "\n") [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: the loop variable `x` is used to index `grid` [INFO] [stderr] --> src/day11.rs:17:14 [INFO] [stderr] | [INFO] [stderr] 17 | for x in 0..SIZE { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 17 | for (x, ) in grid.iter_mut().enumerate().take(SIZE) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `x` is used to index `grid` [INFO] [stderr] --> src/day11.rs:67:14 [INFO] [stderr] | [INFO] [stderr] 67 | for x in 0..SIZE { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 67 | for (x, ) in grid.iter_mut().enumerate().take(SIZE) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `aoc18`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "248a6b49398b16f671ae8db78f5839ac71cba6d7763a596658da877a3b664ac4"` [INFO] running `"docker" "rm" "-f" "248a6b49398b16f671ae8db78f5839ac71cba6d7763a596658da877a3b664ac4"` [INFO] [stdout] 248a6b49398b16f671ae8db78f5839ac71cba6d7763a596658da877a3b664ac4