[INFO] updating cached repository kpcyrd/rshijack [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kpcyrd/rshijack [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kpcyrd/rshijack" "work/ex/clippy-test-run/sources/stable/gh/kpcyrd/rshijack"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kpcyrd/rshijack'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kpcyrd/rshijack" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kpcyrd/rshijack"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kpcyrd/rshijack'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 602a08b13eb0d60b0558a34a87fe084d5f5f360c [INFO] sha for GitHub repo kpcyrd/rshijack: 602a08b13eb0d60b0558a34a87fe084d5f5f360c [INFO] validating manifest of kpcyrd/rshijack on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kpcyrd/rshijack on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kpcyrd/rshijack [INFO] finished frobbing kpcyrd/rshijack [INFO] frobbed toml for kpcyrd/rshijack written to work/ex/clippy-test-run/sources/stable/gh/kpcyrd/rshijack/Cargo.toml [INFO] started frobbing kpcyrd/rshijack [INFO] finished frobbing kpcyrd/rshijack [INFO] frobbed toml for kpcyrd/rshijack written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kpcyrd/rshijack/Cargo.toml [INFO] crate kpcyrd/rshijack has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kpcyrd/rshijack against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/kpcyrd/rshijack:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fcdc4d11dc1d55a66e544821cfbdc692e8985ac71366cb96e3bfaf7450635caf [INFO] running `"docker" "start" "-a" "fcdc4d11dc1d55a66e544821cfbdc692e8985ac71366cb96e3bfaf7450635caf"` [INFO] [stderr] Compiling memchr v2.0.1 [INFO] [stderr] Compiling regex-syntax v0.5.3 [INFO] [stderr] Checking pnet_sys v0.21.0 [INFO] [stderr] Checking memchr v1.0.2 [INFO] [stderr] Compiling syntex_errors v0.42.0 [INFO] [stderr] Checking env_logger v0.5.6 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Checking pnet_datalink v0.21.0 [INFO] [stderr] Checking nom v3.2.1 [INFO] [stderr] Compiling aho-corasick v0.6.4 [INFO] [stderr] Compiling syntex_syntax v0.42.0 [INFO] [stderr] Checking pktparse v0.2.2 [INFO] [stderr] Compiling regex v0.2.10 [INFO] [stderr] Compiling syntex v0.42.2 [INFO] [stderr] Compiling pnet_macros v0.21.0 [INFO] [stderr] Compiling pnet_packet v0.21.0 [INFO] [stderr] Checking pnet_transport v0.21.0 [INFO] [stderr] Checking pnet v0.21.0 [INFO] [stderr] Checking rshijack v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/net.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | (*self.seq.lock().unwrap()).clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `(*self.seq.lock().unwrap())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/net.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | (*self.ack.lock().unwrap()).clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `(*self.ack.lock().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/net.rs:132:9 [INFO] [stderr] | [INFO] [stderr] 132 | stdout.write(remaining).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/net.rs:145:21 [INFO] [stderr] | [INFO] [stderr] 145 | let interface = interfaces.into_iter() [INFO] [stderr] | _____________________^ [INFO] [stderr] 146 | | .filter(|iface: &NetworkInterface| iface.name == interface) [INFO] [stderr] 147 | | .next() [INFO] [stderr] | |_______________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|iface: &NetworkInterface| iface.name == interface).next()` with `find(|iface: &NetworkInterface| iface.name == interface)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/net.rs:162:13 [INFO] [stderr] | [INFO] [stderr] 162 | / match eth_frame.ethertype { [INFO] [stderr] 163 | | ethernet::EtherType::IPv4 => { [INFO] [stderr] 164 | | if let Done(remaining, ip_hdr) = ipv4::parse_ipv4_header(remaining) { [INFO] [stderr] 165 | | log!(log_level, "ip4: {:?}", ip_hdr); [INFO] [stderr] ... | [INFO] [stderr] 188 | | _ => (), [INFO] [stderr] 189 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 162 | if let ethernet::EtherType::IPv4 = eth_frame.ethertype { [INFO] [stderr] 163 | if let Done(remaining, ip_hdr) = ipv4::parse_ipv4_header(remaining) { [INFO] [stderr] 164 | log!(log_level, "ip4: {:?}", ip_hdr); [INFO] [stderr] 165 | [INFO] [stderr] 166 | // skip packet if src/dst ip doesn't match [INFO] [stderr] 167 | if *src.ip() != ip_hdr.source_addr || [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/net.rs:173:25 [INFO] [stderr] | [INFO] [stderr] 173 | / match ip_hdr.protocol { [INFO] [stderr] 174 | | ipv4::IPv4Protocol::TCP => { [INFO] [stderr] 175 | | [INFO] [stderr] 176 | | if let Done(remaining, tcp_hdr) = tcp::parse_tcp_header(remaining) { [INFO] [stderr] ... | [INFO] [stderr] 184 | | _ => (), [INFO] [stderr] 185 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 173 | if let ipv4::IPv4Protocol::TCP = ip_hdr.protocol { [INFO] [stderr] 174 | [INFO] [stderr] 175 | if let Done(remaining, tcp_hdr) = tcp::parse_tcp_header(remaining) { [INFO] [stderr] 176 | log!(log_level, "tcp: {:?}", tcp_hdr); [INFO] [stderr] 177 | [INFO] [stderr] 178 | if let Some(result) = callback(ip_hdr, tcp_hdr, remaining)? { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/net.rs:254:39 [INFO] [stderr] | [INFO] [stderr] 254 | match tx.send_to(ipv4, IpAddr::V4(dst.ip().clone())) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*dst.ip()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:64:19 [INFO] [stderr] | [INFO] [stderr] 64 | let dst = connection.src.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `connection.src` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:65:19 [INFO] [stderr] | [INFO] [stderr] 65 | let src = connection.dst.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `connection.dst` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rshijack`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/net.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | (*self.seq.lock().unwrap()).clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `(*self.seq.lock().unwrap())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/net.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | (*self.ack.lock().unwrap()).clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `(*self.ack.lock().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/net.rs:132:9 [INFO] [stderr] | [INFO] [stderr] 132 | stdout.write(remaining).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/net.rs:145:21 [INFO] [stderr] | [INFO] [stderr] 145 | let interface = interfaces.into_iter() [INFO] [stderr] | _____________________^ [INFO] [stderr] 146 | | .filter(|iface: &NetworkInterface| iface.name == interface) [INFO] [stderr] 147 | | .next() [INFO] [stderr] | |_______________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|iface: &NetworkInterface| iface.name == interface).next()` with `find(|iface: &NetworkInterface| iface.name == interface)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/net.rs:162:13 [INFO] [stderr] | [INFO] [stderr] 162 | / match eth_frame.ethertype { [INFO] [stderr] 163 | | ethernet::EtherType::IPv4 => { [INFO] [stderr] 164 | | if let Done(remaining, ip_hdr) = ipv4::parse_ipv4_header(remaining) { [INFO] [stderr] 165 | | log!(log_level, "ip4: {:?}", ip_hdr); [INFO] [stderr] ... | [INFO] [stderr] 188 | | _ => (), [INFO] [stderr] 189 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 162 | if let ethernet::EtherType::IPv4 = eth_frame.ethertype { [INFO] [stderr] 163 | if let Done(remaining, ip_hdr) = ipv4::parse_ipv4_header(remaining) { [INFO] [stderr] 164 | log!(log_level, "ip4: {:?}", ip_hdr); [INFO] [stderr] 165 | [INFO] [stderr] 166 | // skip packet if src/dst ip doesn't match [INFO] [stderr] 167 | if *src.ip() != ip_hdr.source_addr || [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/net.rs:173:25 [INFO] [stderr] | [INFO] [stderr] 173 | / match ip_hdr.protocol { [INFO] [stderr] 174 | | ipv4::IPv4Protocol::TCP => { [INFO] [stderr] 175 | | [INFO] [stderr] 176 | | if let Done(remaining, tcp_hdr) = tcp::parse_tcp_header(remaining) { [INFO] [stderr] ... | [INFO] [stderr] 184 | | _ => (), [INFO] [stderr] 185 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 173 | if let ipv4::IPv4Protocol::TCP = ip_hdr.protocol { [INFO] [stderr] 174 | [INFO] [stderr] 175 | if let Done(remaining, tcp_hdr) = tcp::parse_tcp_header(remaining) { [INFO] [stderr] 176 | log!(log_level, "tcp: {:?}", tcp_hdr); [INFO] [stderr] 177 | [INFO] [stderr] 178 | if let Some(result) = callback(ip_hdr, tcp_hdr, remaining)? { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/net.rs:254:39 [INFO] [stderr] | [INFO] [stderr] 254 | match tx.send_to(ipv4, IpAddr::V4(dst.ip().clone())) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*dst.ip()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:64:19 [INFO] [stderr] | [INFO] [stderr] 64 | let dst = connection.src.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `connection.src` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:65:19 [INFO] [stderr] | [INFO] [stderr] 65 | let src = connection.dst.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `connection.dst` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rshijack`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "fcdc4d11dc1d55a66e544821cfbdc692e8985ac71366cb96e3bfaf7450635caf"` [INFO] running `"docker" "rm" "-f" "fcdc4d11dc1d55a66e544821cfbdc692e8985ac71366cb96e3bfaf7450635caf"` [INFO] [stdout] fcdc4d11dc1d55a66e544821cfbdc692e8985ac71366cb96e3bfaf7450635caf