[INFO] updating cached repository kpcyrd/badtouch [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kpcyrd/badtouch [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kpcyrd/badtouch" "work/ex/clippy-test-run/sources/stable/gh/kpcyrd/badtouch"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kpcyrd/badtouch'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kpcyrd/badtouch" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kpcyrd/badtouch"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kpcyrd/badtouch'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b50a32f68d0320f96f440c2b194d047e278c2977 [INFO] sha for GitHub repo kpcyrd/badtouch: b50a32f68d0320f96f440c2b194d047e278c2977 [INFO] validating manifest of kpcyrd/badtouch on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kpcyrd/badtouch on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kpcyrd/badtouch [INFO] finished frobbing kpcyrd/badtouch [INFO] frobbed toml for kpcyrd/badtouch written to work/ex/clippy-test-run/sources/stable/gh/kpcyrd/badtouch/Cargo.toml [INFO] started frobbing kpcyrd/badtouch [INFO] finished frobbing kpcyrd/badtouch [INFO] frobbed toml for kpcyrd/badtouch written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kpcyrd/badtouch/Cargo.toml [INFO] crate kpcyrd/badtouch has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kpcyrd/badtouch against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/kpcyrd/badtouch:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 557eb538185c7262005f903057d4c606fc0b45e58a52a732d5465e7403337531 [INFO] running `"docker" "start" "-a" "557eb538185c7262005f903057d4c606fc0b45e58a52a732d5465e7403337531"` [INFO] [stderr] Checking thin-slice v0.1.1 [INFO] [stderr] Compiling openssl-sys v0.9.38 [INFO] [stderr] Compiling lua52-sys v0.1.1 [INFO] [stderr] Checking new_debug_unreachable v1.0.1 [INFO] [stderr] Checking pbr v1.0.1 [INFO] [stderr] Checking getch v0.2.0 [INFO] [stderr] Checking lber v0.1.6 [INFO] [stderr] Checking crossbeam-epoch v0.5.2 [INFO] [stderr] Compiling syn v0.14.9 [INFO] [stderr] Checking block-cipher-trait v0.5.3 [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Compiling structopt-derive v0.2.12 [INFO] [stderr] Checking futf v0.1.4 [INFO] [stderr] Checking crossbeam-deque v0.6.1 [INFO] [stderr] Checking hmac v0.7.0 [INFO] [stderr] Checking sha3 v0.8.0 [INFO] [stderr] Checking md-5 v0.8.0 [INFO] [stderr] Checking sha-1 v0.8.0 [INFO] [stderr] Checking blowfish v0.3.0 [INFO] [stderr] Compiling string_cache_codegen v0.4.1 [INFO] [stderr] Checking tendril v0.4.0 [INFO] [stderr] Checking tokio-threadpool v0.1.7 [INFO] [stderr] Compiling selectors v0.20.0 [INFO] [stderr] Checking bcrypt v0.2.0 [INFO] [stderr] Compiling openssl v0.10.13 [INFO] [stderr] Compiling native-tls v0.2.1 [INFO] [stderr] Checking mysql_common v0.9.2 [INFO] [stderr] Compiling string_cache v0.7.3 [INFO] [stderr] Compiling markup5ever v0.7.3 [INFO] [stderr] Checking structopt v0.2.12 [INFO] [stderr] Checking tokio-fs v0.1.3 [INFO] [stderr] Checking hlua-badtouch v0.4.2 [INFO] [stderr] Checking tokio v0.1.11 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking hyper v0.12.12 [INFO] [stderr] Checking mysql v14.1.0 [INFO] [stderr] Checking html5ever v0.22.3 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking tokio-uds v0.1.7 [INFO] [stderr] Checking tokio-tls v0.2.0 [INFO] [stderr] Compiling cssparser v0.24.1 [INFO] [stderr] Compiling cssparser-macros v0.3.4 [INFO] [stderr] Compiling synstructure v0.9.0 [INFO] [stderr] Checking hyper-tls v0.3.1 [INFO] [stderr] Checking tokio-uds-proto v0.1.1 [INFO] [stderr] Compiling failure_derive v0.1.2 [INFO] [stderr] Checking reqwest v0.9.2 [INFO] [stderr] Checking ldap3 v0.6.1 [INFO] [stderr] Checking failure v0.1.2 [INFO] [stderr] Checking kuchiki v0.7.2 [INFO] [stderr] Checking badtouch v0.6.1 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:21:1 [INFO] [stderr] | [INFO] [stderr] 21 | #[macro_use] extern crate structopt; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/runtime.rs:649:82 [INFO] [stderr] | [INFO] [stderr] 649 | lua.set("sock_newline", hlua::function2(move |sock: String, newline: String| -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:21:1 [INFO] [stderr] | [INFO] [stderr] 21 | #[macro_use] extern crate structopt; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/runtime.rs:649:82 [INFO] [stderr] | [INFO] [stderr] 649 | lua.set("sock_newline", hlua::function2(move |sock: String, newline: String| -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/ctx.rs:277:40 [INFO] [stderr] | [INFO] [stderr] 277 | let script = Script::load_from(r#" [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 278 | | descr = "verify_false" [INFO] [stderr] 279 | | [INFO] [stderr] 280 | | function verify(user, password) [INFO] [stderr] 281 | | return false [INFO] [stderr] 282 | | end [INFO] [stderr] 283 | | "#.as_bytes(), empty_config()).unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 277 | let script = Script::load_from(br#" [INFO] [stderr] 278 | descr = "verify_false" [INFO] [stderr] 279 | [INFO] [stderr] 280 | function verify(user, password) [INFO] [stderr] 281 | return false [INFO] [stderr] 282 | end [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/ctx.rs:291:40 [INFO] [stderr] | [INFO] [stderr] 291 | let script = Script::load_from(r#" [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 292 | | descr = "verify_false" [INFO] [stderr] 293 | | [INFO] [stderr] 294 | | function verify(user, password) [INFO] [stderr] 295 | | return true [INFO] [stderr] 296 | | end [INFO] [stderr] 297 | | "#.as_bytes(), empty_config()).unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 291 | let script = Script::load_from(br#" [INFO] [stderr] 292 | descr = "verify_false" [INFO] [stderr] 293 | [INFO] [stderr] 294 | function verify(user, password) [INFO] [stderr] 295 | return true [INFO] [stderr] 296 | end [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/ctx.rs:305:40 [INFO] [stderr] | [INFO] [stderr] 305 | let script = Script::load_from(r#" [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 306 | | descr = "json" [INFO] [stderr] 307 | | [INFO] [stderr] 308 | | function verify(user, password) [INFO] [stderr] ... | [INFO] [stderr] 311 | | end [INFO] [stderr] 312 | | "#.as_bytes(), empty_config()).unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 305 | let script = Script::load_from(br#" [INFO] [stderr] 306 | descr = "json" [INFO] [stderr] 307 | [INFO] [stderr] 308 | function verify(user, password) [INFO] [stderr] 309 | json_decode("{{{{{{{{{{{{{{{{{{") [INFO] [stderr] 310 | return true [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/ctx.rs:320:40 [INFO] [stderr] | [INFO] [stderr] 320 | let script = Script::load_from(r#" [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 321 | | descr = "json" [INFO] [stderr] 322 | | [INFO] [stderr] 323 | | function verify(user, password) [INFO] [stderr] ... | [INFO] [stderr] 327 | | end [INFO] [stderr] 328 | | "#.as_bytes(), empty_config()).unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 320 | let script = Script::load_from(br#" [INFO] [stderr] 321 | descr = "json" [INFO] [stderr] 322 | [INFO] [stderr] 323 | function verify(user, password) [INFO] [stderr] 324 | json_decode("{{{{{{{{{{{{{{{{{{") [INFO] [stderr] 325 | clear_err() [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/ctx.rs:336:40 [INFO] [stderr] | [INFO] [stderr] 336 | let script = Script::load_from(r#" [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 337 | | descr = "slow script" [INFO] [stderr] 338 | | [INFO] [stderr] 339 | | function verify(user, password) [INFO] [stderr] ... | [INFO] [stderr] 342 | | end [INFO] [stderr] 343 | | "#.as_bytes(), empty_config()).unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 336 | let script = Script::load_from(br#" [INFO] [stderr] 337 | descr = "slow script" [INFO] [stderr] 338 | [INFO] [stderr] 339 | function verify(user, password) [INFO] [stderr] 340 | sleep(1) [INFO] [stderr] 341 | return true [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/ctx.rs:351:40 [INFO] [stderr] | [INFO] [stderr] 351 | let script = Script::load_from(r#" [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 352 | | descr = "basic auth httpbin.org" [INFO] [stderr] 353 | | [INFO] [stderr] 354 | | function verify(user, password) [INFO] [stderr] 355 | | return http_basic_auth("https://httpbin.org/basic-auth/foo/buzz", user, password) [INFO] [stderr] 356 | | end [INFO] [stderr] 357 | | "#.as_bytes(), empty_config()).unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 351 | let script = Script::load_from(br#" [INFO] [stderr] 352 | descr = "basic auth httpbin.org" [INFO] [stderr] 353 | [INFO] [stderr] 354 | function verify(user, password) [INFO] [stderr] 355 | return http_basic_auth("https://httpbin.org/basic-auth/foo/buzz", user, password) [INFO] [stderr] 356 | end [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/ctx.rs:365:40 [INFO] [stderr] | [INFO] [stderr] 365 | let script = Script::load_from(r#" [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 366 | | descr = "basic auth httpbin.org" [INFO] [stderr] 367 | | [INFO] [stderr] 368 | | function verify(user, password) [INFO] [stderr] 369 | | return http_basic_auth("https://httpbin.org/basic-auth/foo/buzz", user, password) [INFO] [stderr] 370 | | end [INFO] [stderr] 371 | | "#.as_bytes(), empty_config()).unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 365 | let script = Script::load_from(br#" [INFO] [stderr] 366 | descr = "basic auth httpbin.org" [INFO] [stderr] 367 | [INFO] [stderr] 368 | function verify(user, password) [INFO] [stderr] 369 | return http_basic_auth("https://httpbin.org/basic-auth/foo/buzz", user, password) [INFO] [stderr] 370 | end [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/ctx.rs:379:40 [INFO] [stderr] | [INFO] [stderr] 379 | let script = Script::load_from(r#" [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 380 | | descr = "cookies httpbin.org" [INFO] [stderr] 381 | | [INFO] [stderr] 382 | | function verify(user, password) [INFO] [stderr] ... | [INFO] [stderr] 410 | | end [INFO] [stderr] 411 | | "#.as_bytes(), empty_config()).unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 379 | let script = Script::load_from(br#" [INFO] [stderr] 380 | descr = "cookies httpbin.org" [INFO] [stderr] 381 | [INFO] [stderr] 382 | function verify(user, password) [INFO] [stderr] 383 | session = http_mksession() [INFO] [stderr] 384 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/ctx.rs:419:40 [INFO] [stderr] | [INFO] [stderr] 419 | let script = Script::load_from(r#" [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 420 | | descr = "hex test" [INFO] [stderr] 421 | | [INFO] [stderr] 422 | | function verify(user, password) [INFO] [stderr] ... | [INFO] [stderr] 425 | | end [INFO] [stderr] 426 | | "#.as_bytes(), empty_config()).unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 419 | let script = Script::load_from(br#" [INFO] [stderr] 420 | descr = "hex test" [INFO] [stderr] 421 | [INFO] [stderr] 422 | function verify(user, password) [INFO] [stderr] 423 | x = hex({0x6F, 0x68, 0x61, 0x69, 0x0A, 0x00}) [INFO] [stderr] 424 | return x == "6f6861690a00" [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/ctx.rs:434:40 [INFO] [stderr] | [INFO] [stderr] 434 | let script = Script::load_from(r#" [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 435 | | descr = "hex test" [INFO] [stderr] 436 | | [INFO] [stderr] 437 | | function verify(user, password) [INFO] [stderr] ... | [INFO] [stderr] 440 | | end [INFO] [stderr] 441 | | "#.as_bytes(), empty_config()).unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 434 | let script = Script::load_from(br#" [INFO] [stderr] 435 | descr = "hex test" [INFO] [stderr] 436 | [INFO] [stderr] 437 | function verify(user, password) [INFO] [stderr] 438 | x = hex({}) [INFO] [stderr] 439 | return x == "" [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/ctx.rs:449:40 [INFO] [stderr] | [INFO] [stderr] 449 | let script = Script::load_from(r#" [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 450 | | descr = "json" [INFO] [stderr] 451 | | [INFO] [stderr] 452 | | function verify(user, password) [INFO] [stderr] ... | [INFO] [stderr] 464 | | end [INFO] [stderr] 465 | | "#.as_bytes(), empty_config()).unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 449 | let script = Script::load_from(br#" [INFO] [stderr] 450 | descr = "json" [INFO] [stderr] 451 | [INFO] [stderr] 452 | function verify(user, password) [INFO] [stderr] 453 | json_encode({ [INFO] [stderr] 454 | hello="world", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/ctx.rs:473:40 [INFO] [stderr] | [INFO] [stderr] 473 | let script = Script::load_from(r#" [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 474 | | descr = "json" [INFO] [stderr] 475 | | [INFO] [stderr] 476 | | function verify(user, password) [INFO] [stderr] ... | [INFO] [stderr] 490 | | end [INFO] [stderr] 491 | | "#.as_bytes(), empty_config()).unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 473 | let script = Script::load_from(br#" [INFO] [stderr] 474 | descr = "json" [INFO] [stderr] 475 | [INFO] [stderr] 476 | function verify(user, password) [INFO] [stderr] 477 | x = json_encode({ [INFO] [stderr] 478 | hello="world", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/ctx.rs:499:40 [INFO] [stderr] | [INFO] [stderr] 499 | let script = Script::load_from(r#" [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 500 | | descr = "json" [INFO] [stderr] 501 | | [INFO] [stderr] 502 | | function verify(user, password) [INFO] [stderr] ... | [INFO] [stderr] 505 | | end [INFO] [stderr] 506 | | "#.as_bytes(), empty_config()).unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 499 | let script = Script::load_from(br#" [INFO] [stderr] 500 | descr = "json" [INFO] [stderr] 501 | [INFO] [stderr] 502 | function verify(user, password) [INFO] [stderr] 503 | json_decode("{\"almost_one\":0.9999,\"data\":{\"password\":\"fizz\",\"user\":\"bar\"},\"hello\":\"world\",\"list\":[1,3,3,7]}") [INFO] [stderr] 504 | return true [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/ctx.rs:514:40 [INFO] [stderr] | [INFO] [stderr] 514 | let script = Script::load_from(r#" [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 515 | | descr = "json" [INFO] [stderr] 516 | | [INFO] [stderr] 517 | | function verify(user, password) [INFO] [stderr] ... | [INFO] [stderr] 520 | | end [INFO] [stderr] 521 | | "#.as_bytes(), empty_config()).unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 514 | let script = Script::load_from(br#" [INFO] [stderr] 515 | descr = "json" [INFO] [stderr] 516 | [INFO] [stderr] 517 | function verify(user, password) [INFO] [stderr] 518 | json_decode("{\"almost_one\":0.9999,\"data\":{\"password\":\"fizz\",\"user\":\"bar\"}}}}}}}}}") [INFO] [stderr] 519 | return true [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/ctx.rs:529:40 [INFO] [stderr] | [INFO] [stderr] 529 | let script = Script::load_from(r#" [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 530 | | descr = "hmac_md5" [INFO] [stderr] 531 | | [INFO] [stderr] 532 | | function verify(user, password) [INFO] [stderr] ... | [INFO] [stderr] 536 | | end [INFO] [stderr] 537 | | "#.as_bytes(), empty_config()).unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 529 | let script = Script::load_from(br#" [INFO] [stderr] 530 | descr = "hmac_md5" [INFO] [stderr] 531 | [INFO] [stderr] 532 | function verify(user, password) [INFO] [stderr] 533 | x = hex(hmac_md5("foo", "bar")) [INFO] [stderr] 534 | -- print('md5: ' .. x) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/ctx.rs:545:40 [INFO] [stderr] | [INFO] [stderr] 545 | let script = Script::load_from(r#" [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 546 | | descr = "hmac_sha1" [INFO] [stderr] 547 | | [INFO] [stderr] 548 | | function verify(user, password) [INFO] [stderr] ... | [INFO] [stderr] 552 | | end [INFO] [stderr] 553 | | "#.as_bytes(), empty_config()).unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 545 | let script = Script::load_from(br#" [INFO] [stderr] 546 | descr = "hmac_sha1" [INFO] [stderr] 547 | [INFO] [stderr] 548 | function verify(user, password) [INFO] [stderr] 549 | x = hex(hmac_sha1("foo", "bar")) [INFO] [stderr] 550 | -- print('sha1: ' .. x) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/ctx.rs:561:40 [INFO] [stderr] | [INFO] [stderr] 561 | let script = Script::load_from(r#" [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 562 | | descr = "hmac_sha2_256" [INFO] [stderr] 563 | | [INFO] [stderr] 564 | | function verify(user, password) [INFO] [stderr] ... | [INFO] [stderr] 568 | | end [INFO] [stderr] 569 | | "#.as_bytes(), empty_config()).unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 561 | let script = Script::load_from(br#" [INFO] [stderr] 562 | descr = "hmac_sha2_256" [INFO] [stderr] 563 | [INFO] [stderr] 564 | function verify(user, password) [INFO] [stderr] 565 | x = hex(hmac_sha2_256("foo", "bar")) [INFO] [stderr] 566 | -- print('sha2_256: ' .. x) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/ctx.rs:577:40 [INFO] [stderr] | [INFO] [stderr] 577 | let script = Script::load_from(r#" [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 578 | | descr = "hmac_sha2_512" [INFO] [stderr] 579 | | [INFO] [stderr] 580 | | function verify(user, password) [INFO] [stderr] ... | [INFO] [stderr] 584 | | end [INFO] [stderr] 585 | | "#.as_bytes(), empty_config()).unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 577 | let script = Script::load_from(br#" [INFO] [stderr] 578 | descr = "hmac_sha2_512" [INFO] [stderr] 579 | [INFO] [stderr] 580 | function verify(user, password) [INFO] [stderr] 581 | x = hex(hmac_sha2_512("foo", "bar")) [INFO] [stderr] 582 | -- print('sha2_512: ' .. x) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/ctx.rs:593:40 [INFO] [stderr] | [INFO] [stderr] 593 | let script = Script::load_from(r#" [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 594 | | descr = "hmac_sha3_256" [INFO] [stderr] 595 | | [INFO] [stderr] 596 | | function verify(user, password) [INFO] [stderr] ... | [INFO] [stderr] 600 | | end [INFO] [stderr] 601 | | "#.as_bytes(), empty_config()).unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 593 | let script = Script::load_from(br#" [INFO] [stderr] 594 | descr = "hmac_sha3_256" [INFO] [stderr] 595 | [INFO] [stderr] 596 | function verify(user, password) [INFO] [stderr] 597 | x = hex(hmac_sha3_256("foo", "bar")) [INFO] [stderr] 598 | -- print('sha3_256: ' .. x) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/ctx.rs:609:40 [INFO] [stderr] | [INFO] [stderr] 609 | let script = Script::load_from(r#" [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 610 | | descr = "hmac_sha3_512" [INFO] [stderr] 611 | | [INFO] [stderr] 612 | | function verify(user, password) [INFO] [stderr] ... | [INFO] [stderr] 616 | | end [INFO] [stderr] 617 | | "#.as_bytes(), empty_config()).unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 609 | let script = Script::load_from(br#" [INFO] [stderr] 610 | descr = "hmac_sha3_512" [INFO] [stderr] 611 | [INFO] [stderr] 612 | function verify(user, password) [INFO] [stderr] 613 | x = hex(hmac_sha3_512("foo", "bar")) [INFO] [stderr] 614 | -- print('sha3_512: ' .. x) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/ctx.rs:625:40 [INFO] [stderr] | [INFO] [stderr] 625 | let script = Script::load_from(r#" [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 626 | | descr = "bcrypt_verify" [INFO] [stderr] 627 | | [INFO] [stderr] 628 | | function verify(user, password) [INFO] [stderr] 629 | | return bcrypt_verify(password, "$2a$12$ByUlHCHx3rxMsdQONpuFbulQqut6GQ/84I5EAUkCqTTI07JA7wUju") [INFO] [stderr] 630 | | end [INFO] [stderr] 631 | | "#.as_bytes(), empty_config()).unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 625 | let script = Script::load_from(br#" [INFO] [stderr] 626 | descr = "bcrypt_verify" [INFO] [stderr] 627 | [INFO] [stderr] 628 | function verify(user, password) [INFO] [stderr] 629 | return bcrypt_verify(password, "$2a$12$ByUlHCHx3rxMsdQONpuFbulQqut6GQ/84I5EAUkCqTTI07JA7wUju") [INFO] [stderr] 630 | end [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/html.rs:57:21 [INFO] [stderr] | [INFO] [stderr] 57 | Ok(x) => Ok(x.into_iter().map(|x| transform_element(&x)).collect()), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/scheduler.rs:128:38 [INFO] [stderr] | [INFO] [stderr] 128 | pause_trigger: Arc::new((Mutex::new(true), Condvar::new())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mutex_atomic)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/html.rs:57:21 [INFO] [stderr] | [INFO] [stderr] 57 | Ok(x) => Ok(x.into_iter().map(|x| transform_element(&x)).collect()), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/scheduler.rs:128:38 [INFO] [stderr] | [INFO] [stderr] 128 | pause_trigger: Arc::new((Mutex::new(true), Condvar::new())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mutex_atomic)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> examples/load-creds.rs:11:16 [INFO] [stderr] | [INFO] [stderr] 11 | let path = env::args().skip(1).next().expect("missing argument"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 56s [INFO] running `"docker" "inspect" "557eb538185c7262005f903057d4c606fc0b45e58a52a732d5465e7403337531"` [INFO] running `"docker" "rm" "-f" "557eb538185c7262005f903057d4c606fc0b45e58a52a732d5465e7403337531"` [INFO] [stdout] 557eb538185c7262005f903057d4c606fc0b45e58a52a732d5465e7403337531