[INFO] updating cached repository kpberry/chess [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kpberry/chess [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kpberry/chess" "work/ex/clippy-test-run/sources/stable/gh/kpberry/chess"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kpberry/chess'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kpberry/chess" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kpberry/chess"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kpberry/chess'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] aa7ef1a176dc6a7ffd714357b6705c08877cf76e [INFO] sha for GitHub repo kpberry/chess: aa7ef1a176dc6a7ffd714357b6705c08877cf76e [INFO] validating manifest of kpberry/chess on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kpberry/chess on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kpberry/chess [INFO] finished frobbing kpberry/chess [INFO] frobbed toml for kpberry/chess written to work/ex/clippy-test-run/sources/stable/gh/kpberry/chess/Cargo.toml [INFO] started frobbing kpberry/chess [INFO] finished frobbing kpberry/chess [INFO] frobbed toml for kpberry/chess written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kpberry/chess/Cargo.toml [INFO] crate kpberry/chess has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kpberry/chess against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/kpberry/chess:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 78c4063d3f871dffc37f80648df322d3dc37f3457efeaac7dcd2898b81c1c980 [INFO] running `"docker" "start" "-a" "78c4063d3f871dffc37f80648df322d3dc37f3457efeaac7dcd2898b81c1c980"` [INFO] [stderr] Checking chess v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:99:21 [INFO] [stderr] | [INFO] [stderr] 99 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:113:21 [INFO] [stderr] | [INFO] [stderr] 113 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:99:21 [INFO] [stderr] | [INFO] [stderr] 99 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:113:21 [INFO] [stderr] | [INFO] [stderr] 113 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | return !self.same_color(color); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `!self.same_color(color)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:305:13 [INFO] [stderr] | [INFO] [stderr] 305 | / if Board::contains(new_pos) { [INFO] [stderr] 306 | | if self.occupied(new_pos) || self.en_passant(new_pos, color) { [INFO] [stderr] 307 | | offsets.push(offset); [INFO] [stderr] 308 | | } [INFO] [stderr] 309 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 305 | if Board::contains(new_pos) && (self.occupied(new_pos) || self.en_passant(new_pos, color)) { [INFO] [stderr] 306 | offsets.push(offset); [INFO] [stderr] 307 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:317:9 [INFO] [stderr] | [INFO] [stderr] 317 | / if first_turn { [INFO] [stderr] 318 | | if !self.occupied((pos.0, pos.1 + first_turn_offset.1)) { [INFO] [stderr] 319 | | offsets.push(first_turn_offset); [INFO] [stderr] 320 | | } [INFO] [stderr] 321 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 317 | if first_turn && !self.occupied((pos.0, pos.1 + first_turn_offset.1)) { [INFO] [stderr] 318 | offsets.push(first_turn_offset); [INFO] [stderr] 319 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: method is never used: `undo_move` [INFO] [stderr] --> src/main.rs:471:5 [INFO] [stderr] | [INFO] [stderr] 471 | fn undo_move(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:11:14 [INFO] [stderr] | [INFO] [stderr] 11 | fn other(&self) -> Color { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:18:12 [INFO] [stderr] | [INFO] [stderr] 18 | fn dir(&self) -> i8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:68:19 [INFO] [stderr] | [INFO] [stderr] 68 | fn same_color(&self, color: &Color) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:68:33 [INFO] [stderr] | [INFO] [stderr] 68 | fn same_color(&self, color: &Color) -> bool { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:80:20 [INFO] [stderr] | [INFO] [stderr] 80 | fn other_color(&self, color: &Color) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:80:34 [INFO] [stderr] | [INFO] [stderr] 80 | fn other_color(&self, color: &Color) -> bool { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:103:37 [INFO] [stderr] | [INFO] [stderr] 103 | print!(" {}", (('a' as u8) + i) as char); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'a' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:117:37 [INFO] [stderr] | [INFO] [stderr] 117 | print!(" {}", (('a' as u8) + i) as char); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'a' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:235:48 [INFO] [stderr] | [INFO] [stderr] 235 | fn en_passant(&self, pos: (i8, i8), color: &Color) -> bool { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:236:12 [INFO] [stderr] | [INFO] [stderr] 236 | if self.history.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.history.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:252:35 [INFO] [stderr] | [INFO] [stderr] 252 | fn is_endangered(&self, side: &Color, pos: (i8, i8)) -> bool { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:267:31 [INFO] [stderr] | [INFO] [stderr] 267 | fn find_king(&self, side: &Color) -> Option<(i8, i8)> { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:280:38 [INFO] [stderr] | [INFO] [stderr] 280 | fn king_is_in_check(&self, side: &Color) -> bool { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:288:49 [INFO] [stderr] | [INFO] [stderr] 288 | fn king_is_in_check_after_move(&self, side: &Color, start: (i8, i8), end: (i8, i8)) -> bool { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:295:52 [INFO] [stderr] | [INFO] [stderr] 295 | fn get_pawn_moves(&self, pos: (i8, i8), color: &Color) -> Vec<(i8, i8)> { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:364:51 [INFO] [stderr] | [INFO] [stderr] 364 | fn get_king_moves(&self, pos: (i8, i8), side: &Color, check_castle: bool) -> Vec<(i8, i8)> { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:429:21 [INFO] [stderr] | [INFO] [stderr] 429 | let check = match check_check { [INFO] [stderr] | _____________________^ [INFO] [stderr] 430 | | true => self.king_is_in_check_after_move(&side, start, end), [INFO] [stderr] 431 | | false => false, [INFO] [stderr] 432 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if check_check { self.king_is_in_check_after_move(&side, start, end) } else { false }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:459:20 [INFO] [stderr] | [INFO] [stderr] 459 | if self [INFO] [stderr] | ____________________^ [INFO] [stderr] 460 | | .get_valid_moves((i as i8, j as i8), side, true, true) [INFO] [stderr] 461 | | .len() [INFO] [stderr] 462 | | > 0 [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] help: using `is_empty` is clearer and more explicit [INFO] [stderr] | [INFO] [stderr] 459 | if !self [INFO] [stderr] 460 | .get_valid_moves((i as i8, j as i8), side, true, true).is_empty() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/main.rs:508:37 [INFO] [stderr] | [INFO] [stderr] 508 | fn make_moves(&mut self, moves: &[((i8, i8), (i8, i8))]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:524:42 [INFO] [stderr] | [INFO] [stderr] 524 | let start_x = (bytes[0] as u8) - ('a' as u8); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'a' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:525:47 [INFO] [stderr] | [INFO] [stderr] 525 | let start_y = 8 - ((bytes[1] as u8) - ('0' as u8)); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'0' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:531:40 [INFO] [stderr] | [INFO] [stderr] 531 | let end_x = (bytes[0] as u8) - ('a' as u8); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'a' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:532:45 [INFO] [stderr] | [INFO] [stderr] 532 | let end_y = 8 - ((bytes[1] as u8) - ('0' as u8)); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'0' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | return !self.same_color(color); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `!self.same_color(color)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:305:13 [INFO] [stderr] | [INFO] [stderr] 305 | / if Board::contains(new_pos) { [INFO] [stderr] 306 | | if self.occupied(new_pos) || self.en_passant(new_pos, color) { [INFO] [stderr] 307 | | offsets.push(offset); [INFO] [stderr] 308 | | } [INFO] [stderr] 309 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 305 | if Board::contains(new_pos) && (self.occupied(new_pos) || self.en_passant(new_pos, color)) { [INFO] [stderr] 306 | offsets.push(offset); [INFO] [stderr] 307 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:317:9 [INFO] [stderr] | [INFO] [stderr] 317 | / if first_turn { [INFO] [stderr] 318 | | if !self.occupied((pos.0, pos.1 + first_turn_offset.1)) { [INFO] [stderr] 319 | | offsets.push(first_turn_offset); [INFO] [stderr] 320 | | } [INFO] [stderr] 321 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 317 | if first_turn && !self.occupied((pos.0, pos.1 + first_turn_offset.1)) { [INFO] [stderr] 318 | offsets.push(first_turn_offset); [INFO] [stderr] 319 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: method is never used: `undo_move` [INFO] [stderr] --> src/main.rs:471:5 [INFO] [stderr] | [INFO] [stderr] 471 | fn undo_move(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:11:14 [INFO] [stderr] | [INFO] [stderr] 11 | fn other(&self) -> Color { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:18:12 [INFO] [stderr] | [INFO] [stderr] 18 | fn dir(&self) -> i8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:68:19 [INFO] [stderr] | [INFO] [stderr] 68 | fn same_color(&self, color: &Color) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:68:33 [INFO] [stderr] | [INFO] [stderr] 68 | fn same_color(&self, color: &Color) -> bool { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:80:20 [INFO] [stderr] | [INFO] [stderr] 80 | fn other_color(&self, color: &Color) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:80:34 [INFO] [stderr] | [INFO] [stderr] 80 | fn other_color(&self, color: &Color) -> bool { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:103:37 [INFO] [stderr] | [INFO] [stderr] 103 | print!(" {}", (('a' as u8) + i) as char); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'a' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:117:37 [INFO] [stderr] | [INFO] [stderr] 117 | print!(" {}", (('a' as u8) + i) as char); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'a' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:235:48 [INFO] [stderr] | [INFO] [stderr] 235 | fn en_passant(&self, pos: (i8, i8), color: &Color) -> bool { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:236:12 [INFO] [stderr] | [INFO] [stderr] 236 | if self.history.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.history.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:252:35 [INFO] [stderr] | [INFO] [stderr] 252 | fn is_endangered(&self, side: &Color, pos: (i8, i8)) -> bool { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:267:31 [INFO] [stderr] | [INFO] [stderr] 267 | fn find_king(&self, side: &Color) -> Option<(i8, i8)> { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:280:38 [INFO] [stderr] | [INFO] [stderr] 280 | fn king_is_in_check(&self, side: &Color) -> bool { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:288:49 [INFO] [stderr] | [INFO] [stderr] 288 | fn king_is_in_check_after_move(&self, side: &Color, start: (i8, i8), end: (i8, i8)) -> bool { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:295:52 [INFO] [stderr] | [INFO] [stderr] 295 | fn get_pawn_moves(&self, pos: (i8, i8), color: &Color) -> Vec<(i8, i8)> { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:364:51 [INFO] [stderr] | [INFO] [stderr] 364 | fn get_king_moves(&self, pos: (i8, i8), side: &Color, check_castle: bool) -> Vec<(i8, i8)> { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:429:21 [INFO] [stderr] | [INFO] [stderr] 429 | let check = match check_check { [INFO] [stderr] | _____________________^ [INFO] [stderr] 430 | | true => self.king_is_in_check_after_move(&side, start, end), [INFO] [stderr] 431 | | false => false, [INFO] [stderr] 432 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if check_check { self.king_is_in_check_after_move(&side, start, end) } else { false }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:459:20 [INFO] [stderr] | [INFO] [stderr] 459 | if self [INFO] [stderr] | ____________________^ [INFO] [stderr] 460 | | .get_valid_moves((i as i8, j as i8), side, true, true) [INFO] [stderr] 461 | | .len() [INFO] [stderr] 462 | | > 0 [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] help: using `is_empty` is clearer and more explicit [INFO] [stderr] | [INFO] [stderr] 459 | if !self [INFO] [stderr] 460 | .get_valid_moves((i as i8, j as i8), side, true, true).is_empty() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/main.rs:508:37 [INFO] [stderr] | [INFO] [stderr] 508 | fn make_moves(&mut self, moves: &[((i8, i8), (i8, i8))]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:524:42 [INFO] [stderr] | [INFO] [stderr] 524 | let start_x = (bytes[0] as u8) - ('a' as u8); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'a' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:525:47 [INFO] [stderr] | [INFO] [stderr] 525 | let start_y = 8 - ((bytes[1] as u8) - ('0' as u8)); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'0' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:531:40 [INFO] [stderr] | [INFO] [stderr] 531 | let end_x = (bytes[0] as u8) - ('a' as u8); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'a' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:532:45 [INFO] [stderr] | [INFO] [stderr] 532 | let end_y = 8 - ((bytes[1] as u8) - ('0' as u8)); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'0' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.29s [INFO] running `"docker" "inspect" "78c4063d3f871dffc37f80648df322d3dc37f3457efeaac7dcd2898b81c1c980"` [INFO] running `"docker" "rm" "-f" "78c4063d3f871dffc37f80648df322d3dc37f3457efeaac7dcd2898b81c1c980"` [INFO] [stdout] 78c4063d3f871dffc37f80648df322d3dc37f3457efeaac7dcd2898b81c1c980