[INFO] updating cached repository kotorihq/kotori-cli-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kotorihq/kotori-cli-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kotorihq/kotori-cli-rs" "work/ex/clippy-test-run/sources/stable/gh/kotorihq/kotori-cli-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kotorihq/kotori-cli-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kotorihq/kotori-cli-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kotorihq/kotori-cli-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kotorihq/kotori-cli-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f6e14886ce22a5c4bd8b97a3a731cbfa4777899f [INFO] sha for GitHub repo kotorihq/kotori-cli-rs: f6e14886ce22a5c4bd8b97a3a731cbfa4777899f [INFO] validating manifest of kotorihq/kotori-cli-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kotorihq/kotori-cli-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kotorihq/kotori-cli-rs [INFO] finished frobbing kotorihq/kotori-cli-rs [INFO] frobbed toml for kotorihq/kotori-cli-rs written to work/ex/clippy-test-run/sources/stable/gh/kotorihq/kotori-cli-rs/Cargo.toml [INFO] started frobbing kotorihq/kotori-cli-rs [INFO] finished frobbing kotorihq/kotori-cli-rs [INFO] frobbed toml for kotorihq/kotori-cli-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kotorihq/kotori-cli-rs/Cargo.toml [INFO] crate kotorihq/kotori-cli-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kotorihq/kotori-cli-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/kotorihq/kotori-cli-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4c6fa279c2c20021e84d6bb30b8b7deeab7bec378435cb93ea7602c49c9e7ff3 [INFO] running `"docker" "start" "-a" "4c6fa279c2c20021e84d6bb30b8b7deeab7bec378435cb93ea7602c49c9e7ff3"` [INFO] [stderr] Checking time v0.1.39 [INFO] [stderr] Checking atty v0.2.8 [INFO] [stderr] Checking net2 v0.2.32 [INFO] [stderr] Checking log v0.4.5 [INFO] [stderr] Checking encoding_rs v0.8.6 [INFO] [stderr] Checking textwrap v0.10.0 [INFO] [stderr] Checking crossbeam-epoch v0.5.2 [INFO] [stderr] Checking bytes v0.4.10 [INFO] [stderr] Checking uuid v0.6.5 [INFO] [stderr] Compiling rand v0.3.22 [INFO] [stderr] Checking log v0.3.9 [INFO] [stderr] Checking want v0.0.4 [INFO] [stderr] Checking clap v2.32.0 [INFO] [stderr] Checking backtrace-sys v0.1.16 [INFO] [stderr] Compiling openssl v0.9.24 [INFO] [stderr] Checking openssl-sys v0.9.27 [INFO] [stderr] Checking url v1.7.1 [INFO] [stderr] Checking serde_json v1.0.13 [INFO] [stderr] Checking mio v0.6.14 [INFO] [stderr] Checking crossbeam-deque v0.6.1 [INFO] [stderr] Checking tokio-io v0.1.8 [INFO] [stderr] Compiling phf_generator v0.7.21 [INFO] [stderr] Checking backtrace v0.3.5 [INFO] [stderr] Compiling serde_derive v1.0.78 [INFO] [stderr] Checking tokio-threadpool v0.1.6 [INFO] [stderr] Compiling phf_codegen v0.7.21 [INFO] [stderr] Checking serde_urlencoded v0.5.1 [INFO] [stderr] Checking tokio-codec v0.1.0 [INFO] [stderr] Checking failure v0.1.2 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Checking tokio-reactor v0.1.1 [INFO] [stderr] Compiling mime_guess v2.0.0-alpha.6 [INFO] [stderr] Checking tokio-fs v0.1.3 [INFO] [stderr] Checking tokio-udp v0.1.0 [INFO] [stderr] Checking tokio-uds v0.2.1 [INFO] [stderr] Checking tokio-tcp v0.1.0 [INFO] [stderr] Checking tokio v0.1.8 [INFO] [stderr] Checking native-tls v0.1.5 [INFO] [stderr] Checking tokio-core v0.1.16 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking hyper v0.11.27 [INFO] [stderr] Checking hyper-tls v0.1.3 [INFO] [stderr] Checking reqwest v0.8.8 [INFO] [stderr] Checking kotori-cli-rs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/commands/project_list.rs:30:36 [INFO] [stderr] | [INFO] [stderr] 30 | println!("{:<25}{}", "ID", "PROJECT NAME"); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/commands/key_list.rs:32:37 [INFO] [stderr] | [INFO] [stderr] 32 | println!("{:<25}{}", "KEY", "READ-ONLY"); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/commands/project_list.rs:30:36 [INFO] [stderr] | [INFO] [stderr] 30 | println!("{:<25}{}", "ID", "PROJECT NAME"); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/commands/key_list.rs:32:37 [INFO] [stderr] | [INFO] [stderr] 32 | println!("{:<25}{}", "KEY", "READ-ONLY"); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/cli.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | app [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/cli.rs:28:15 [INFO] [stderr] | [INFO] [stderr] 28 | let app = App::new("Kotori CLI") [INFO] [stderr] | _______________^ [INFO] [stderr] 29 | | .settings(&[AppSettings::SubcommandRequiredElseHelp, AppSettings::VersionlessSubcommands]) [INFO] [stderr] 30 | | .version("0.1.0") [INFO] [stderr] 31 | | .arg(Arg::with_name("master-key") [INFO] [stderr] ... | [INFO] [stderr] 39 | | .required(true)) [INFO] [stderr] 40 | | .subcommands(commands::cmd_list()); [INFO] [stderr] | |__________________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/commands/command_base.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | return handle_response(&mut response, &f_success, &f_error); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `handle_response(&mut response, &f_success, &f_error)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/commands/command_base.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | return default_handle_error_response(response); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `default_handle_error_response(response)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/commands/project_list.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | / return super::command_base::do_request(config, Method::Get, &url, None, [INFO] [stderr] 49 | | &ProjectListCommand::handle_success_response, None); [INFO] [stderr] | |___________________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 48 | super::command_base::do_request(config, Method::Get, &url, None, [INFO] [stderr] 49 | &ProjectListCommand::handle_success_response, None) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/commands/project_create_upsert.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | / return super::command_base::do_request(config, method, &url, Some(¶ms), [INFO] [stderr] 72 | | &ProjectCreateCommand::handle_success_response, None); [INFO] [stderr] | |_____________________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 71 | super::command_base::do_request(config, method, &url, Some(¶ms), [INFO] [stderr] 72 | &ProjectCreateCommand::handle_success_response, None) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/commands/project_delete.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | / return super::command_base::do_request(config, Method::Delete, &url, None, [INFO] [stderr] 31 | | &ProjectDeleteCommand::handle_success_response, None); [INFO] [stderr] | |_____________________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 30 | super::command_base::do_request(config, Method::Delete, &url, None, [INFO] [stderr] 31 | &ProjectDeleteCommand::handle_success_response, None) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/commands/key_list.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | / return super::command_base::do_request(config, Method::Get, &url, None, [INFO] [stderr] 55 | | &KeyListCommand::handle_success_response, None); [INFO] [stderr] | |_______________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 54 | super::command_base::do_request(config, Method::Get, &url, None, [INFO] [stderr] 55 | &KeyListCommand::handle_success_response, None) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/commands/key_create_upsert.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | / return super::command_base::do_request(config, method, &url, Some(¶ms), [INFO] [stderr] 79 | | &KeyCreateUpsertCommand::handle_success_response, None); [INFO] [stderr] | |_______________________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 78 | super::command_base::do_request(config, method, &url, Some(¶ms), [INFO] [stderr] 79 | &KeyCreateUpsertCommand::handle_success_response, None) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/commands/key_delete.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | / return super::command_base::do_request(config, Method::Delete, &url, None, [INFO] [stderr] 40 | | &KeyDeleteCommand::handle_success_response, None); [INFO] [stderr] | |_________________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 39 | super::command_base::do_request(config, Method::Delete, &url, None, [INFO] [stderr] 40 | &KeyDeleteCommand::handle_success_response, None) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/cli.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | app [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/cli.rs:28:15 [INFO] [stderr] | [INFO] [stderr] 28 | let app = App::new("Kotori CLI") [INFO] [stderr] | _______________^ [INFO] [stderr] 29 | | .settings(&[AppSettings::SubcommandRequiredElseHelp, AppSettings::VersionlessSubcommands]) [INFO] [stderr] 30 | | .version("0.1.0") [INFO] [stderr] 31 | | .arg(Arg::with_name("master-key") [INFO] [stderr] ... | [INFO] [stderr] 39 | | .required(true)) [INFO] [stderr] 40 | | .subcommands(commands::cmd_list()); [INFO] [stderr] | |__________________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/commands/command_base.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | return handle_response(&mut response, &f_success, &f_error); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `handle_response(&mut response, &f_success, &f_error)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/commands/command_base.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | return default_handle_error_response(response); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `default_handle_error_response(response)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/commands/project_list.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | / return super::command_base::do_request(config, Method::Get, &url, None, [INFO] [stderr] 49 | | &ProjectListCommand::handle_success_response, None); [INFO] [stderr] | |___________________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 48 | super::command_base::do_request(config, Method::Get, &url, None, [INFO] [stderr] 49 | &ProjectListCommand::handle_success_response, None) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/commands/project_create_upsert.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | / return super::command_base::do_request(config, method, &url, Some(¶ms), [INFO] [stderr] 72 | | &ProjectCreateCommand::handle_success_response, None); [INFO] [stderr] | |_____________________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 71 | super::command_base::do_request(config, method, &url, Some(¶ms), [INFO] [stderr] 72 | &ProjectCreateCommand::handle_success_response, None) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/commands/project_delete.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | / return super::command_base::do_request(config, Method::Delete, &url, None, [INFO] [stderr] 31 | | &ProjectDeleteCommand::handle_success_response, None); [INFO] [stderr] | |_____________________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 30 | super::command_base::do_request(config, Method::Delete, &url, None, [INFO] [stderr] 31 | &ProjectDeleteCommand::handle_success_response, None) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/commands/key_list.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | / return super::command_base::do_request(config, Method::Get, &url, None, [INFO] [stderr] 55 | | &KeyListCommand::handle_success_response, None); [INFO] [stderr] | |_______________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 54 | super::command_base::do_request(config, Method::Get, &url, None, [INFO] [stderr] 55 | &KeyListCommand::handle_success_response, None) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/commands/key_create_upsert.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | / return super::command_base::do_request(config, method, &url, Some(¶ms), [INFO] [stderr] 79 | | &KeyCreateUpsertCommand::handle_success_response, None); [INFO] [stderr] | |_______________________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 78 | super::command_base::do_request(config, method, &url, Some(¶ms), [INFO] [stderr] 79 | &KeyCreateUpsertCommand::handle_success_response, None) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/commands/key_delete.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | / return super::command_base::do_request(config, Method::Delete, &url, None, [INFO] [stderr] 40 | | &KeyDeleteCommand::handle_success_response, None); [INFO] [stderr] | |_________________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 39 | super::command_base::do_request(config, Method::Delete, &url, None, [INFO] [stderr] 40 | &KeyDeleteCommand::handle_success_response, None) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/commands/command_base.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | / if let &Some(f_err) = f_error { [INFO] [stderr] 39 | | return f_err(response); [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 38 | if let Some(f_err) = *f_error { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/commands/kotori_group_command.rs:25:41 [INFO] [stderr] | [INFO] [stderr] 25 | fn cmd_exec(&self, subcmd: &str) -> Option Result<(), Error>>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/commands/project.rs:28:41 [INFO] [stderr] | [INFO] [stderr] 28 | fn cmd_exec(&self, subcmd: &str) -> Option Result<(), Error>> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/commands/key.rs:28:41 [INFO] [stderr] | [INFO] [stderr] 28 | fn cmd_exec(&self, subcmd: &str) -> Option Result<(), Error>> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/commands/command_base.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | / if let &Some(f_err) = f_error { [INFO] [stderr] 39 | | return f_err(response); [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 38 | if let Some(f_err) = *f_error { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/commands/kotori_group_command.rs:25:41 [INFO] [stderr] | [INFO] [stderr] 25 | fn cmd_exec(&self, subcmd: &str) -> Option Result<(), Error>>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/commands/project.rs:28:41 [INFO] [stderr] | [INFO] [stderr] 28 | fn cmd_exec(&self, subcmd: &str) -> Option Result<(), Error>> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/commands/key.rs:28:41 [INFO] [stderr] | [INFO] [stderr] 28 | fn cmd_exec(&self, subcmd: &str) -> Option Result<(), Error>> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 07s [INFO] running `"docker" "inspect" "4c6fa279c2c20021e84d6bb30b8b7deeab7bec378435cb93ea7602c49c9e7ff3"` [INFO] running `"docker" "rm" "-f" "4c6fa279c2c20021e84d6bb30b8b7deeab7bec378435cb93ea7602c49c9e7ff3"` [INFO] [stdout] 4c6fa279c2c20021e84d6bb30b8b7deeab7bec378435cb93ea7602c49c9e7ff3