[INFO] updating cached repository kosmakoff/simple_compiler [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kosmakoff/simple_compiler [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kosmakoff/simple_compiler" "work/ex/clippy-test-run/sources/stable/gh/kosmakoff/simple_compiler"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kosmakoff/simple_compiler'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kosmakoff/simple_compiler" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kosmakoff/simple_compiler"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kosmakoff/simple_compiler'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f6ac8a8882e45dee03dd127890f22c59da49e8e4 [INFO] sha for GitHub repo kosmakoff/simple_compiler: f6ac8a8882e45dee03dd127890f22c59da49e8e4 [INFO] validating manifest of kosmakoff/simple_compiler on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kosmakoff/simple_compiler on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kosmakoff/simple_compiler [INFO] finished frobbing kosmakoff/simple_compiler [INFO] frobbed toml for kosmakoff/simple_compiler written to work/ex/clippy-test-run/sources/stable/gh/kosmakoff/simple_compiler/Cargo.toml [INFO] started frobbing kosmakoff/simple_compiler [INFO] finished frobbing kosmakoff/simple_compiler [INFO] frobbed toml for kosmakoff/simple_compiler written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kosmakoff/simple_compiler/Cargo.toml [INFO] crate kosmakoff/simple_compiler has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kosmakoff/simple_compiler against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/kosmakoff/simple_compiler:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 315289972f56f5166ad5e8b1bc938aea30674175c479e2c0925416081aa19c15 [INFO] running `"docker" "start" "-a" "315289972f56f5166ad5e8b1bc938aea30674175c479e2c0925416081aa19c15"` [INFO] [stderr] Checking simple_compiler v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/tokenizer/mod.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | self.pos = self.pos + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.pos += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/tokenizer/mod.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | result = result + self.eat_integer()?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `result += self.eat_integer()?` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the `token @ _` pattern can be written as just `token` [INFO] [stderr] --> src/tokenizer/mod.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | token @ _ => return Err(format!("Expected PLUS | MINUS, encountered: {:?}", token)) [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/tokenizer/mod.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | result = result + self.eat_integer()?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `result += self.eat_integer()?` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/tokenizer/mod.rs:138:42 [INFO] [stderr] | [INFO] [stderr] 138 | while let Some((_, c)) = iterator.next() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `for (_, c) in iterator { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/tokenizer/mod.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | self.pos = self.pos + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.pos += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/tokenizer/mod.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | result = result + self.eat_integer()?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `result += self.eat_integer()?` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the `token @ _` pattern can be written as just `token` [INFO] [stderr] --> src/tokenizer/mod.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | token @ _ => return Err(format!("Expected PLUS | MINUS, encountered: {:?}", token)) [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/tokenizer/mod.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | result = result + self.eat_integer()?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `result += self.eat_integer()?` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/tokenizer/mod.rs:138:42 [INFO] [stderr] | [INFO] [stderr] 138 | while let Some((_, c)) = iterator.next() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `for (_, c) in iterator { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.03s [INFO] running `"docker" "inspect" "315289972f56f5166ad5e8b1bc938aea30674175c479e2c0925416081aa19c15"` [INFO] running `"docker" "rm" "-f" "315289972f56f5166ad5e8b1bc938aea30674175c479e2c0925416081aa19c15"` [INFO] [stdout] 315289972f56f5166ad5e8b1bc938aea30674175c479e2c0925416081aa19c15